Meta tags:
description= CLI tool for Angular. Contribute to angular/angular-cli development by creating an account on GitHub.;
Headings (most frequently used words):
uh, oh, for, fix, angular, tsconfig, vitest, coverage, this, code, comment, navigation, pr, apr, 20, 2026, gemini, assist, bot, choose, reason, hiding, build, forward, paths, as, vite, aliases, to, cli, tomeelog, what, is, the, behavior, footer, 33024, menu, repository, 33024tomeelog, wants, merge, commit, intoangular, mainangular, mainfrom, pathstomeelog, pathscopy, head, branch, name, clipboard, conversation, checklist, type, current, new, does, introduce, breaking, change, other, information, review, commented, left, reviewers, assignees, labels, projects, milestone, development, participant,
Text of the page (most frequently used words):
the (39), this (29), #angular (28), for (22), and (22), comment (19), vitest (19), tsconfig (19), paths (18), coverage (17), code (16), github (14), path (13), vite (13), build (12), aliases (12), applied (11), json (11), fix (11), was (10), copy (10), resolve (10), cli (10), please (9), while (9), changes (9), there (9), reload (9), alias (9), util (9), reason (9), resolved (8), bot (8), all (8), src (8), tomeelog (8), that (7), suggestion (7), cannot (7), suggestions (7), from (7), error (7), gemini (7), assist (7), join (7), file (7), const (7), with (7), during (7), not (6), 2026 (6), pull (6), commit (6), loading (6), page (6), more (6), learn (6), target (6), basedir (6), replacement (6), find (6), return (6), targetdir (6), replace (6), quality (6), choose (6), hiding (6), test (6), you (5), can (5), security (5), request (5), change (5), sign (5), what (5), exact (5), new (5), apr (5), support (5), fixes (5), forward (5), features (5), main (5), your (5), merge (4), comments (4), outdated (4), may (4), issues (4), review (4), reactions (4), sorry (4), something (4), went (4), wrong (4), behavior (4), style (4), describe (4), markdown (4), link (4), raw (4), parse (4), them (4), files (4), instrumentation (4), both (4), into (4), does (4), 33024 (4), copilot (4), navigation (3), line (3), been (3), valid (3), add (3), batch (3), one (3), because (3), have (3), conversation (3), hidden (3), characters (3), unicode (3), open (3), toposixpath (3), pattern (3), prefix (3), escaperegexp (3), regexp (3), posix (3), using (3), hide (3), low (3), duplicate (3), off (3), topic (3), abuse (3), spam (3), will (3), displayed (3), others (3), problem (3), unit (3), regex (3), breaking (3), strings (3), patterns (3), compileroptions (3), added (3), import (3), analysis (3), project (3), other (3), are (3), app (3), documentation (3), message (3), another (3), tab (3), window (3), refresh (3), session (3), developers (3), changelog (3), customer (3), enterprise (3), grade (3), time (2), information (2), docs (2), community (2), status (2), footer (2), now (2), check (2), lines (2), single (2), only (2), these (2), development (2), milestone (2), projects (2), area (2), reviewers (2), requirements (2), left (2), contains (2), bidirectional (2), about (2), suggested (2), across (2), normalize (2), format (2), correctly (2), resolution (2), packages (2), builders (2), runners (2), plugins (2), thread (2), current (2), stripping (2), accounts (2), avoid (2), https (2), before (2), parsing (2), failed (2), compatible (2), platform (2), reviewed (2), when (2), plugin (2), fails (2), source (2), integration (2), configuration (2), reads (2), entry (2), supporting (2), wildcard (2), projectdefaults (2), config (2), workspace (2), execution (2), 32891 (2), end (2), introduce (2), content (2), related (2), bug (2), guidelines (2), wants (2), head (2), branch (2), name (2), clipboard (2), insights (2), actions (2), 196 (2), repository (2), signed (2), universe (2), training (2), integrations (2), stories (2), center (2), business (2), products (2), secret (2), perform, action, share, personal, manage, cookies, contact, privacy, terms, inc, right, back, later, queued, multi, pending, reviews, has, marked, must, existing, order, create, applying, deleted, supported, per, viewing, subset, closed, invalid, were, made, participant, successfully, merging, close, none, yet, labels, assigned, assignees, whose, approvals, affect, reviewer, already, account, free, show, text, interpreted, compiled, differently, than, appears, below, editor, reveals, ensure, consistent, different, operating, systems, especially, windows, recommended, generally, prefer, formatted, absolute, mixing, slashes, lead, 105, prone, example, urls, like, safer, approach, use, accidental, matches, within, contain, strip, await, readfile, tsconfigpath, utf, try, introduces, resolving, testing, specifically, addressing, where, includes, logic, map, feedback, provided, regarding, robustness, need, better, cross, compatibility, view, label, robot, enabled, imports, original, processing, did, expose, those, converts, every, injects, used, makes, available, 008fc74, vites, reaction, reacted, eyes, emoji, spec, verifies, builder, harness, paths_spec, intentionally, narrow, leaving, behaviour, unchanged, syntax, stripped, handle, real, world, configs, baseurl, yes, read, initialisation, its, entries, converted, objects, injected, passes, issue, number, happens, they, compilation, esbuild, but, own, based, pass, pre, transform, exist, configures, runs, phase, true, refactoring, functional, api, update, formatting, local, variables, feature, bugfix, kind, type, updated, tests, follows, our, com, blob, contributing, confirm, fulfills, following, checklist, commented, changed, checks, commits, items, requests, dismiss, alert, switched, out, appearance, settings, search, pricing, event, talks, workshops, next, partners, company, forum, events, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, why, evaluate, see, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, latest, improvements, place, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, environments, codespaces, enforcement, automation, ship, coding, agent, tasks, automated, work, hosting, collaboration, menu, skip,
Text of the page (random words):
fix angular build forward tsconfig paths as vite aliases for vitest coverage by tomeelog pull request 33024 angular angular cli github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message angular angular cli repository navigation code issues 196 196 pull requests 20 20 actions security and quality 8 8 insights more items fix angular build forward tsconfig paths as vite aliases for vitest coverage 33024 33024 open tomeelog wants to merge 1 commit into angular main angular angular cli main from tomeelog fix vitest coverage tsconfig paths tomeelog angular cli fix vitest coverage tsconfig paths copy head branch name to clipboard conversation commits 1 1 checks files changed open fix angular build forward tsconfig paths as vite aliases for vitest coverage 33024 tomeelog wants to merge 1 commit into angular main angular angular cli main from tomeelog fix vitest coverage tsconfig paths tomeelog angular cli fix vitest coverage tsconfig paths copy head branch name to clipboard conversation tomeelog commented apr 20 2026 copy link copy markdown pr checklist please check to confirm your pr fulfills the following requirements the commit message follows our guidelines https github com angular angular cli blob main contributing md commit message guidelines tests for the changes have been added for bug fixes features docs have been added updated for bug fixes features pr type what kind of change does this pr introduce bugfix feature code style update formatting local variables refactoring no functional changes no api changes build related changes ci related changes documentation content changes other please describe what is the current behavior when a project configures compileroptions paths in tsconfig json e g src app and runs ng test with coverage true vitest s vite import analysis plugin fails during the coverage phase with pre transform error failed to resolve import util from src app app ts does the file exist this happens because the angular cli s vitest integration does not forward tsconfig path aliases to vite s resolve alias configuration they are resolved during compilation by esbuild but not during vitest s own vite based coverage instrumentation pass issue number 32891 what is the new behavior the tsconfig file is read at vitest initialisation time its compileroptions paths entries are converted to vite compatible resolve alias objects supporting both exact and wildcard patterns and injected into the projectdefaults resolve alias config that the angular cli passes to the vitest project workspace path aliases are now resolved correctly during both test execution and coverage instrumentation does this pr introduce a breaking change yes no other information the fix is intentionally narrow it only reads paths and baseurl from the tsconfig leaving all other resolution behaviour unchanged comment syntax in tsconfig files c style and is stripped before json parsing to handle real world configs a new behavior spec vitest coverage tsconfig paths_spec ts verifies the fix end to end using the builder test harness sorry something went wrong uh oh there was an error while loading please reload this page 1 gemini code assist bot reacted with eyes emoji all reactions 1 reaction fix angular build forward tsconfig paths as vite aliases for vites 008fc74 t coverage when using tsconfig json paths e g util src util with coverage enabled vitest s vite import analysis plugin fails to resolve path alias imports from original source files during coverage processing because the angular cli s vitest integration did not expose those aliases to the vite resolve configuration the fix reads the tsconfig file converts every paths entry to a vite resolve alias entry supporting both exact and wildcard patterns and injects them into the projectdefaults resolve config used by the project workspace this makes path aliases available during both test execution and coverage instrumentation fixes angular 32891 angular robot bot added the area angular build label apr 20 2026 gemini code assist bot reviewed apr 20 2026 view reviewed changes gemini code assist bot left a comment copy link copy markdown there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment code review this pull request introduces support for resolving tsconfig path aliases during vitest unit testing specifically addressing issues where coverage instrumentation failed to resolve these aliases it includes logic to parse compileroptions paths from the tsconfig file and map them to vite compatible resolve aliases feedback was provided regarding the robustness of the json comment stripping regex to avoid breaking valid strings and the need to normalize resolved paths to posix format for better cross platform compatibility sorry something went wrong uh oh there was an error while loading please reload this page all reactions comment thread packages angular build src builders unit test runners vitest plugins ts try const raw await readfile tsconfigpath utf 8 tsconfig files may contain c style comments strip them before parsing const json json parse raw replace s s n g gemini code assist bot apr 20 2026 copy link copy markdown there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment the current regex for stripping comments is prone to breaking valid json if it contains strings with or for example urls like https angular io or path patterns a safer approach is to use a regex that accounts for strings to avoid accidental matches within them suggested change const json json parse raw replace s s n g const json json parse raw replace s s g m g1 g1 sorry something went wrong uh oh there was an error while loading please reload this page all reactions comment thread packages angular build src builders unit test runners vitest plugins ts comment on lines 98 to 105 const targetdir path join basedir target replace return find new regexp escaperegexp prefix replacement targetdir 1 exact alias util src util return find pattern replacement path join basedir target gemini code assist bot apr 20 2026 copy link copy markdown there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment to ensure consistent behavior across different operating systems especially on windows it is recommended to normalize the resolved alias paths to posix format using toposixpath vite and vitest generally prefer posix style paths or correctly formatted absolute paths for aliases and mixing slashes e g c path to file can lead to resolution issues suggested change const targetdir path join basedir target replace return find new regexp escaperegexp prefix replacement targetdir 1 exact alias util src util return find pattern replacement path join basedir target const targetdir toposixpath path join basedir target replace return find new regexp escaperegexp prefix replacement targetdir 1 exact alias util src util return find pattern replacement toposixpath path join basedir target sorry something went wrong uh oh there was an error while loading please reload this page all reactions this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters sign up for free to join this conversation on github already have an account sign in to comment reviewers 1 more reviewer gemini code assist bot gemini code assist bot left review comments reviewers whose approvals may not affect merge requirements uh oh there was an error while loading please reload this page assignees no one assigned labels area angular build projects none yet milestone no milestone development successfully merging this pull request may close these issues uh oh there was an error while loading please reload this page 1 participant add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge suggestion cannot be applied right now please check back later footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
|