Meta tags:
description= CLI tool for Angular. Contribute to angular/angular-cli development by creating an account on GitHub.;
Headings (most frequently used words):
uh, oh, this, angular, cli, propagate, package, manager, terencehonles, nov, 11, 2026, comment, navigation, pr, code, choose, reason, for, hiding, fix, errors, when, install, fails, to, what, is, the, behavior, footer, commented, gemini, assist, bot, loading, 34682, menu, repository, 34682terencehonles, wants, merge, commit, intoangular, mainangular, mainfrom, errorsterencehonles, errorscopy, head, branch, name, clipboard, conversation, checklist, type, current, new, does, introduce, breaking, change, other, information, review, left, edited, there, was, an, error, while, please, reload, page, reviewers, assignees, labels, projects, milestone, development, participant,
Text of the page (most frequently used words):
the (43), this (37), angular (26), package (21), error (20), cli (20), #manager (20), and (19), #install (18), was (16), comment (16), errors (16), message (16), code (15), for (15), github (14), propagate (13), terencehonles (13), stderr (13), stdout (13), copy (12), applied (11), please (11), while (11), there (11), reload (11), 2026 (10), that (9), not (9), changes (9), loading (9), reason (9), cannot (8), change (8), page (8), update (8), all (8), colors (8), suggestion (7), suggestions (7), bot (7), fix (7), when (7), nov (7), packages (7), you (6), pull (6), commit (6), gemini (6), assist (6), more (6), what (6), learn (6), fails (6), quality (6), choose (6), hiding (6), bold (6), trim (6), can (5), security (5), request (5), from (5), review (5), sign (5), sorry (5), something (5), went (5), wrong (5), reactions (5), would (5), markdown (5), link (5), packagemanagererror (5), unable (5), features (5), main (5), your (5), merge (4), resolved (4), outdated (4), have (4), branch (4), with (4), assertiserror (4), will (4), describe (4), new (4), throw (4), const (4), other (4), build (4), fixes (4), 34682 (4), support (4), copilot (4), navigation (3), line (3), been (3), add (3), batch (3), only (3), one (3), because (3), may (3), conversation (3), show (3), hidden (3), characters (3), file (3), unicode (3), open (3), easier (3), why (3), related (3), using (3), pnpm (3), contributor (3), hide (3), low (3), duplicate (3), off (3), topic (3), abuse (3), spam (3), displayed (3), others (3), problem (3), commanderror (3), original (3), context (3), undefined (3), added (3), documentation (3), another (3), tab (3), window (3), refresh (3), session (3), developers (3), changelog (3), customer (3), enterprise (3), grade (3), information (2), docs (2), community (2), status (2), footer (2), now (2), check (2), comments (2), lines (2), single (2), issues (2), development (2), milestone (2), projects (2), area (2), reviewers (2), requirements (2), left (2), bidirectional (2), than (2), about (2), november (2), compare (2), c0adaa6 (2), 4e640b6 (2), force (2), pushed (2), makes (2), determine (2), refusing (2), changed (2), tests (2), but (2), sure (2), just (2), test (2), updatecommandmodule (2), after (2), complaining (2), patches (2), did (2), trying (2), author (2), commented (2), updated (2), confirm (2), assertion (2), objects (2), types (2), non (2), red (2), instanceof (2), let (2), catch (2), current (2), appending (2), diagnostic (2), preserving (2), environments (2), crash (2), defensive (2), programming (2), formatting (2), reviewed (2), does (2), introduce (2), behavior (2), content (2), bug (2), guidelines (2), wants (2), into (2), head (2), name (2), clipboard (2), insights (2), actions (2), 196 (2), repository (2), signed (2), universe (2), training (2), integrations (2), stories (2), center (2), business (2), products (2), secret (2), perform, action, time, share, personal, manage, cookies, contact, privacy, terms, inc, right, back, later, queued, multi, pending, reviews, has, marked, must, existing, order, create, valid, applying, deleted, supported, per, viewing, subset, closed, invalid, were, made, participant, successfully, merging, close, these, none, yet, labels, assigned, assignees, whose, approvals, affect, reviewer, already, account, join, free, contains, text, interpreted, compiled, differently, appears, below, editor, reveals, title, 2e8d9a6, looked, adding, untested, private, method, wasn, easy, capture, output, without, adjusting, listr, patched, apply, cleanly, discovered, run, same, versions, said, scoped, patch, version, then, had, unused, enabled, make, discover, going, adjust, allow, complete, workspace, yaml, allowunusedpatches, 34681, edited, always, use, suggested, appropriate, still, surface, include, assume, unlikely, triggered, codebase, probably, consistently, uses, rather, primitive, alan, agius4, else, instance, network, failure, system, issue, unexpected, implementation, discards, throws, generic, ensures, valuable, lost, null, runtime, certain, scenarios, calling, directly, them, completely, mask, optional, chaining, nullish, coalescing, prevents, secondary, read, properties, reading, typeerror, 614, 603, src, commands, thread, improves, reporting, during, installation, command, displaying, occurs, feedback, recommends, prevent, potential, typeerrors, are, suggests, their, messages, view, label, robot, reaction, reacted, eyes, emoji, yes, breaking, surfacing, refactoring, functional, api, style, local, variables, feature, bugfix, kind, type, follows, our, https, com, blob, contributing, fulfills, following, checklist, files, checks, commits, items, requests, dismiss, alert, switched, accounts, out, appearance, settings, search, pricing, event, talks, workshops, next, partners, company, forum, events, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, evaluate, see, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, source, latest, improvements, across, place, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, codespaces, analysis, enforcement, automation, ship, coding, agent, tasks, automated, work, hosting, collaboration, platform, menu, skip,
Text of the page (random words):
fix angular cli propagate package manager errors when install fails by terencehonles pull request 34682 angular angular cli github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message angular angular cli repository navigation code issues 196 196 pull requests 20 20 actions security and quality 8 8 insights more items fix angular cli propagate package manager errors when install fails 34682 34682 open terencehonles wants to merge 1 commit into angular main angular angular cli main from terencehonles propagate package manager errors terencehonles angular cli propagate package manager errors copy head branch name to clipboard conversation commits 1 1 checks files changed open fix angular cli propagate package manager errors when install fails 34682 terencehonles wants to merge 1 commit into angular main angular angular cli main from terencehonles propagate package manager errors terencehonles angular cli propagate package manager errors copy head branch name to clipboard conversation terencehonles commented nov 11 2026 copy link copy markdown contributor this change makes it easier to determine why a package manager is refusing to install an update pr checklist please check to confirm your pr fulfills the following requirements the commit message follows our guidelines https github com angular angular cli blob main contributing md commit message guidelines tests for the changes have been added for bug fixes features docs have been added updated for bug fixes features pr type what kind of change does this pr introduce bugfix feature code style update formatting local variables refactoring no functional changes no api changes build related changes ci related changes documentation content changes other please describe what is the current behavior package manager install errors just show unable to install packages what is the new behavior package manager install errors now show the error the package manager is surfacing does this pr introduce a breaking change yes no other information sorry something went wrong uh oh there was an error while loading please reload this page 1 gemini code assist bot reacted with eyes emoji all reactions 1 reaction angular robot bot added the area angular cli label nov 11 2026 gemini code assist bot reviewed nov 11 2026 view reviewed changes gemini code assist bot left a comment copy link copy markdown there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment code review this pull request improves error reporting during package installation in the update command by formatting and displaying stdout and stderr when a packagemanagererror occurs the review feedback recommends defensive programming to prevent potential typeerrors if stdout or stderr are undefined and suggests preserving diagnostic context for other types of errors by appending their messages sorry something went wrong uh oh there was an error while loading please reload this page all reactions comment thread packages angular cli src commands update cli ts comment on lines 603 to 614 catch e throw new commanderror unable to install packages let message unable to install packages if e instanceof packagemanagererror const stdout e stdout trim const stderr e stderr trim message colors bold e message stdout n n colors bold stdout stdout stderr n n colors bold stderr colors red stderr throw new commanderror message gemini code assist bot nov 11 2026 copy link copy markdown there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment defensive programming if e stdout or e stderr is undefined or null at runtime e g in certain error scenarios or test environments calling trim directly on them will throw a typeerror e g cannot read properties of undefined reading trim this would crash the cli and completely mask the original package manager error using optional chaining and nullish coalescing prevents this secondary crash preserving non packagemanagererror context if e is not an instance of packagemanagererror e g a network failure file system issue or other unexpected error the current implementation discards the original error message and throws a generic unable to install packages message appending the original error s message using assertiserror e ensures that valuable diagnostic context is not lost catch e let message unable to install packages if e instanceof packagemanagererror const stdout e stdout trim const stderr e stderr trim message colors bold e message stdout n n colors bold stdout stdout stderr n n colors bold stderr colors red stderr else assertiserror e message e message throw new commanderror message sorry something went wrong uh oh there was an error while loading please reload this page all reactions terencehonles nov 11 2026 copy link copy markdown contributor author there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment updated to always propagate errors and use assertiserror as suggested alan agius4 can you confirm that assertiserror is appropriate the assertion error would still surface an error but would not include update to install packages i assume the assertion error is unlikely to be triggered because the codebase probably consistently uses error objects rather than primitive types non error objects sorry something went wrong uh oh there was an error while loading please reload this page all reactions terencehonles commented nov 11 2026 edited loading uh oh there was an error while loading please reload this page copy link copy markdown contributor author this change is related to my fix 34681 because after i patched angular cli for the change in the pr the package manager was complaining that the patches did not apply cleanly i only discovered this by trying to run pnpm install with the same versions ng update said it was trying to update to after i scoped the patch to only the angular cli version i was using the package manager was then complaining that i had unused patches i did not have allowunusedpatches enabled this change would make it easier to discover what was going on and adjust the pnpm workspace yaml to allow pnpm to complete the install i looked at adding tests for this but the updatecommandmodule is untested and i m not sure if it s ok to just test a private method and i wasn t sure if it would be easy to capture listr s output without adjusting the updatecommandmodule all reactions sorry something went wrong uh oh there was an error while loading please reload this page terencehonles force pushed the propagate package manager errors branch from 2e8d9a6 to 4e640b6 compare november 11 2026 09 26 terencehonles changed the title fix angular cli propagate package manager errors when install fails fix angular cli propagate package manager errors when install fails nov 11 2026 fix angular cli propagate package manager errors when install fails c0adaa6 this change makes it easier to determine why a package manager is refusing to install an update terencehonles force pushed the propagate package manager errors branch from 4e640b6 to c0adaa6 compare november 11 2026 09 35 this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters sign up for free to join this conversation on github already have an account sign in to comment reviewers 1 more reviewer gemini code assist bot gemini code assist bot left review comments reviewers whose approvals may not affect merge requirements uh oh there was an error while loading please reload this page assignees no one assigned labels area angular cli projects none yet milestone no milestone development successfully merging this pull request may close these issues uh oh there was an error while loading please reload this page 1 participant add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge suggestion cannot be applied right now please check back later footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
|