Meta tags:
description= CLI tool for Angular. Contribute to angular/angular-cli development by creating an account on GitHub.;
Headings (most frequently used words):
uh, oh, jasmine, angular, createspyobj, to, for, vitest, comment, navigation, thekhegay, pr, this, fix, schematics, cast, mockedobject, spyobj, variables, in, refactor, cli, what, is, the, behavior, code, footer, commented, 2026, left, choose, reason, hiding, 34602, menu, repository, 34602thekhegay, wants, merge, commits, intoangular, mainangular, mainfrom, typethekhegay, typecopy, head, branch, name, clipboard, conversation, checklist, type, current, new, does, introduce, breaking, change, other, information, review, oct, 30, gemini, assist, bot, alan, agius4, nov, 11, reviewers, assignees, labels, projects, milestone, development, participants,
Text of the page (most frequently used words):
jasmine (35), this (31), angular (29), the (21), createspyobj (20), for (19), and (18), #vitest (17), type (16), #comment (15), github (14), code (14), with (14), while (13), there (13), reload (13), cast (13), spyobj (13), please (12), was (12), schematics (12), mockedobject (12), applied (11), changes (11), error (11), from (10), loading (10), page (10), review (10), copy (10), thekhegay (10), refactor (10), 2026 (8), alan (8), all (8), that (7), suggestion (7), cannot (7), suggestions (7), resolved (7), agius4 (7), variables (7), cli (7), pull (6), one (6), bot (6), more (6), added (6), fix (6), reason (6), describe (6), main (6), you (5), not (5), security (5), request (5), requested (5), assigned (5), gemini (5), assist (5), left (5), sign (5), learn (5), sorry (5), went (5), when (5), quality (5), variable (5), features (5), can (4), merge (4), commit (4), only (4), patch (4), what (4), something (4), wrong (4), reactions (4), markdown (4), link (4), packages (4), transformers (4), spy (4), thread (4), choose (4), hiding (4), oct (4), other (4), literal (4), name (4), another (4), heroservice (4), build (4), fixes (4), 34602 (4), your (4), support (4), copilot (4), action (3), navigation (3), now (3), line (3), comments (3), reviews (3), been (3), outdated (3), existing (3), add (3), batch (3), may (3), next (3), awaiting (3), reviewer (3), already (3), have (3), conversation (3), hidden (3), characters (3), file (3), unicode (3), open (3), are (3), explicit (3), union (3), spec (3), into (3), types (3), reviewed (3), annotated (3), svc (3), migration (3), same (3), migrated (3), getheroes (3), documentation (3), message (3), commits (3), tab (3), window (3), refresh (3), session (3), developers (3), changelog (3), customer (3), enterprise (3), grade (3), information (2), docs (2), community (2), status (2), footer (2), change (2), single (2), were (2), issues (2), development (2), milestone (2), projects (2), targeted (2), release (2), target (2), area (2), still (2), least (2), labels (2), reviewers (2), bidirectional (2), compiled (2), about (2), each (2), 89e35f4 (2), contributor (2), commented (2), nov (2), instead (2), com (2), fixup (2), unwrapping (2), present (2), hide (2), low (2), duplicate (2), off (2), topic (2), abuse (2), spam (2), will (2), displayed (2), others (2), problem (2), view (2), refactoring (2), they (2), assertions (2), let (2), testing (2), guide (2), object (2), spied (2), fails (2), ts2322 (2), after (2), initializes (2), declaration (2), looked (2), nearest (2), enclosing (2), block (2), gets (2), its (2), own (2), before (2), todo (2), tests (2), new (2), two (2), blocks (2), tsc (2), behavior (2), heroservicespy (2), content (2), related (2), bug (2), guidelines (2), wants (2), head (2), branch (2), clipboard (2), insights (2), actions (2), 196 (2), repository (2), signed (2), universe (2), training (2), integrations (2), stories (2), center (2), business (2), products (2), secret (2), perform, time, share, personal, manage, cookies, contact, privacy, terms, inc, right, check, back, later, queued, multi, pending, has, marked, must, order, create, valid, applying, deleted, lines, supported, per, viewing, subset, closed, invalid, because, made, participants, successfully, merging, close, these, none, yet, assignees, whose, approvals, affect, requirements, account, join, free, show, contains, text, interpreted, differently, than, appears, below, editor, reveals, forgot, reply, pushed, three, fixed, arg, used, first, handled, parentheses, unwraped, call, case, undefined, author, november, address, use, argument, look, keep, adding, second, authored, agius, alanagius, google, thanks, working, few, inline, regarding, parent, assertion, handling, arguments, collaborator, befdb9c, enhances, schematic, casting, calls, initialize, ensures, proper, safety, compatibility, feedback, suggests, utilizing, utility, function, manually, parenthesized, expressions, handle, transparent, wrappers, like, non, null, robustly, getunwrappedparent, label, robot, became, methods, which, nothing, report, points, 991f480, jasmi, reaction, reacted, eyes, emoji, members, untyped, did, option, without, since, keeps, compiling, yes, does, introduce, breaking, cases, cover, assignment, initializer, fail, import, declared, above, passes, strict, reported, transformed, mock, procedure, assignable, returns, any, beforeeach, pattern, issue, number, current, functional, api, style, update, formatting, local, feature, bugfix, updated, follows, our, https, blob, contributing, checklist, files, changed, checks, items, requests, dismiss, alert, switched, accounts, out, appearance, settings, search, pricing, event, talks, workshops, partners, company, forum, events, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, why, evaluate, see, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, source, latest, improvements, across, place, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, environments, codespaces, analysis, enforcement, automation, ship, coding, agent, tasks, automated, work, hosting, collaboration, platform, menu, skip,
Text of the page (random words):
fix schematics angular cast createspyobj to mockedobject for jasmine spyobj variables in refactor jasmine vitest by thekhegay pull request 34602 angular angular cli github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message angular angular cli repository navigation code issues 196 196 pull requests 20 20 actions security and quality 8 8 insights more items fix schematics angular cast createspyobj to mockedobject for jasmine spyobj variables in refactor jasmine vitest 34602 34602 open thekhegay wants to merge 3 commits into angular main angular angular cli main from thekhegay jasmine vitest createspyobj type thekhegay angular cli jasmine vitest createspyobj type copy head branch name to clipboard conversation commits 3 3 checks files changed open fix schematics angular cast createspyobj to mockedobject for jasmine spyobj variables in refactor jasmine vitest 34602 thekhegay wants to merge 3 commits into angular main angular angular cli main from thekhegay jasmine vitest createspyobj type thekhegay angular cli jasmine vitest createspyobj type copy head branch name to clipboard conversation thekhegay commented oct 30 2026 copy link copy markdown contributor pr checklist the commit message follows our guidelines https github com angular angular cli blob main contributing md commit message guidelines tests for the changes have been added for bug fixes features docs have been added updated for bug fixes features pr type bugfix feature code style update formatting local variables refactoring no functional changes no api changes build related changes ci related changes documentation content changes other please describe what is the current behavior issue number n a pattern from angular testing guide let heroservicespy jasmine spyobj heroservice beforeeach heroservicespy jasmine createspyobj heroservice getheroes is migrated to mockedobject heroservice variable and object literal with only getheroes jasmine createspyobj returns any so it compiled before after migration tsc fails with error ts2322 type getheroes mock procedure is not assignable to type mockedobject heroservice file is reported as transformed and there is no todo what is the new behavior when createspyobj initializes or is assigned to variable annotated with jasmine spyobj t literal is cast as mockedobject t and type import is added declaration is looked up in nearest enclosing block so svc declared in two describe blocks gets its own type in each migrated spec from above passes tsc strict ts 6 0 vitest 5 0 new spec cases cover assignment initializer and two describe blocks with same name they fail on main does this pr introduce a breaking change yes no other information cast types members that were not spied as present same as jasmine spyobj t with untyped createspyobj did before migration other option is todo without cast i went with cast since it keeps migrated tests compiling sorry something went wrong uh oh there was an error while loading please reload this page 1 gemini code assist bot reacted with eyes emoji all reactions 1 reaction fix schematics angular cast createspyobj to mockedobject for jasmi 991f480 ne spyobj variables in refactor jasmine vitest let svc jasmine spyobj t svc jasmine createspyobj from angular testing guide became mockedobject t variable assigned an object literal with only spied methods which fails with ts2322 after migration and nothing in report points to it when createspyobj initializes or is assigned to variable annotated with jasmine spyobj t literal is now cast as mockedobject t declaration is looked up in nearest enclosing block so same name in another describe gets its own type angular robot bot added the area schematics angular label oct 30 2026 gemini code assist bot reviewed oct 30 2026 view reviewed changes gemini code assist bot left a comment copy link copy markdown there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment code review this pull request enhances the jasmine to vitest refactoring schematic by casting jasmine createspyobj calls to mockedobject t when they are assigned to or initialize a variable annotated with jasmine spyobj t this ensures proper type safety and compatibility with vitest the review feedback suggests utilizing the existing getunwrappedparent utility function instead of manually unwrapping parenthesized expressions to handle other transparent wrappers like non null assertions or type assertions more robustly sorry something went wrong uh oh there was an error while loading please reload this page all reactions comment thread packages schematics angular refactor jasmine vitest transformers jasmine spy ts resolved uh oh there was an error while loading please reload this page fixup fix schematics angular cast createspyobj to mockedobject fo befdb9c r jasmine spyobj variables in refactor jasmine vitest alan agius4 added action review the pr is still awaiting reviews from at least one requested reviewer target patch this pr is targeted for the next patch release labels oct 30 2026 alan agius4 requested changes nov 3 2026 view reviewed changes alan agius4 left a comment copy link copy markdown collaborator there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment thanks for working on this i left a few inline comments regarding parent unwrapping when a type assertion is already present handling explicit type arguments on createspyobj t and union types sorry something went wrong uh oh there was an error while loading please reload this page all reactions comment thread packages schematics angular refactor jasmine vitest transformers jasmine spy ts resolved uh oh there was an error while loading please reload this page comment thread packages schematics angular refactor jasmine vitest transformers jasmine spy ts resolved uh oh there was an error while loading please reload this page comment thread packages schematics angular refactor jasmine vitest transformers jasmine spy ts resolved uh oh there was an error while loading please reload this page fixup fix schematics angular cast createspyobj to mockedobject fo 89e35f4 r jasmine spyobj variables in refactor jasmine vitest address review use explicit type argument of createspyobj look into union types and keep an existing cast instead of adding a second one co authored by alan agius alanagius google com thekhegay requested a review from alan agius4 november 3 2026 11 37 thekhegay commented nov 11 2026 copy link copy markdown contributor author alan agius4 sorry forgot to reply when i pushed it all three are fixed in 89e35f4 explicit createspyobj t type arg is used first jasmine spyobj t undefined union is handled and only parentheses are unwraped now so call that is already cast is left as is spec for each case added all reactions sorry something went wrong uh oh there was an error while loading please reload this page this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters sign up for free to join this conversation on github already have an account sign in to comment reviewers alan agius4 awaiting requested review from alan agius4 1 more reviewer gemini code assist bot gemini code assist bot left review comments reviewers whose approvals may not affect merge requirements uh oh there was an error while loading please reload this page assignees no one assigned labels action review the pr is still awaiting reviews from at least one requested reviewer area schematics angular target patch this pr is targeted for the next patch release projects none yet milestone no milestone development successfully merging this pull request may close these issues uh oh there was an error while loading please reload this page 2 participants add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge suggestion cannot be applied right now please check back later footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
|