site address:
github.com/angular/angular-cli/pull/34739
site title:
fix(@schematics/angular): generate valid artifact names for any entry-point name by MeAkib · Pull Request #34739 · angular/angular-cli · GitHub
|
|
|
Our opinion (on Wednesday 18 November 2026 18:11:44 UTC):
- no comments
|
|
|
|
After content analysis of this website we propose the following hashtags:
|
|
|
|
Meta tags:
description= CLI tool for Angular. Contribute to angular/angular-cli development by creating an account on GitHub.;
Headings (most frequently used words):
uh, oh, name, fix, angular, for, entry, point, comment, navigation, meakib, schematics, generate, valid, artifact, names, any, to, cli, code, footer, commented, nov, 17, 2026, left, choose, reason, hiding, this, 34739, menu, repository, 34739meakib, wants, merge, commits, intoangular, mainangular, mainfrom, validationmeakib, validationcopy, head, branch, clipboard, conversation, review, gemini, assist, bot, alan, agius4, reviewers, assignees, labels, projects, milestone, development, participants,
Text of the page (most frequently used words):
the (55), entry (25), name (24), and (24), point (24), #angular (23), this (22), with (17), that (14), for (14), github (13), code (13), error (12), names (12), cannot (11), applied (11), valid (11), comment (11), meakib (11), fix (11), while (10), all (10), copy (10), reload (9), schematics (9), 2026 (8), there (8), was (8), segment (8), class (8), generate (8), suggestion (7), please (7), suggestions (7), invalid (7), review (7), lib (7), validation (7), you (6), pull (6), from (6), changes (6), loading (6), page (6), bot (6), something (6), final (6), schematic (6), nov (6), any (6), reason (6), fails (6), cli (6), security (5), request (5), gemini (5), assist (5), more (5), alan (5), agius4 (5), sign (5), learn (5), used (5), selector (5), svg (5), icons (5), artifact (5), report (5), quality (5), path (5), can (4), now (4), merge (4), these (4), characters (4), about (4), sorry (4), went (4), wrong (4), reactions (4), when (4), are (4), digit (4), markdown (4), link (4), choose (4), hiding (4), dots (4), source (4), files (4), component (4), main (4), 34739 (4), your (4), support (4), copilot (4), not (3), navigation (3), line (3), comments (3), resolved (3), outdated (3), supported (3), add (3), batch (3), commit (3), one (3), may (3), left (3), requested (3), conversation (3), hidden (3), unicode (3), open (3), shape (3), into (3), generates (3), foo (3), them (3), keep (3), reviewed (3), generated (3), provided (3), commits (3), another (3), tab (3), window (3), refresh (3), session (3), developers (3), changelog (3), customer (3), enterprise (3), grade (3), features (3), build (3), community (2), status (2), footer (2), been (2), single (2), only (2), were (2), issues (2), development (2), milestone (2), projects (2), area (2), reviewers (2), have (2), file (2), bidirectional (2), what (2), naming (2), start (2), letter (2), lib3d (2), led (2), word (2), feature3d (2), dashes (2), exports (2), latest (2), bug (2), lies (2), generation (2), artifactname (2), contributor (2), commented (2), changed (2), descriptive (2), hide (2), low (2), duplicate (2), off (2), topic (2), abuse (2), spam (2), will (2), displayed (2), describe (2), others (2), problem (2), view (2), containing (2), added (2), accepts (2), npm (2), export (2), subpath (2), but (2), also (2), way (2), deep (2), inside (2), user (2), never (2), raw (2), schema (2), dump (2), internal (2), options (2), validate (2), front (2), together (2), allowed (2), remain (2), classify (2), removes (2), deriving (2), testing (2), testingv2 (2), test (2), covers (2), case (2), working (2), wants (2), head (2), branch (2), clipboard (2), insights (2), actions (2), 196 (2), repository (2), signed (2), universe (2), training (2), integrations (2), stories (2), center (2), documentation (2), business (2), fixes (2), products (2), secret (2), perform, action, time, share, personal, information, manage, cookies, contact, docs, privacy, terms, inc, right, check, back, later, queued, multi, pending, reviews, has, marked, must, change, existing, order, create, applying, deleted, lines, per, viewing, subset, closed, because, made, participants, successfully, merging, close, none, yet, labels, assigned, assignees, whose, approvals, affect, requirements, reviewer, awaiting, already, account, join, free, show, contains, text, interpreted, compiled, differently, than, appears, below, editor, reveals, november, happy, adjust, fallback, prefer, different, alone, full, then, project, prefix, basis, merged, preceding, since, rejects, segments, words, stay, separate, still, today, foo2, feature, validatehtmlselector, replaced, svgicons, thanks, reworked, instead, rejecting, derives, usable, directory, original, author, title, c0d833e, fixup, wit, collaborator, introduces, ensures, identifier, starting, alphanumeric, underscores, prevent, downstream, failures, additionally, unit, tests, verify, both, handling, acceptance, look, solid, well, tested, label, robot, criptive, 3aad86e, des, reaction, reacted, eyes, emoji, checks, items, requests, message, dismiss, alert, switched, accounts, out, appearance, settings, search, pricing, event, talks, workshops, next, partners, company, forum, events, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, why, evaluate, see, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, improvements, across, place, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, environments, codespaces, analysis, enforcement, automation, ship, coding, agent, tasks, automated, work, hosting, collaboration, platform, menu, skip, content,
Text of the page (random words):
fix schematics angular generate valid artifact names for any entry point name by meakib pull request 34739 angular angular cli github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message angular angular cli repository navigation code issues 196 196 pull requests 20 20 actions security and quality 8 8 insights more items fix schematics angular generate valid artifact names for any entry point name 34739 34739 open meakib wants to merge 2 commits into angular main angular angular cli main from meakib fix entry point name validation meakib angular cli fix entry point name validation copy head branch name to clipboard conversation commits 2 2 checks files changed open fix schematics angular generate valid artifact names for any entry point name 34739 meakib wants to merge 2 commits into angular main angular angular cli main from meakib fix entry point name validation meakib angular cli fix entry point name validation copy head branch name to clipboard conversation meakib commented nov 17 2026 copy link copy markdown contributor the entry point schematic accepts any name that is a valid npm export subpath but the final path segment is also used to name the generated class selector and source files a segment that cannot be used that way fails deep inside the component schematic with an error about something the user never provided ng generate entry point 3d fails with selector lib 3d is invalid and ng generate entry point svg icons fails with a raw schema validation dump of the internal component options validate the final path segment up front and report the entry point name together with the allowed shape dots remain supported as classify removes them when deriving the class name testing v2 generates the class testingv2 a test now covers that case to keep it working sorry something went wrong uh oh there was an error while loading please reload this page 1 gemini code assist bot reacted with eyes emoji all reactions 1 reaction fix schematics angular report invalid entry point names with a des 3aad86e criptive error the entry point schematic accepts any name that is a valid npm export subpath but the final path segment is also used to name the generated class selector and source files a segment that cannot be used that way fails deep inside the component schematic with an error about something the user never provided ng generate entry point 3d fails with selector lib 3d is invalid and ng generate entry point svg icons fails with a raw schema validation dump of the internal component options validate the final path segment up front and report the entry point name together with the allowed shape dots remain supported as classify removes them when deriving the class name testing v2 generates the class testingv2 a test now covers that case to keep it working angular robot bot added the area schematics angular label nov 17 2026 gemini code assist bot reviewed nov 17 2026 view reviewed changes gemini code assist bot left a comment copy link copy markdown there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment code review this pull request introduces validation for the entry point name in the angular entry point schematic it ensures that the final path segment of the entry point name is a valid identifier starting with a letter and containing only alphanumeric characters dots dashes and underscores to prevent downstream failures when naming generated source files additionally unit tests have been added to verify both the error handling for invalid names and the acceptance of valid names containing dots no review comments were provided and the changes look solid and well tested sorry something went wrong uh oh there was an error while loading please reload this page all reactions alan agius4 requested changes nov 17 2026 view reviewed changes alan agius4 left a comment copy link copy markdown collaborator there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment all of these are valid entry point names the bug lies in the artifactname generation sorry something went wrong uh oh there was an error while loading please reload this page all reactions fixup fix schematics angular report invalid entry point names wit c0d833e h a descriptive error meakib changed the title fix schematics angular report invalid entry point names with a descriptive error fix schematics angular generate valid artifact names for any entry point name nov 17 2026 meakib commented nov 17 2026 copy link copy markdown contributor author all of these are valid entry point names the bug lies in the artifactname generation thanks reworked in the latest commit instead of rejecting these names the schematic now derives a usable artifact name from them while the exports entry and directory keep the original name and are replaced with dashes svg icons class svgicons selector lib svg icons exports svg icons a digit led word is merged into the preceding word since a class cannot start with a digit and validatehtmlselector rejects digit led segments lib foo 3d feature 3d feature3d lib feature3d all digit words stay separate so foo 2 still generates foo2 lib foo 2 as today when the final segment alone cannot start the name with a letter the full name and then the project prefix are used as the basis 3d lib3d lib lib3d happy to adjust the fallback naming if you d prefer a different shape all reactions sorry something went wrong uh oh there was an error while loading please reload this page meakib requested a review from alan agius4 november 17 2026 15 59 this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters sign up for free to join this conversation on github already have an account sign in to comment reviewers alan agius4 awaiting requested review from alan agius4 1 more reviewer gemini code assist bot gemini code assist bot left review comments reviewers whose approvals may not affect merge requirements uh oh there was an error while loading please reload this page assignees no one assigned labels area schematics angular projects none yet milestone no milestone development successfully merging this pull request may close these issues uh oh there was an error while loading please reload this page 2 participants add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge suggestion cannot be applied right now please check back later footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
|
|
Images from subpage: "github.com/team"
Verify
Images from subpage: "github.com/enterprise/startups"
Verify
Images from subpage: "github.com/solutions/industry/nonprofits"
Verify
Images from subpage: "github.com/solutions/industry/healthcare"
Verify
Images from subpage: "github.com/solutions/industry/financial-services"
Verify
|
Verified site has: 61 subpage(s). Do you want to verify them? Verify pages:
|
The site also has references to the 4 subdomain(s)
|
The site also has 5 references to external domain(s).
|
Pages verified in the last hours (randomly selected):
|
|
Top 50 hastags from of all verified websites.
| |
|
|
|
|
|
|
Load Info| page size | 286085 | | load time (s) | 0.837656 | | redirect count | 0 | | speed download | 72928 | | server IP | 140.82.121.3 |
|
|
|
|
|
|
|
|
* Image may be subject to copyright.
|
|