Meta tags:
description= CLI tool for Angular. Contribute to angular/angular-cli development by creating an account on GitHub.;
Headings (most frequently used words):
fix, angular, pwa, assets, uh, oh, projects, navigation, support, with, the, pre, v18, src, layout, to, cli, meakib, legacy, code, footer, comment, 34734, menu, repository, 34734meakib, wants, merge, commit, intoangular, mainangular, mainfrom, layoutmeakib, layoutcopy, head, branch, name, clipboard, conversation, review, commented, nov, 16, 2026, gemini, assist, bot, left, choose, reason, for, hiding, this, reviewers, assignees, labels, milestone, development, participant,
Text of the page (most frequently used words):
the (62), and (26), angular (21), this (18), layout (17), #assets (17), github (13), code (13), pwa (13), directory (12), applied (11), support (11), manifest (11), with (11), projects (10), legacy (10), while (9), for (8), icons (8), public (8), fix (8), meakib (8), that (7), not (7), suggestion (7), cannot (7), suggestions (7), was (7), reload (7), pre (7), v18 (7), src (7), pull (6), there (6), bot (6), comment (6), copy (6), link (6), written (6), cli (6), you (5), security (5), please (5), request (5), add (5), gemini (5), assist (5), review (5), sign (5), all (5), are (5), build (5), can (4), 2026 (4), merge (4), existing (4), commit (4), error (4), loading (4), page (4), more (4), file (4), learn (4), files (4), source (4), quality (4), exists (4), branch (4), never (4), injected (4), into (4), asset (4), entry (4), workspace (4), after (4), main (4), 34734 (4), your (4), copilot (4), navigation (3), now (3), line (3), comments (3), from (3), batch (3), only (3), one (3), changes (3), were (3), may (3), already (3), conversation (3), hidden (3), characters (3), unicode (3), open (3), schematic (3), root (3), reason (3), nov (3), added (3), another (3), tab (3), window (3), refresh (3), session (3), developers (3), changelog (3), customer (3), enterprise (3), grade (3), features (3), community (2), status (2), footer (2), resolved (2), outdated (2), single (2), issues (2), development (2), milestone (2), area (2), reviewers (2), left (2), have (2), bidirectional (2), what (2), about (2), reactions (2), sorry (2), something (2), went (2), wrong (2), choose (2), hiding (2), markdown (2), reviewed (2), decides (2), between (2), layouts (2), host (2), assetsdir (2), but (2), tree (2), matches (2), runs (2), get (2), their (2), does (2), serve (2), index (2), html (2), then (2), 404s (2), application (2), installable (2), reports (2), success (2), detect (2), through (2), its (2), entries (2), instead (2), restore (2), worked (2), before (2), introduced (2), where (2), configuration (2), point (2), referencing (2), them (2), additions (2), which (2), previously (2), happened (2), writeworkspace (2), persisted (2), using (2), unaffected (2), wants (2), head (2), name (2), clipboard (2), insights (2), actions (2), 196 (2), repository (2), signed (2), universe (2), training (2), integrations (2), stories (2), center (2), documentation (2), business (2), fixes (2), products (2), secret (2), perform, action, time, share, personal, information, manage, cookies, contact, docs, privacy, terms, inc, right, check, back, later, queued, multi, pending, reviews, has, been, marked, must, change, order, create, valid, applying, deleted, lines, supported, per, viewing, subset, closed, invalid, because, made, participant, successfully, merging, close, these, none, yet, labels, assigned, assignees, whose, approvals, affect, requirements, reviewer, account, join, free, show, contains, text, interpreted, compiled, differently, than, appears, below, editor, reveals, updates, project, alongside, newer, detects, probing, subdirectories, placing, also, adds, corresponding, unit, tests, verify, behavior, feedback, provide, hide, low, duplicate, off, topic, abuse, spam, will, displayed, describe, others, problem, view, label, robot, 1aaf30b, reaction, reacted, eyes, emoji, contributor, commented, changed, checks, commits, items, requests, message, dismiss, alert, switched, accounts, out, appearance, settings, search, pricing, event, talks, workshops, next, partners, company, forum, events, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, why, evaluate, see, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, latest, improvements, across, place, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, environments, codespaces, analysis, enforcement, automation, ship, coding, agent, tasks, automated, work, hosting, collaboration, platform, menu, skip, content,
Text of the page (random words):
fix angular pwa support projects with the pre v18 src assets layout by meakib pull request 34734 angular angular cli github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message angular angular cli repository navigation code issues 196 196 pull requests 20 20 actions security and quality 8 8 insights more items fix angular pwa support projects with the pre v18 src assets layout 34734 34734 open meakib wants to merge 1 commit into angular main angular angular cli main from meakib fix pwa legacy assets layout meakib angular cli fix pwa legacy assets layout copy head branch name to clipboard conversation commits 1 1 checks files changed open fix angular pwa support projects with the pre v18 src assets layout 34734 meakib wants to merge 1 commit into angular main angular angular cli main from meakib fix pwa legacy assets layout meakib angular cli fix pwa legacy assets layout copy head branch name to clipboard conversation meakib commented nov 16 2026 copy link copy markdown contributor ng add angular pwa decides between the public and legacy src assets layouts with host exists assetsdir but tree exists only matches files so the legacy branch never runs and pre v18 layout projects get the manifest and icons in a public directory their build does not serve the manifest link injected into index html then 404s and the application is not installable while the schematic reports success detect the directory through its entries instead and restore the layout that worked before the public directory support was introduced the manifest is written to the source root where the asset entry added to the workspace configuration and the injected manifest link already point and the icons are written to the existing assets directory with the manifest referencing them as assets icons the workspace file is now written after the asset entry additions which previously happened after writeworkspace and were never persisted projects using the public directory layout are unaffected sorry something went wrong uh oh there was an error while loading please reload this page 1 gemini code assist bot reacted with eyes emoji all reactions 1 reaction fix angular pwa support projects with the pre v18 src assets layout 1aaf30b ng add angular pwa decides between the public and legacy src assets layouts with host exists assetsdir but tree exists only matches files so the legacy branch never runs and pre v18 layout projects get the manifest and icons in a public directory their build does not serve the manifest link injected into index html then 404s and the application is not installable while the schematic reports success detect the directory through its entries instead and restore the layout that worked before the public directory support was introduced the manifest is written to the source root where the asset entry added to the workspace configuration and the injected manifest link already point and the icons are written to the existing assets directory with the manifest referencing them as assets icons the workspace file is now written after the asset entry additions which previously happened after writeworkspace and were never persisted projects using the public directory layout are unaffected angular robot bot added the area angular pwa label nov 16 2026 gemini code assist bot reviewed nov 16 2026 view reviewed changes gemini code assist bot left a comment copy link copy markdown there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment code review this pull request updates the pwa schematic to support the legacy src assets project layout pre v18 alongside the newer layout it detects the legacy layout by probing the assets directory for existing files or subdirectories placing the manifest at the source root and the icons in the assets icons directory it also adds corresponding unit tests to verify this behavior i have no feedback to provide as there are no review comments sorry something went wrong uh oh there was an error while loading please reload this page all reactions this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters sign up for free to join this conversation on github already have an account sign in to comment reviewers 1 more reviewer gemini code assist bot gemini code assist bot left review comments reviewers whose approvals may not affect merge requirements uh oh there was an error while loading please reload this page assignees no one assigned labels area angular pwa projects none yet milestone no milestone development successfully merging this pull request may close these issues uh oh there was an error while loading please reload this page 1 participant add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge suggestion cannot be applied right now please check back later footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
|