Meta tags:
description= CLI tool for Angular. Contribute to angular/angular-cli development by creating an account on GitHub.;
Headings (most frequently used words):
fix, angular, the, application, component, naoki, uh, oh, type, for, navigation, pr, schematics, set, explicit, root, to, cli, nagahara, what, is, behavior, this, code, footer, comment, 34685, menu, repository, 34685nagahara, wants, merge, commit, intoangular, mainangular, mainfrom, typenagahara, typecopy, head, branch, name, clipboard, conversation, checklist, current, new, does, introduce, breaking, change, other, information, review, commented, nov, 11, 2026, gemini, assist, bot, left, choose, reason, hiding, reviewers, assignees, labels, projects, milestone, development, participant,
Text of the page (most frequently used words):
the (47), #angular (26), component (25), type (21), application (21), and (21), this (19), for (16), github (14), code (14), that (11), applied (11), test (10), fix (10), changes (9), workspace (9), schematics (9), cannot (8), while (8), root (8), cli (8), nagahara (8), naoki (8), suggestion (7), suggestions (7), reload (7), with (7), app (7), please (6), pull (6), commit (6), was (6), bot (6), comment (6), copy (6), build (6), main (6), you (5), not (5), security (5), request (5), there (5), gemini (5), assist (5), sign (5), file (5), all (5), set (5), style (5), defaults (5), pass (5), explicit (5), features (5), can (4), 2026 (4), merge (4), from (4), add (4), error (4), loading (4), page (4), when (4), review (4), more (4), have (4), what (4), learn (4), name (4), new (4), behavior (4), quality (4), naming (4), e2e (4), fixes (4), 34685 (4), your (4), support (4), copilot (4), navigation (3), line (3), been (3), existing (3), batch (3), one (3), generate (3), may (3), left (3), conversation (3), hidden (3), characters (3), unicode (3), open (3), schematic (3), empty (3), 2016 (3), generation (3), reason (3), nov (3), added (3), 2025 (3), regression (3), both (3), still (3), uses (3), repository (3), tests (3), config (3), generates (3), branch (3), files (3), css (3), documentation (3), message (3), another (3), tab (3), window (3), refresh (3), session (3), developers (3), changelog (3), customer (3), enterprise (3), grade (3), information (2), docs (2), community (2), status (2), footer (2), check (2), comments (2), pending (2), resolved (2), outdated (2), change (2), single (2), stylesheet (2), configured (2), issues (2), development (2), milestone (2), projects (2), area (2), reviewers (2), bidirectional (2), about (2), reactions (2), sorry (2), something (2), went (2), wrong (2), guide (2), end (2), across (2), are (2), choose (2), describe (2), hiding (2), markdown (2), link (2), reviewed (2), templates (2), ordinary (2), builds (2), styles (2), verifies (2), 34684 (2), closes (2), suite (2), pnpm (2), bazel (2), sharding (2), default (2), fails (2), generated (2), ng2008 (2), other (2), sets (2), checks (2), follows (2), content (2), related (2), bug (2), guidelines (2), wants (2), into (2), head (2), clipboard (2), insights (2), actions (2), 196 (2), signed (2), universe (2), training (2), integrations (2), stories (2), center (2), business (2), products (2), secret (2), perform, action, time, share, personal, manage, cookies, contact, privacy, terms, inc, right, now, back, later, queued, multi, reviews, has, marked, must, order, create, valid, applying, deleted, lines, supported, only, per, viewing, subset, closed, invalid, because, were, made, participant, produces, missing, successfully, merging, close, these, none, yet, labels, assigned, assignees, whose, approvals, affect, requirements, reviewer, already, account, join, free, show, contains, text, interpreted, compiled, differently, than, appears, below, editor, reveals, updates, string, also, introduces, verify, different, guides, ensure, respected, feedback, provide, componentoptions, hide, low, duplicate, off, topic, abuse, spam, will, displayed, others, problem, view, label, robot, produce, filenames, differ, keep, intact, separate, c3f60f9, reaction, reacted, eyes, emoji, full, run, e2e_node24, test_filter, test_arg, esbuild, nocache_test_results, packages, commands, prettier, eslint, production, git, diff, unit, reports, 976, specs, failures, spec, after, before, during, validated, locally, against, d5035923f0e357b2526c98110125eee04b05192f, yes, does, introduce, breaking, applications, using, their, references, absence, incorrectly, named, separately, continues, approach, used, 34472, 34450, generating, match, html, issue, number, inherits, its, template, referencing, first, extra, current, refactoring, functional, api, update, formatting, local, variables, feature, bugfix, updated, our, https, com, blob, contributing, checklist, contributor, commented, changed, commits, items, requests, dismiss, alert, switched, accounts, out, appearance, settings, search, pricing, event, talks, workshops, next, partners, company, forum, events, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, why, evaluate, see, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, source, latest, improvements, place, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, environments, codespaces, analysis, enforcement, automation, ship, coding, agent, tasks, automated, work, hosting, collaboration, platform, menu, skip,
Text of the page (random words):
fix schematics angular set explicit type for the application root component by nagahara naoki pull request 34685 angular angular cli github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message angular angular cli repository navigation code issues 196 196 pull requests 20 20 actions security and quality 8 8 insights more items fix schematics angular set explicit type for the application root component 34685 34685 open nagahara naoki wants to merge 1 commit into angular main angular angular cli main from nagahara naoki fix application component type nagahara naoki angular cli fix application component type copy head branch name to clipboard conversation commits 1 1 checks files changed open fix schematics angular set explicit type for the application root component 34685 nagahara naoki wants to merge 1 commit into angular main angular angular cli main from nagahara naoki fix application component type nagahara naoki angular cli fix application component type copy head branch name to clipboard conversation nagahara naoki commented nov 11 2026 copy link copy markdown contributor pr checklist the commit message follows our guidelines https github com angular angular cli blob main contributing md commit message guidelines tests for the changes have been added for bug fixes features docs have been added updated for bug fixes features pr type bugfix feature code style update formatting local variables refactoring no functional changes no api changes build related changes ci related changes documentation content changes other please describe what is the current behavior when the workspace sets schematics angular component type component ng generate application file name style guide 2025 inherits that type for its root component it generates app component css while the application template generates app ts referencing app css the first build fails with ng2008 and extra app component files are left in the application issue number closes 34684 what is the new behavior pass an explicit empty type when generating the application root component with the 2025 naming style so the component files match the application templates app ts app html and app css the 2016 branch continues to pass type component ordinary component generation still uses the workspace default this follows the approach used in 34450 and 34472 the new e2e test sets the workspace component type generates and builds applications using both naming styles checks their stylesheet references and the absence of the incorrectly named root component and verifies that a separately generated component still uses the workspace type does this pr introduce a breaking change yes no other information validated locally against main at d5035923f0e357b2526c98110125eee04b05192f before the fix the new regression test fails during the generated application s build with ng2008 after the fix the regression test and the existing schematic defaults e2e test both pass the angular schematics unit suite reports 976 specs 0 failures and 1 existing pending spec prettier eslint on the production file and git diff check pass commands pnpm bazel test tests e2e_node24 config e2e config no sharding test_filter tests generate application application workspace type default schematic defaults ts test_arg esbuild nocache_test_results pnpm bazel test packages schematics angular test config no sharding the full cli repository test suite was not run sorry something went wrong uh oh there was an error while loading please reload this page 1 gemini code assist bot reacted with eyes emoji all reactions 1 reaction fix schematics angular set explicit type for the application root c3f60f9 component pass an empty type for the 2025 application root component so workspace component defaults cannot produce filenames that differ from the application templates keep the 2016 naming behavior and ordinary component defaults intact add an e2e regression test that builds both naming styles with a workspace type configured and verifies that separate component generation still uses that type closes angular 34684 angular robot bot added the area schematics angular label nov 11 2026 gemini code assist bot reviewed nov 11 2026 view reviewed changes gemini code assist bot left a comment copy link copy markdown there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment code review this pull request updates the angular application schematic to set componentoptions type to an empty string when the file name style guide is not 2016 it also introduces a new end to end test to verify application generation behavior across different style guides and ensure workspace defaults are respected i have no feedback to provide sorry something went wrong uh oh there was an error while loading please reload this page all reactions this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters sign up for free to join this conversation on github already have an account sign in to comment reviewers 1 more reviewer gemini code assist bot gemini code assist bot left review comments reviewers whose approvals may not affect merge requirements uh oh there was an error while loading please reload this page assignees no one assigned labels area schematics angular projects none yet milestone no milestone development successfully merging this pull request may close these issues ng generate application produces a missing stylesheet when a workspace component type is configured uh oh there was an error while loading please reload this page 1 participant add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge suggestion cannot be applied right now please check back later footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
|