Meta tags:
description= CLI tool for Angular. Contribute to angular/angular-cli development by creating an account on GitHub.;
Headings (most frequently used words):
uh, oh, fix, angular, oxc, source, map, comment, navigation, build, use, parser, fallback, when, stripping, comments, to, cli, clydin, code, footer, commented, nov, 2026, 34632, menu, repository, 34632clydin, wants, merge, commits, intoangular, mainangular, mainfrom, strippingclydin, strippingcopy, head, branch, name, clipboard, conversation, review, gemini, assist, bot, left, choose, reason, for, hiding, this, alan, agius4, reviewers, assignees, labels, projects, milestone, development, participants,
Text of the page (most frequently used words):
the (71), #angular (34), this (33), and (31), oxc (30), comment (28), parser (26), #comments (25), build (20), for (19), while (17), source (17), trailing (17), 2026 (16), code (16), loading (16), map (15), that (14), with (14), github (13), nov (13), from (12), alan (12), agius4 (12), when (12), applied (11), main (11), fix (11), stripping (11), clydin (11), reload (10), 34632 (10), fast (10), path (10), pull (9), line (9), was (9), emnapi (9), sourcemappingurl (9), literals (9), string (9), fallback (9), please (8), request (8), merge (8), changes (8), there (8), file (8), thread (8), copy (8), suggestion (7), cannot (7), suggestions (7), only (7), because (7), error (7), page (7), scanner (7), regex (7), literal (7), review (7), cli (7), vite (7), use (7), not (6), single (6), bot (6), characters (6), shim (6), side (6), wasi (6), loadoxcparser (6), block (6), character (6), strip (6), top (6), level (6), javascript (6), all (6), you (5), action (5), security (5), valid (5), commit (5), one (5), gemini (5), assist (5), sign (5), memory (5), reviewed (5), can (4), resolved (4), lines (4), closed (4), close (4), patch (4), more (4), free (4), contains (4), learn (4), pushed (4), helper (4), across (4), during (4), where (4), custom (4), state (4), machine (4), plugin (4), multiple (4), non (4), also (4), url (4), into (4), added (4), commits (4), quality (4), your (4), support (4), copilot (4), navigation (3), reviews (3), add (3), batch (3), may (3), these (3), next (3), reviewer (3), conversation (3), hidden (3), unicode (3), referenced (3), asi (3), replace (3), effect (3), imports (3), centralized (3), consumers (3), evaluates (3), its (3), bindings (3), synchronously (3), require (3), restores (3), module (3), _resolvefilename (3), finally (3), immediately (3), after (3), avoids (3), leaving (3), core (3), runtime (3), resolution (3), permanently (3), overridden (3), rolldown (3), resolve (3), their (3), own (3), versions (3), refactor (3), centralize (3), scoped (3), previously (3), removesourcemappingurl (3), relied (3), strings (3), did (3), track (3), regular (3), expression (3), quote (3), backticks (3), inside (3), such (3), inverted (3), boundaries (3), remainder (3), subsequent (3), contained (3), misidentified (3), truncated (3), failed (3), actual (3), end (3), chunk (3), extend (3), inputs (3), pass (3), raw (3), byte (3), buffers (3), directly (3), standard (3), chunks (3), slice (3), without (3), invoking (3), occurrences (3), lazily (3), load (3), read (3), parse (3), result (3), avoiding (3), ast (3), deserialization (3), delegating (3), full (3), ecmascript (3), lexical (3), handling (3), including (3), templates (3), escapes (3), keeps (3), startup (3), eager (3), native (3), wasm (3), removes (3), whitespace (3), consistently (3), removing (3), entirely (3), preserving (3), terminators (3), follow (3), harden (3), base64 (3), validation (3), template (3), closing (3), same (3), are (3), never (3), misclassified (3), 34590 (3), closes (3), sorry (3), something (3), went (3), wrong (3), reactions (3), repository (3), markdown (3), link (3), label (3), branch (3), view (3), reason (3), another (3), tab (3), window (3), refresh (3), session (3), developers (3), changelog (3), customer (3), enterprise (3), grade (3), features (3), community (2), status (2), footer (2), outdated (2), were (2), issues (2), development (2), milestone (2), projects (2), targeted (2), release (2), target (2), area (2), ready (2), caretaker (2), labels (2), reviewers (2), left (2), approved (2), bidirectional (2), what (2), about (2), 12578ec (2), ca32365 (2), merged (2), commented (2), november (2), 69e3051 (2), still (2), awaiting (2), least (2), requested (2), packages (2), src (2), utils (2), sourcemap (2), will (2), environments (2), choose (2), hiding (2), wants (2), head (2), name (2), clipboard (2), insights (2), actions (2), 196 (2), signed (2), universe (2), training (2), integrations (2), stories (2), center (2), documentation (2), business (2), fixes (2), products (2), secret (2), perform, time, share, personal, information, manage, cookies, contact, docs, privacy, terms, inc, right, now, check, back, later, queued, multi, pending, has, been, marked, must, change, existing, order, create, applying, deleted, supported, per, viewing, subset, invalid, made, participants, corrupts, containing, successfully, merging, none, yet, assigned, assignees, whose, approvals, affect, requirements, already, have, account, join, show, text, interpreted, compiled, differently, than, appears, below, open, editor, reveals, 8984b4a, 631ac8a, following, branches, collaborator, compare, a2e3e69, force, removed, urce, ce1b638, fixup, 575c988, refactors, removal, logic, replacing, maintaining, introduces, avoid, copying, utf, decoding, adds, extensive, unit, tests, cover, various, edge, cases, identifies, high, severity, issue, using, throw, esm, suggesting, instead, import, meta, referenceerror, createrequire, __filename, decodeutf8, hide, low, duplicate, off, topic, abuse, spam, displayed, describe, others, problem, robot, reaction, reacted, eyes, emoji, member, files, changed, checks, items, requests, message, dismiss, alert, switched, accounts, out, appearance, settings, search, pricing, event, talks, workshops, partners, company, forum, events, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, why, evaluate, see, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, latest, improvements, place, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, codespaces, analysis, enforcement, automation, ship, coding, agent, tasks, automated, work, hosting, collaboration, platform, menu, skip, content,
Text of the page (random words):
fix angular build use oxc parser fallback when stripping source map comments by clydin pull request 34632 angular angular cli github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message angular angular cli repository navigation code issues 196 196 pull requests 20 20 actions security and quality 8 8 insights more items fix angular build use oxc parser fallback when stripping source map comments 34632 34632 closed clydin wants to merge 3 commits into angular main angular angular cli main from clydin fix source map oxc comment stripping clydin angular cli fix source map oxc comment stripping copy head branch name to clipboard conversation commits 3 3 checks files changed closed fix angular build use oxc parser fallback when stripping source map comments 34632 clydin wants to merge 3 commits into angular main angular angular cli main from clydin fix source map oxc comment stripping clydin angular cli fix source map oxc comment stripping copy head branch name to clipboard conversation clydin commented nov 2 2026 copy link copy markdown member previously removesourcemappingurl relied on a custom character by character state machine to strip top level sourcemappingurl comments from javascript strings because that scanner did not track regular expression literals quote characters or backticks inside a regex literal such as inverted string boundaries for the remainder of the file when a subsequent string literal contained sourcemappingurl the scanner misidentified it as a top level comment and truncated valid javascript or failed to strip the actual trailing comment at the end of the chunk extend the single trailing comment fast path to string inputs and pass raw byte buffers directly from the vite memory plugin so standard chunks slice trailing source map comments without invoking a parser when a file contains multiple or non trailing sourcemappingurl occurrences lazily load oxc parser and read only the comments of the parse result avoiding js side ast deserialization while delegating full ecmascript lexical handling including regex literals templates and escapes to oxc this keeps main thread startup free of eager native or wasm parser loading the fallback removes whitespace consistently with the fast path removing comment only lines entirely while preserving line terminators for comments that follow code also harden trailing url and base64 validation so block comments or template literals closing on the same line are never misclassified by the fast path closes 34590 sorry something went wrong uh oh there was an error while loading please reload this page 1 gemini code assist bot reacted with eyes emoji all reactions 1 reaction angular robot bot added the area angular build label nov 2 2026 gemini code assist bot reviewed nov 2 2026 view reviewed changes gemini code assist bot left a comment copy link copy markdown there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment code review this pull request refactors the sourcemap comment removal logic by replacing a custom state machine parser with oxc parser for non trailing or multiple sourcemap comments while maintaining a fast path for single trailing comments it also introduces a decodeutf8 helper in the vite memory plugin to avoid copying memory during utf 8 decoding and adds extensive unit tests to cover various edge cases a review comment identifies a high severity issue where using __filename with createrequire will throw a referenceerror in esm environments suggesting the use of import meta url instead sorry something went wrong uh oh there was an error while loading please reload this page all reactions comment thread packages angular build src utils source map ts resolved uh oh there was an error while loading please reload this page alan agius4 reviewed nov 2 2026 view reviewed changes comment thread packages angular build src utils source map ts resolved uh oh there was an error while loading please reload this page alan agius4 added action review the pr is still awaiting reviews from at least one requested reviewer target patch this pr is targeted for the next patch release labels nov 2 2026 alan agius4 approved these changes nov 2 2026 view reviewed changes clydin added 2 commits november 2 2026 17 27 fix angular build use oxc parser fallback when stripping source ma 575c988 p comments previously removesourcemappingurl relied on a custom character by character state machine to strip top level sourcemappingurl comments from javascript strings because that scanner did not track regular expression literals quote characters or backticks inside a regex literal such as inverted string boundaries for the remainder of the file when a subsequent string literal contained sourcemappingurl the scanner misidentified it as a top level comment and truncated valid javascript or failed to strip the actual trailing comment at the end of the chunk extend the single trailing comment fast path to string inputs and pass raw byte buffers directly from the vite memory plugin so standard chunks slice trailing source map comments without invoking a parser when a file contains multiple or non trailing sourcemappingurl occurrences lazily load oxc parser and read only the comments of the parse result avoiding js side ast deserialization while delegating full ecmascript lexical handling including regex literals templates and escapes to oxc this keeps main thread startup free of eager native or wasm parser loading the fallback removes whitespace consistently with the fast path removing comment only lines entirely while preserving line terminators for comments that follow code also harden trailing url and base64 validation so block comments or template literals closing on the same line are never misclassified by the fast path closes angular 34590 fixup fix angular build use oxc parser fallback when stripping so ce1b638 urce map comments alan agius4 removed the action review the pr is still awaiting reviews from at least one requested reviewer label nov 3 2026 refactor angular build centralize oxc parser loading with scoped w 69e3051 asi shim replace side effect imports of oxc wasi shim with a centralized loadoxcparser helper across angular build consumers because oxc parser evaluates its wasi bindings synchronously during require oxc parser loadoxcparser restores module _resolvefilename in a finally block immediately after loading this avoids leaving emnapi core and emnapi runtime resolution permanently overridden on the main thread where rolldown and vite resolve their own emnapi versions clydin force pushed the fix source map oxc comment stripping branch from a2e3e69 to 69e3051 compare november 3 2026 13 33 clydin added the action merge the pr is ready for merge by the caretaker label nov 3 2026 alan agius4 commented nov 3 2026 copy link copy markdown collaborator this pr was merged into the repository the changes were merged into the following branches main 12578ec 22 2 x ca32365 all reactions sorry something went wrong uh oh there was an error while loading please reload this page alan agius4 pushed a commit that referenced this pull request nov 3 2026 fix angular build use oxc parser fallback when stripping source ma 631ac8a p comments 34632 previously removesourcemappingurl relied on a custom character by character state machine to strip top level sourcemappingurl comments from javascript strings because that scanner did not track regular expression literals quote characters or backticks inside a regex literal such as inverted string boundaries for the remainder of the file when a subsequent string literal contained sourcemappingurl the scanner misidentified it as a top level comment and truncated valid javascript or failed to strip the actual trailing comment at the end of the chunk extend the single trailing comment fast path to string inputs and pass raw byte buffers directly from the vite memory plugin so standard chunks slice trailing source map comments without invoking a parser when a file contains multiple or non trailing sourcemappingurl occurrences lazily load oxc parser and read only the comments of the parse result avoiding js side ast deserialization while delegating full ecmascript lexical handling including regex literals templates and escapes to oxc this keeps main thread startup free of eager native or wasm parser loading the fallback removes whitespace consistently with the fast path removing comment only lines entirely while preserving line terminators for comments that follow code also harden trailing url and base64 validation so block comments or template literals closing on the same line are never misclassified by the fast path closes 34590 pr close 34632 alan agius4 pushed a commit that referenced this pull request nov 3 2026 refactor angular build centralize oxc parser loading with scoped w ca32365 asi shim 34632 replace side effect imports of oxc wasi shim with a centralized loadoxcparser helper across angular build consumers because oxc parser evaluates its wasi bindings synchronously during require oxc parser loadoxcparser restores module _resolvefilename in a finally block immediately after loading this avoids leaving emnapi core and emnapi runtime resolution permanently overridden on the main thread where rolldown and vite resolve their own emnapi versions pr close 34632 alan agius4 closed this in 8984b4a nov 3 2026 alan agius4 pushed a commit to alan agius4 angular cli that referenced this pull request nov 3 2026 refactor angular build centralize oxc parser loading with scoped w 12578ec asi shim angular 34632 replace side effect imports of oxc wasi shim with a centralized loadoxcparser helper across angular build consumers because oxc parser evaluates its wasi bindings synchronously during require oxc parser loadoxcparser restores module _resolvefilename in a finally block immediately after loading this avoids leaving emnapi core and emnapi runtime resolution permanently overridden on the main thread where rolldown and vite resolve their own emnapi versions pr close angular 34632 this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters sign up for free to join this conversation on github already have an account sign in to comment reviewers alan agius4 alan agius4 approved these changes 1 more reviewer gemini code assist bot gemini code assist bot left review comments reviewers whose approvals may not affect merge requirements uh oh there was an error while loading please reload this page assignees no one assigned labels action merge the pr is ready for merge by the caretaker area angular build target patch this pr is targeted for the next patch release projects none yet milestone no milestone development successfully merging this pull request may close these issues angular build source map comment scanner corrupts valid js containing a regex literal uh oh there was an error while loading please reload this page 2 participants add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge suggestion cannot be applied right now please check back later footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
|