Meta tags:
description=Summary of Changes This pull request fixes #5374 Submitter Checklist: Unit Tests are updated to cover new or changed functionality User-facing strings use NSLocalizableString() Test Plan: This is a tricky to test feature: You may test by building the debug version of the application and seeing if no javascript errors are thrown on the injected scripts. Go to a few sites with known trackers and test that nothing is broken. (YouTube, Facebook, instagram, etc)3. Test 2: Switch languages to something that uses regional lists. (ex switch phone to the polish) Go to twitter and make sure the login works Screenshots: Reviewer Checklist: Issues include necessary QA labels: QA/(Yes No) - test for performance degradation bug / enhancement Necessary security reviews have taken place. Adequate unit test coverage exists to prevent regressions. Adequate test plan exists for QA to validate (if applicable). Issue and pull request is assigned to a milestone (should happen at merge time).;

Headings (most frequently used words):

fix, 5374, add, async, request, blocking, via, webkit, message, handlers, 5444, checklist, footer, conversation, summary, of, changes, submitter, test, plan, screenshots, reviewer, cuba, commented, jun, 2022, edited, navigation,

Text of the page (most frequently used words):
resolved (51), 2022 (48), the (29), request (28), #changes (27), jun (27), hide (26), show (26), client (25), this (21), 5374 (21), #blocking (19), view (19), jul (18), from (17), github (16), cuba (16), outdated (15), frontend (15), pes10k (14), usercontent (14), userscripts (14), requestblocking (14), reviewed (13), pull (12), iccub (12), branch (12), compare (12), force (11), pushed (11), swift (11), applied (10), webfilters (10), and (10), sign (9), code (8), for (8), test (8), you (7), that (7), suggestions (7), fix (7), review (7), all (7), cannot (6), suggestion (6), add (6), merged (6), jump (6), brave (6), security (5), issues (5), thypon (5), message (5), requested (5), open (5), can (4), about (4), these (4), development (4), brandon (4), account (4), async (4), via (4), webkit (4), handlers (4), commits (4), plan (4), 5444 (4), window (3), your (3), with (3), while (3), line (3), batch (3), commit (3), may (3), milestone (3), projects (3), have (3), conversation (3), into (3), added (3), approved (3), requestblockingcontenthelper (3), times (3), most (3), recently (3), yes (3), issue (3), characters (3), unicode (3), actions (3), ios (3), repository (3), signed (2), another (2), tab (2), refresh (2), session (2), reload (2), time (2), blog (2), pricing (2), contact (2), privacy (2), terms (2), footer (2), navigation (2), merge (2), reviews (2), marked (2), deleted (2), single (2), one (2), none (2), yet (2), labels (2), assigned (2), already (2), free (2), checks (2), details (2), 8236c50 (2), 96f1939 (2), c0ed280 (2), shieldstats (2), adblock (2), contentblocker (2), adblockresourcedownloader (2), 96f1711 (2), user (2), scripts (2), mentioned (2), label (2), 209e84a (2), 19da8a6 (2), aba546c (2), adblockrustengine (2), something (2), adequate (2), exists (2), unit (2), necessary (2), checklist (2), switch (2), are (2), new (2), changed (2), hidden (2), file (2), bidirectional (2), more (2), community (2), project (2), insights (2), requests (2), source (2), manage (2), packages (2), web (2), oct (2), out, perform, action, training, api, docs, status, inc, queued, multi, comments, pending, has, been, must, change, existing, order, create, valid, applying, lines, not, supported, only, per, viewing, subset, closed, invalid, because, were, made, participants, block, bad, fetch, messages, using, rust, engine, successfully, merging, close, assignees, reviewers, comment, join, passed, 07d5d6b, 9d79575, 0806e7e, adblockstats, 69b0415, fifodict, browser, userscripthelper, 7b2c501, match, safari, anonymizing, method, values, 5523, removed, tasks, ref, move, stats, tracking, 5629, b994601, b09bb98, 3fb5887, adblockertype, cosmeticfiltersresourcedownloader, ready, team, 0530f99, 6231dda, 0a0cc4e, reactions, sorry, went, wrong, should, happen, validate, applicable, coverage, prevent, regressions, taken, place, include, enhancement, bug, performance, degradation, reviewer, screenshots, twitter, make, sure, login, works, languages, uses, regional, lists, phone, polish, few, sites, known, trackers, nothing, broken, youtube, facebook, instagram, etc, building, debug, version, application, seeing, javascript, errors, thrown, injected, tricky, feature, facing, strings, use, nslocalizablestring, updated, cover, functionality, tests, submitter, fixes, summary, commented, edited, contributor, copy, link, contains, text, interpreted, compiled, differently, than, what, appears, below, editor, reveals, learn, files, bottom, clicking, agree, our, occasionally, send, related, emails, statement, service, password, email, address, pick, username, its, maintainers, question, 461, star, fork, 362, notifications, public, organization, suggested, results, collections, trending, topics, repositories, articles, readme, fund, developers, sponsors, resources, customer, stories, case, studies, devsecops, devops, automation, solution, teams, enterprise, solutions, skills, documentation, features, explore, collaborate, outside, discussions, track, work, write, better, copilot, instant, dev, environments, codespaces, find, vulnerabilities, host, automate, any, workflow, product, toggle, skip, content, wayback, machine, http, archive, org, 20221021233122, https, com, timestamps, capture, fail, success, 2023, 2021, nov, sep, captures,

Text of the page (random words):
fix 5374 add async request blocking via webkit message handlers by cuba pull request 5444 brave brave ios github 2 captures 24 jun 2022 21 oct 2022 sep oct nov 21 2021 2022 2023 success fail about this capture timestamps the wayback machine http web archive org web 20221021233122 https github com brave brave ios pull 5444 skip to content toggle navigation sign up product actions automate any workflow packages host and manage packages security find and fix vulnerabilities codespaces instant dev environments copilot write better code with ai code review manage code changes issues plan and track work discussions collaborate outside of code explore all features documentation github skills blog solutions by plan enterprise teams compare all by solution ci cd automation devops devsecops case studies customer stories resources open source github sponsors fund open source developers the readme project github community articles repositories topics trending collections pricing in this repository all github jump to no suggested jump to results in this repository all github jump to in this organization all github jump to in this repository all github jump to sign in sign up message brave brave ios public notifications fork 362 star 1 3k code issues 461 pull requests 19 actions projects 2 security insights more code issues pull requests actions projects security insights new issue have a question about this project sign up for a free github account to open an issue and contact its maintainers and the community pick a username email address password sign up for github by clicking sign up for github you agree to our terms of service and privacy statement we ll occasionally send you account related emails already on github sign in to your account jump to bottom fix 5374 add async request blocking via webkit message handlers 5444 merged iccub merged 2 commits into development from js 5374 request blocking jul 8 2022 merged fix 5374 add async request blocking via webkit message handlers 5444 iccub merged 2 commits into development from js 5374 request blocking jul 8 2022 conversation 28 commits 2 checks 7 files changed conversation this file contains bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters copy link contributor cuba commented jun 3 2022 edited summary of changes this pull request fixes 5374 submitter checklist unit tests are updated to cover new or changed functionality user facing strings use nslocalizablestring test plan this is a tricky to test feature you may test by building the debug version of the application and seeing if no javascript errors are thrown on the injected scripts go to a few sites with known trackers and test that nothing is broken youtube facebook instagram etc 3 test 2 switch languages to something that uses regional lists ex switch phone to the polish go to twitter and make sure the login works screenshots reviewer checklist issues include necessary qa labels qa yes no test for performance degradation bug enhancement necessary security reviews have taken place adequate unit test coverage exists to prevent regressions adequate test plan exists for qa to validate if applicable issue and pull request is assigned to a milestone should happen at merge time sorry something went wrong all reactions pes10k reviewed jun 3 2022 view changes client webfilters adblockrustengine swift show resolved hide resolved pes10k reviewed jun 3 2022 view changes client webfilters adblockrustengine swift show resolved hide resolved pes10k reviewed jun 3 2022 view changes client frontend usercontent userscripts requestblocking js outdated show resolved hide resolved pes10k reviewed jun 3 2022 view changes client frontend usercontent userscripts requestblocking js outdated show resolved hide resolved pes10k reviewed jun 3 2022 view changes client frontend usercontent userscripts requestblocking js outdated show resolved hide resolved pes10k reviewed jun 3 2022 view changes client frontend usercontent userscripts requestblocking js outdated show resolved hide resolved pes10k reviewed jun 3 2022 view changes client frontend usercontent userscripts requestblocking js outdated show resolved hide resolved cuba force pushed the js 5374 request blocking branch from 0a0cc4e to 6231dda compare jun 3 2022 pes10k reviewed jun 3 2022 view changes client frontend usercontent userscripts requestblocking js outdated show resolved hide resolved pes10k reviewed jun 3 2022 view changes client frontend usercontent userscripts requestblocking js show resolved hide resolved cuba force pushed the js 5374 request blocking branch 3 times most recently from 0530f99 to aba546c compare jun 6 2022 cuba requested a review from a team jun 6 2022 cuba marked this pull request as ready for review jun 6 2022 cuba force pushed the js 5374 request blocking branch from aba546c to 19da8a6 compare jun 6 2022 pes10k reviewed jun 6 2022 view changes client frontend usercontent userscripts requestblocking js outdated show resolved hide resolved pes10k reviewed jun 6 2022 view changes client frontend usercontent userscripts requestblocking js outdated show resolved hide resolved pes10k reviewed jun 6 2022 view changes client frontend usercontent userscripts requestblocking js outdated show resolved hide resolved cuba force pushed the js 5374 request blocking branch from 19da8a6 to 209e84a compare jun 7 2022 iccub requested a review from pes10k jun 8 2022 thypon reviewed jun 9 2022 view changes client webfilters cosmeticfiltersresourcedownloader swift show resolved hide resolved client webfilters adblockertype swift show resolved hide resolved client webfilters adblockresourcedownloader swift show resolved hide resolved client frontend usercontent userscripts requestblocking js show resolved hide resolved client frontend usercontent userscripts requestblocking js show resolved hide resolved client frontend usercontent userscripts requestblocking js show resolved hide resolved thypon added the qa yes label jun 13 2022 thypon approved these changes jun 13 2022 view changes cuba force pushed the js 5374 request blocking branch from 209e84a to 3fb5887 compare jun 14 2022 cuba force pushed the js 5374 request blocking branch 2 times most recently from b09bb98 to b994601 compare jun 29 2022 cuba mentioned this pull request jun 29 2022 ref 5374 move request blocking stats tracking to requestblockingcontenthelper 5629 merged 7 tasks iccub requested a review from brandon t jul 7 2022 iccub removed the qa yes label jul 7 2022 thypon mentioned this pull request jul 7 2022 match safari in anonymizing js method values 5523 open cuba force pushed the js 5374 request blocking branch 2 times most recently from 7b2c501 to 96f1711 compare jul 7 2022 iccub requested changes jul 8 2022 view changes client frontend browser user scripts userscripthelper swift outdated show resolved hide resolved client webfilters shieldstats adblock fifodict swift show resolved hide resolved cuba force pushed the js 5374 request blocking branch from 96f1711 to 69b0415 compare jul 8 2022 brandon t requested changes jul 8 2022 view changes client frontend usercontent userscripts requestblocking js show resolved hide resolved client webfilters adblockresourcedownloader swift outdated show resolved hide resolved client webfilters contentblocker requestblockingcontenthelper swift outdated show resolved hide resolved client webfilters contentblocker requestblockingcontenthelper swift outdated show resolved hide resolved client webfilters shieldstats adblock adblockstats swift outdated show resolved hide resolved cuba force pushed the js 5374 request blocking branch from 0806e7e to c0ed280 compare jul 8 2022 iccub approved these changes jul 8 2022 view changes brandon t approved these changes jul 8 2022 view changes cuba force pushed the js 5374 request blocking branch from c0ed280 to 96f1939 compare jul 8 2022 iccub added this to the 1 41 milestone jul 8 2022 cuba added 2 commits jul 8 2022 fix 5374 add async request blocking via webkit message handlers 9d79575 fix 5374 fix for review 8236c50 iccub force pushed the js 5374 request blocking branch from 96f1939 to 8236c50 compare jul 8 2022 hide details view details iccub merged commit 07d5d6b into development jul 8 2022 8 checks passed iccub deleted the js 5374 request blocking branch jul 8 2022 sign up for free to join this conversation on github already have an account sign in to comment reviewers thypon brandon t iccub pes10k assignees no one assigned labels none yet projects none yet milestone 1 41 development successfully merging this pull request may close these issues block bad window fetch messages using the rust engine 5 participants add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge footer 2022 github inc footer navigation terms privacy security status docs contact github pricing api training blog about you can t perform that action at this time you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session

Images from subpage: "web.archive.org/web/20221021233122/https://github.com/brave/... " Verify

Images from subpage: "web.archive.org/web/20221021233122/https://github.com/brave/... " Verify

Images from subpage: "web.archive.org/web/20221021233122/https://github.com/brave/... " Verify

Images from subpage: "web.archive.org/web/20221021233122/https://github.com/brave/... " Verify

Images from subpage: "web.archive.org/web/20221021233122/https://github.com/brave/... " Verify