Meta tags:
description= This decision will result into a nightmare: • The library no longer checks that the local part is at most 64 characters because a more careful reading of RFC 5321 indicates the limit is optional and such email addresses have been found i...;
Headings (most frequently used words):
commented, on, sep, 2025, asrenzo, navigation, joshdata, metadata, footer, version, breaks, ton, of, pydantic, models, and, rules, 160, menu, repository, description, activity, issue, actions, canardofr, assignees, labels, projects, milestone, relationships, development,
Text of the page (most frequently used words):
the (34), and (26), this (17), for (17), sep (17), 2025 (17), you (14), github (14), with (13), more (13), actions (12), that (11), #version (10), #asrenzo (9), may (8), commented (8), joshdata (8), change (8), true (8), your (8), email (8), not (7), have (7), than (7), strict (7), issue (6), all (6), other (6), must (6), pydantic (6), local (6), part (6), length (6), objects (6), these (6), security (5), copilot (5), sign (5), about (5), will (5), when (5), validator (5), should (5), maximum (5), code (5), projects (4), backward (4), rules (4), cannot (4), breaking (4), false (4), possible (4), feature (4), mail (4), parameter (4), bounce (4), customer (4), domain (4), optional (4), octets (4), sizes (4), see (4), breaks (4), support (4), can (3), navigation (3), open (3), labels (3), one (3), reacted (3), react (3), now (3), make (3), compatible (3), fixes (3), add (3), what (3), there (3), forbidden (3), way (3), but (3), owner (3), rely (3), fact (3), default (3), which (3), such (3), been (3), because (3), are (3), canardofr (3), total (3), user (3), name (3), larger (3), rfc (3), new (3), copy (3), link (3), 160 (3), ton (3), models (3), quality (3), another (3), tab (3), window (3), refresh (3), session (3), reload (3), developers (3), changelog (3), enterprise (3), grade (3), features (3), build (3), time (2), community (2), status (2), footer (2), app (2), pull (2), requests (2), development (2), milestone (2), metadata (2), already (2), regards (2), minor (2), incompatible (2), changes (2), using (2), semver (2), guess (2), ignore (2), want (2), decision (2), then (2), update (2), from (2), introducing (2), matter (2), choice (2), value (2), everyone (2), each (2), every (2), service (2), apps (2), uses (2), whereas (2), still (2), emails (2), into (2), system (2), break (2), lot (2), things (2), library (2), several (2), makes (2), check (2), message (2), sending (2), caracters (2), out (2), also (2), before (2), prepared (2), server (2), reject (2), them (2), they (2), handled (2), compatibility (2), nightmare (2), avoided (2), clients (2), attempt (2), transmit (2), any (2), hint (2), single (2), would (2), being (2), use (2), 255 (2), characters (2), specifies (2), lengths (2), character (2), implementation (2), however (2), internet (2), addresses (2), limits (2), 5321 (2), size (2), articles (2), found (2), overall (2), 254 (2), limit (2), place (2), insights (2), repository (2), python (2), signed (2), universe (2), training (2), integrations (2), stories (2), center (2), documentation (2), learn (2), business (2), products (2), secret (2), perform, action, share, personal, information, manage, cookies, contact, docs, privacy, terms, 2026, inc, branches, none, yet, relationships, assigned, assignees, comment, account, join, conversation, free, robert, tasarz, won, argue, anymore, freeze, look, something, else, patch, bug, functionality, manner, major, api, here, small, abstract, read, too, rude, notation, implies, conforming, world, wilde, accepted, know, website, https, org, point, view, poetry, package, managers, standard, stay, prior, versions, don, roll, back, problem, everything, fine, updates, rolled, independently, requires, same, barely, imagine, complex, architecture, first, level, emailing, running, allowed, front, send, unacceptable, deep, benefit, merging, ramona, important, worry, convenience, sorry, inconvenience, having, calls, best, alain, model, adresses, software, systems, parts, those, needing, bypass, ability, pass, set, adding, paramater, made, around, basically, exceed, usual, return, path, written, was, original_mail, filtered, comply, based, validation, does, fire, thus, encounter, problems, our, mailing, com, following, statement, even, relevant, making, beaking, lots, shall, dear, josh, author, says, note, updating, cause, pain, only, reported, 158, reversing, logic, offer, both, possibilities, without, anything, aka, moreover, forcing, existing, implementations, localpart, less, example, field, last, edited, activity, fabien, ehrlich, jasmine, please, advice, better, lazy, compat, defaults, number, extensions, smtp, involve, occupy, octet, section, therefore, where, absolute, rather, counts, intended, required, minimum, able, receive, least, some, constructs, encoded, 400, often, require, extent, techniques, impose, used, 2156, refering, reads, minimums, after, limited, result, longer, checks, most, careful, reading, indicates, wild, restored, address, body, opened, description, items, wiki, issues, dismiss, alert, switched, accounts, appearance, settings, search, pricing, event, talks, workshops, next, partners, company, forum, events, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, why, evaluate, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, source, latest, improvements, across, developer, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, environments, codespaces, analysis, enforcement, automation, ship, coding, agent, tasks, automated, work, hosting, review, collaboration, platform, menu, skip, content,
Text of the page (random words):
version 2 3 breaks a ton of pydantic models and rules issue 160 joshdata python email validator github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message joshdata python email validator repository navigation code issues 12 12 pull requests 5 5 actions projects wiki security and quality insights more items version 2 3 breaks a ton of pydantic models and rules 160 new issue copy link new issue copy link open open version 2 3 breaks a ton of pydantic models and rules 160 copy link description canardofr opened on sep 2 2025 issue body actions this decision will result into a nightmare the library no longer checks that the local part is at most 64 characters because a more careful reading of rfc 5321 indicates the limit is optional and such email addresses have been found in the wild however the check can be restored using a new strict true parameter and the overall 254 character email address length limit is still in place all the articles i found on the internet specifies 64 before and 255 after with an overall size limited to 254 refering to rfc 5321 it reads 4 5 3 1 size limits and minimums there are several objects that have required minimum maximum sizes every implementation must be able to receive objects of at least these sizes objects larger than these sizes should be avoided when possible however some internet mail constructs such as encoded x 400 addresses rfc 2156 35 will often require larger objects clients may attempt to transmit these but must be prepared for a server to reject them if they cannot be handled by it to the maximum extent possible implementation techniques that impose no limits on the length of these objects should be used extensions to smtp may involve the use of characters that occupy more than a single octet each this section therefore specifies lengths in octets where absolute lengths rather than character counts are intended 4 5 3 1 1 local part the maximum total length of a user name or other local part is 64 octets 4 5 3 1 2 domain the maximum total length of a domain name or number is 255 octets i do not see any hint about optional also as a backward compatibility it would have been better to make the strict parameter a lazy or compat parameter which defaults to true and not false please advice react with 2 reacted by fabien ehrlich and jasmine activity asrenzo commented on sep 2 2025 asrenzo on sep 2 2025 last edited by asrenzo more actions hi moreover forcing to use strict true breaks other existing implementations which rely on localpart being less than 64 for example pydantic email field i guess reversing the logic would offer both possibilities without breaking anything aka strict true being the default value updating this way will cause a lot of pain for everyone whereas issue is only reported by a single user see 158 joshdata commented on sep 2 2025 joshdata on sep 2 2025 owner more actions i do not see any hint about optional it s this objects larger than these sizes should note not must be avoided when possible clients may attempt to transmit these asrenzo commented on sep 2 2025 asrenzo on sep 2 2025 more actions 4 5 3 1 1 says the maximum total length of a user name or other local part is 64 octets canardofr commented on sep 3 2025 canardofr on sep 3 2025 author more actions dear josh as a matter of fact there are lots of shall should and must making a breaking change because it is a beaking change with no backward compatibility is a nightmare the fact that it s not optional also makes the following statement even more relevant than before must be prepared for a server to reject them if they cannot be handled by it so basically this change may break all message sending with a bounce feature because the local part may now exceed 64 caracters a usual return path mail for bounce feature is written bounce this was the original_mail of my customer domain sending domain com we filtered out the bounce mail to comply with 64 caracters based on pydantic email validator validation feature now it does not fire and thus we encounter problems in our mailing system this change should have been made the other way around by adding a strict paramater set this parameter by default to true for those needing to bypass the local part length check the ability to pass strict false in the pydantic library several model for mail adresses rely on email validator as such this change makes software systems parts incompatible if one uses version 2 3 0 and the other 2 2 0 best regards alain r joshdata commented on sep 3 2025 joshdata on sep 3 2025 owner more actions i m sorry for the inconvenience of having to add strict true to your calls i have more important things to worry about than convenience react with 1 reacted by ramona t asrenzo commented on sep 3 2025 asrenzo on sep 3 2025 more actions hi what is the benefit of merging a feature that may break a lot of things imagine a complex architecture in which a first level of apps uses email validator 2 3 whereas the emailing service is still running with version 2 2 then allowed emails in front apps will send unacceptable emails deep into the system your choice of introducing a breaking change requires each and every service or app to update at the same time this is barely possible if you change your default value from false to true everything is fine for everyone and updates may be rolled independently if you don t want to roll back or change false to true that s your choice i have no problem with it but if you want to stay with this decision then you cannot ignore that a minor version update must be compatible with prior versions and is forbidden from introducing breaking changes this is a matter of fact uv poetry and other package managers rely on this standard you cannot ignore it that s my point of view joshdata commented on sep 3 2025 joshdata on sep 3 2025 owner more actions forbidden ha ok asrenzo commented on sep 3 2025 asrenzo on sep 3 2025 more actions forbidden may be way too rude but using semver notation implies conforming to world wilde accepted rules i guess you already know this website https semver org here a small abstract of what you can read there major version when you make incompatible api changes minor version when you add functionality in a backward compatible manner patch version when you make backward compatible bug fixes that s all i won t argue anymore about this i will freeze version for now and look for something else regards react with 1 reacted by robert tasarz sign up for free to join this conversation on github already have an account sign in to comment metadata metadata assignees no one assigned labels no labels no labels projects no projects milestone no milestone relationships none yet development no branches or pull requests issue actions open in github copilot app footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
|