Meta tags:
description= CLI tool for Angular. Contribute to angular/angular-cli development by creating an account on GitHub.;
Headings (most frequently used words):
uh, oh, agius4, fix, angular, for, app, shell, component, commented, oct, 2026, alan, comment, navigation, meakib, this, 27, schematics, set, explicit, type, the, cli, code, footer, loading, left, choose, reason, hiding, 34450, menu, repository, 34450alan, merged, commits, intoangular, mainangular, mainfrom, typemeakib, typecopy, head, branch, name, to, clipboard, conversation, review, 20, edited, by, there, was, an, error, while, please, reload, page, gemini, assist, bot, reviewers, assignees, labels, projects, milestone, development, participants,
Text of the page (most frequently used words):
the (62), this (34), component (31), #angular (30), app (29), shell (29), 2026 (27), type (27), for (22), alan (21), agius4 (21), was (20), from (19), and (19), #meakib (17), oct (17), fix (16), while (15), there (15), reload (15), schematics (14), comment (14), copy (14), github (13), please (13), code (13), changes (13), loading (13), error (12), page (12), action (11), applied (11), merge (10), review (10), set (10), all (9), comments (8), october (8), added (8), cleanup (8), that (7), suggestion (7), cannot (7), suggestions (7), reviews (7), explicit (7), branch (7), merged (7), reviewed (7), pull (6), labels (6), bot (6), sorry (6), something (6), went (6), wrong (6), reactions (6), main (6), markdown (6), link (6), view (6), reason (6), cli (6), you (5), security (5), request (5), resolved (5), commit (5), one (5), generate (5), gemini (5), assist (5), left (5), more (5), sign (5), learn (5), workspace (5), into (5), with (5), requested (5), import (5), quality (5), can (4), these (4), patch (4), ready (4), caretaker (4), commented (4), removed (4), need (4), either (4), due (4), needing (4), rebase (4), response (4), compare (4), force (4), pushed (4), commits (4), choose (4), hiding (4), 34450 (4), your (4), support (4), copilot (4), not (3), navigation (3), line (3), outdated (3), add (3), batch (3), may (3), next (3), reviewers (3), thekhegay (3), approved (3), conversation (3), hidden (3), characters (3), file (3), unicode (3), open (3), repository (3), collaborator (3), hide (3), reaction (3), reacted (3), emoji (3), appshell (3), option (3), generated (3), empty (3), schematic (3), packages (3), another (3), tab (3), window (3), refresh (3), session (3), developers (3), changelog (3), customer (3), enterprise (3), grade (3), features (3), build (3), community (2), status (2), footer (2), has (2), been (2), deleted (2), single (2), were (2), when (2), configured (2), issues (2), development (2), milestone (2), projects (2), targeted (2), release (2), target (2), area (2), bidirectional (2), what (2), about (2), application (2), 0be52a8 (2), checks (2), details (2), looks (2), like (2), last (2), authored (2), without (2), cla (2), contributor (2), e15fff0 (2), ffdecff (2), fixup (2), 9ca3acf (2), adds (2), but (2), generates (2), inherits (2), workspaces (2), such (2), those (2), updated (2), v20 (2), failed (2), resolve (2), pass (2), library (2), does (2), 34449 (2), 661609e (2), still (2), awaiting (2), least (2), reviewer (2), thread (2), index_spec (2), test (2), low (2), duplicate (2), off (2), topic (2), abuse (2), spam (2), will (2), displayed (2), describe (2), others (2), problem (2), defaults (2), head (2), name (2), clipboard (2), insights (2), actions (2), 197 (2), signed (2), universe (2), training (2), integrations (2), stories (2), center (2), documentation (2), business (2), fixes (2), products (2), secret (2), perform, time, share, personal, information, manage, cookies, contact, docs, privacy, terms, inc, right, now, check, back, later, queued, multi, pending, marked, must, change, existing, order, create, valid, applying, lines, supported, only, per, viewing, subset, closed, invalid, because, made, participants, produce, broken, imports, module, route, successfully, merging, close, none, yet, assigned, assignees, whose, approvals, affect, requirements, already, have, account, join, free, show, contains, text, interpreted, compiled, differently, than, appears, below, editor, reveals, root, 34685, produces, missing, stylesheet, 34684, referenced, nov, e9ae950, following, branches, passed, thumbs, fixed, author, 10ccb08, refs, aabcefe, d35e8c2, index, heart, thanks, contribution, regarding, c7f3fce, 7ece3b8, updates, explicitly, string, prevents, inheriting, custom, which, would, otherwise, alter, class, names, break, expected, additionally, unit, verify, behavior, emulating, are, address, look, solid, label, robot, eyes, closes, edited, files, changed, items, requests, message, dismiss, alert, switched, accounts, out, appearance, settings, search, pricing, event, talks, workshops, partners, company, forum, events, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, why, evaluate, see, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, source, latest, improvements, across, place, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, environments, codespaces, analysis, enforcement, automation, ship, coding, agent, tasks, automated, work, hosting, collaboration, platform, menu, skip, content,
Text of the page (random words):
fix schematics angular set explicit type for the app shell component by meakib pull request 34450 angular angular cli github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message angular angular cli repository navigation code issues 197 197 pull requests 24 24 actions security and quality 8 8 insights more items fix schematics angular set explicit type for the app shell component 34450 34450 merged alan agius4 merged 3 commits into angular main angular angular cli main from meakib fix app shell component type meakib angular cli fix app shell component type copy head branch name to clipboard oct 27 2026 conversation commits 3 3 checks files changed merged fix schematics angular set explicit type for the app shell component 34450 alan agius4 merged 3 commits into angular main angular angular cli main from meakib fix app shell component type meakib angular cli fix app shell component type copy head branch name to clipboard conversation meakib commented oct 20 2026 edited by alan agius4 loading uh oh there was an error while loading please reload this page copy link copy markdown contributor ng generate app shell adds an appshell import from app shell app shell but the component it generates inherits the workspace type option in workspaces that set schematics angular component type component such as those updated to v20 the component was generated as app shell component ts and the import failed to resolve pass an empty type as the library schematic does 661609e closes 34449 sorry something went wrong uh oh there was an error while loading please reload this page 1 gemini code assist bot reacted with eyes emoji all reactions 1 reaction angular robot bot added the area schematics angular label oct 20 2026 gemini code assist bot reviewed oct 20 2026 view reviewed changes gemini code assist bot left a comment copy link copy markdown there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment code review this pull request updates the angular app shell schematic to explicitly set the component type option to an empty string type this prevents the generated app shell component from inheriting a custom component type from the workspace defaults which would otherwise alter the file and class names and break the expected appshell import additionally a unit test has been added to verify this behavior by emulating workspace defaults there are no review comments to address and the changes look solid sorry something went wrong uh oh there was an error while loading please reload this page all reactions meakib force pushed the fix app shell component type branch from 7ece3b8 to c7f3fce compare october 20 2026 18 13 alan agius4 requested changes oct 21 2026 view reviewed changes alan agius4 left a comment copy link copy markdown collaborator there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment thanks for the contribution left a comment regarding the test in packages schematics angular app shell index_spec ts sorry something went wrong uh oh there was an error while loading please reload this page ️ 1 meakib reacted with heart emoji all reactions ️ 1 reaction comment thread packages schematics angular app shell index_spec ts resolved uh oh there was an error while loading please reload this page alan agius4 added action cleanup the pr is in need of cleanup either due to needing a rebase or in response to comments from reviews target patch this pr is targeted for the next patch release labels oct 21 2026 meakib requested a review from alan agius4 october 22 2026 02 06 alan agius4 added action review the pr is still awaiting reviews from at least one requested reviewer and removed action cleanup the pr is in need of cleanup either due to needing a rebase or in response to comments from reviews labels oct 22 2026 thekhegay reviewed oct 24 2026 view reviewed changes comment thread packages schematics angular app shell index ts resolved uh oh there was an error while loading please reload this page meakib force pushed the fix app shell component type branch from d35e8c2 to 9ca3acf compare october 24 2026 11 25 alan agius4 approved these changes oct 27 2026 view reviewed changes alan agius4 added action merge the pr is ready for merge by the caretaker and removed action review the pr is still awaiting reviews from at least one requested reviewer labels oct 27 2026 meakib added 2 commits october 27 2026 08 00 fix schematics angular set explicit type for the app shell component aabcefe ng generate app shell adds an appshell import from app shell app shell but the component it generates inherits the workspace type option in workspaces that set schematics angular component type component such as those updated to v20 the component was generated as app shell component ts and the import failed to resolve pass an empty type as the library schematic does 661609e refs angular 34449 fixup fix schematics angular set explicit type for the app shell 10ccb08 component alan agius4 force pushed the fix app shell component type branch from 9ca3acf to ffdecff compare october 27 2026 08 00 alan agius4 added action cleanup the pr is in need of cleanup either due to needing a rebase or in response to comments from reviews and removed action merge the pr is ready for merge by the caretaker labels oct 27 2026 alan agius4 commented oct 27 2026 copy link copy markdown collaborator meakib looks like the last commit was co authored without a cla all reactions sorry something went wrong uh oh there was an error while loading please reload this page fixup fix schematics angular set explicit type for the app shell e15fff0 component meakib force pushed the fix app shell component type branch from ffdecff to e15fff0 compare october 27 2026 08 39 meakib requested a review from alan agius4 october 27 2026 09 08 meakib commented oct 27 2026 copy link copy markdown contributor author meakib looks like the last commit was co authored without a cla fixed 1 alan agius4 reacted with thumbs up emoji all reactions 1 reaction sorry something went wrong uh oh there was an error while loading please reload this page alan agius4 approved these changes oct 27 2026 view reviewed changes alan agius4 added action merge the pr is ready for merge by the caretaker and removed action cleanup the pr is in need of cleanup either due to needing a rebase or in response to comments from reviews labels oct 27 2026 hide details view details alan agius4 merged commit 0be52a8 into angular main oct 27 2026 40 checks passed uh oh there was an error while loading please reload this page alan agius4 commented oct 27 2026 copy link copy markdown collaborator this pr was merged into the repository the changes were merged into the following branches main 0be52a8 22 2 x e9ae950 all reactions sorry something went wrong uh oh there was an error while loading please reload this page meakib deleted the fix app shell component type branch october 27 2026 15 05 this was referenced nov 11 2026 ng generate application produces a missing stylesheet when a workspace component type is configured 34684 open fix schematics angular set explicit type for the application root component 34685 open this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters sign up for free to join this conversation on github already have an account sign in to comment reviewers alan agius4 alan agius4 approved these changes 2 more reviewers thekhegay thekhegay left review comments gemini code assist bot gemini code assist bot left review comments reviewers whose approvals may not affect merge requirements uh oh there was an error while loading please reload this page assignees no one assigned labels action merge the pr is ready for merge by the caretaker area schematics angular target patch this pr is targeted for the next patch release projects none yet milestone no milestone development successfully merging this pull request may close these issues ng generate app shell and ng generate module route produce broken imports when a component type is configured uh oh there was an error while loading please reload this page 3 participants add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge suggestion cannot be applied right now please check back later footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
|