site address:
github.com/angular/angular-cli/pull/34619/files redirected to: github.com/angular/angular-cli/pull/34619/files
site title:
fix(@schematics/angular): add a TODO for negated expectAsync matchers in refactor-jasmine-vitest by MeAkib · Pull Request #34619 · angular/angular-cli · GitHub
|
|
|
Our opinion (on Thursday 19 November 2026 15:02:11 UTC):
- no comments
|
|
|
|
After content analysis of this website we propose the following hashtags:
|
|
|
|
Meta tags:
description= Negated async matchers such as expectAsync(promise).not.toBeResolved() were left unchanged without a TODO comment, so the migrated test failed at runtime because expectAsync does not exist in Vitest.
Negated async matchers have no exact Vitest equivalent, so add the existing unsupported expectAsync matcher TODO comment to them.;
Headings (most frequently used words):
uh, oh, for, navigation, fix, schematics, angular, add, todo, negated, expectasync, matchers, in, refactor, jasmine, vitest, 34619, are, footer, you, diff, view, menu, repository, there, no, files, selected, viewing, sure, want, to, change, the, base, filter, by, extension,
Text of the page (most frequently used words):
expectasync (29), node (24), for (20), this (19), file (19), expression (19), github (16), todo (16), #matcher (16), angular (16), the (15), jasmine (15), current (15), and (15), not (14), add (14), vitest (14), toberesolved (13), await (12), mypromise (12), withcontext (12), category (12), matchername (12), const (12), applied (11), loading (11), schematics (11), please (10), reload (10), name (10), you (9), while (9), line (9), all (9), negated (8), show (8), text (8), refactor (8), that (7), suggestion (7), cannot (7), suggestions (7), code (7), meakib (7), open (7), fix (7), sign (7), changes (6), there (6), input (6), tobepending (6), description (6), should (6), with (6), unsupported (6), already (6), diff (6), hidden (6), characters (6), unicode (6), return (6), modifiernames (6), reporter (6), else (6), undefined (6), isidentifier (6), expectcall (6), matcherpae (6), commits (6), security (5), comments (5), from (5), change (5), was (5), error (5), page (5), expand (5), expected (5), found (5), packages (5), transformers (5), sourcefile (5), base (5), your (5), can (4), 2026 (4), pull (4), expect (4), then (4), msg (4), migration (4), migrate (4), manually (4), number (4), bidirectional (4), may (4), review (4), learn (4), about (4), view (4), addtodocomment (4), recordtodo (4), ispropertyaccessexpression (4), iscallexpression (4), files (4), load (4), matchers (4), support (4), copilot (4), community (3), navigation (3), request (3), resolved (3), batch (3), single (3), commit (3), retry (3), down (3), modified (3), transformexpectasync (3), what (3), below (3), more (3), matcher_spec (3), async (3), mapping (3), hide (3), whitespace (3), filter (3), 34619 (3), branch (3), refname (3), account (3), quality (3), another (3), tab (3), window (3), refresh (3), session (3), developers (3), changelog (3), customer (3), enterprise (3), grade (3), features (3), build (3), contact (2), status (2), privacy (2), terms (2), footer (2), merge (2), marked (2), outdated (2), only (2), one (2), viewing (2), toggle (2), chained (2), modifiers (2), conversation (2), original (2), contains (2), interpreted (2), compiled (2), differently (2), than (2), appears (2), editor (2), reveals (2), desktop (2), delete (2), edit (2), additions (2), deletions (2), length (2), export (2), function (2), async_matcher_changes (2), get (2), unshift (2), let (2), call (2), chain (2), modifier (2), any (2), have (2), 259 (2), are (2), selected (2), apply (2), split (2), unified (2), failed (2), jump (2), extension (2), nov (2), fixup (2), select (2), tree (2), old (2), default (2), could (2), tags (2), branches (2), main (2), issue (2), insights (2), actions (2), 197 (2), repository (2), cli (2), signed (2), universe (2), training (2), integrations (2), stories (2), center (2), documentation (2), business (2), fixes (2), products (2), secret (2), perform, action, time, share, personal, information, manage, cookies, docs, inc, right, now, check, back, later, queued, multi, pending, reviews, has, been, must, existing, order, create, valid, applying, deleted, lines, supported, per, subset, closed, invalid, because, were, made, annotations, notes, oops, something, went, wrong, specific, resolves, tothrow, transform, combined, comment, thread, tobesomethingelse, describe, join, factory, createcallexpression, newmatcherchain, newmatcherargs, 297, 320, reporttransformation, callexpression, string, intermediate, handling, chainable, method, other, direct, equivalent, falls, through, walk, root, matchercall, refactorcontext, conversations, clear, filters, viewed, type, nbsp, 96f96b9, c40aefa, oct, 4c69f0c, hold, shift, click, range, changed, checks, wants, into, some, removed, timeline, become, sure, want, nothing, choose, clicking, agree, our, occasionally, send, related, emails, statement, service, free, its, maintainers, question, project, new, items, requests, issues, message, dismiss, alert, switched, accounts, out, appearance, settings, search, pricing, event, talks, workshops, next, partners, company, forum, events, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, why, evaluate, see, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, source, latest, improvements, across, place, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, development, environments, codespaces, analysis, enforcement, automation, ship, coding, agent, tasks, projects, automated, work, hosting, collaboration, platform, menu, skip, content,
Text of the page (random words):
fix schematics angular add a todo for negated expectasync matchers in refactor jasmine vitest by meakib pull request 34619 angular angular cli github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message angular angular cli repository navigation code issues 197 197 pull requests 24 24 actions security and quality 8 8 insights more items fix schematics angular add a todo for negated expectasync matchers in refactor jasmine vitest 34619 new issue have a question about this project sign up for a free github account to open an issue and contact its maintainers and the community sign up for github by clicking sign up for github you agree to our terms of service and privacy statement we ll occasionally send you account related emails already on github sign in to your account open meakib wants to merge 3 commits into angular main base main choose a base branch branches tags could not load branches branch not found refname loading refname default could not load tags nothing to show refname default loading are you sure you want to change the base some commits from the old base branch may be removed from the timeline and old review comments may become outdated loading change base from meakib fix jasmine vitest negated expect async conversation 8 commits 3 checks 10 files changed uh oh there was an error while loading please reload this page open fix schematics angular add a todo for negated expectasync matchers in refactor jasmine vitest 34619 show file tree hide file tree changes from all commits commits show all changes 3 commits select commit hold shift click to select a range 4c69f0c fix schematics angular add a todo for negated expectasync matchers meakib oct 31 2026 c40aefa fixup fix schematics angular add a todo for negated expectasync m meakib nov 3 2026 96f96b9 fixup fix schematics angular add a todo for negated expectasync m meakib nov 4 2026 file filter filter by extension filter by extension ts nbsp 2 all 1 file type selected viewed files clear filters conversations failed to load comments retry loading uh oh there was an error while loading please reload this page jump to jump to file failed to load files retry loading uh oh there was an error while loading please reload this page diff view unified split hide whitespace apply and reload show whitespace diff view unified split hide whitespace apply and reload packages schematics angular refactor jasmine vitest transformers packages schematics angular refactor jasmine vitest transformers jasmine matcher ts jasmine matcher ts packages schematics angular refactor jasmine vitest transformers jasmine matcher_spec ts jasmine matcher_spec ts there are no files selected for viewing 61 changes 41 additions 20 deletions 61 packages schematics angular refactor jasmine vitest transformers jasmine matcher ts show comments view file edit file delete file open in desktop this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters original file line number diff line number diff line change expand up 259 24 259 47 export function transformexpectasync node ts node sourcefile reporter refactorcontext ts node if ts iscallexpression node ts ispropertyaccessexpression node expression ts iscallexpression node expression expression if ts iscallexpression node ts ispropertyaccessexpression node expression return node const matchercall node const matcherpae node expression const expectcall node expression expression if ts isidentifier expectcall expression expectcall expression text expectasync const matchername ts isidentifier matcherpae name matcherpae name text undefined if matchername matchername withcontext return node const matchername ts isidentifier matcherpae name matcherpae name text undefined const mapping matchername async_matcher_changes get matchername undefined walk down any modifier chain not already withcontext to the root call modifiers have no direct vitest equivalent so a modified matcher falls through to the todo handling below withcontext is the only chainable modifier method so any other intermediate call e g a then chained on a matcher is not an expectasync chain const modifiernames string let expectcall ts callexpression undefined let current ts expression matcherpae expression while expectcall if ts iscallexpression current if ts isidentifier current expression current expression text expectasync expectcall current else if ts ispropertyaccessexpression current expression ts isidentifier current expression name current expression name text withcontext modifiernames unshift withcontext current current expression expression else return node else if ts ispropertyaccessexpression current ts isidentifier current name modifiernames unshift current name text current current expression else return node const mapping modifiernames length 0 async_matcher_changes get matchername undefined if mapping reporter reporttransformation expand all 297 16 320 14 export function transformexpectasync return ts factory createcallexpression newmatcherchain undefined newmatcherargs if matchername if matchername tobepending const category tobepending reporter recordtodo category sourcefile node addtodocomment node category else const category unsupported expect async matcher reporter recordtodo category sourcefile node addtodocomment node category name matchername if matchername tobepending modifiernames length 0 const category tobepending reporter recordtodo category sourcefile node addtodocomment node category else const category unsupported expect async matcher reporter recordtodo category sourcefile node addtodocomment node category name modifiernames matchername join return node expand down 37 changes 37 additions 0 deletions 37 packages schematics angular refactor jasmine vitest transformers jasmine matcher_spec ts show comments view file edit file delete file open in desktop this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters original file line number diff line number diff line change expand up 84 6 84 43 describe transformexpectasync await expectasync mypromise tobesomethingelse description should add a todo for a negated expectasync matcher input await expectasync mypromise not toberesolved expected todo vitest migration unsupported expectasync matcher not toberesolved found please migrate this manually await expectasync mypromise not toberesolved description should add a todo for an expectasync matcher modified with already input await expectasync mypromise already toberesolved expected todo vitest migration unsupported expectasync matcher already toberesolved found please migrate this manually await expectasync mypromise already toberesolved description should add a todo for an expectasync matcher modified with withcontext input await expectasync mypromise withcontext msg toberesolved expected todo vitest migration unsupported expectasync matcher withcontext toberesolved found please migrate this manually await expectasync mypromise withcontext msg toberesolved comment thread meakib marked this conversation as resolved resolved uh oh there was an error while loading please reload this page description should add a single todo for an expectasync matcher with combined modifiers input await expectasync mypromise withcontext msg not toberesolved expected todo vitest migration unsupported expectasync matcher withcontext not toberesolved found please migrate this manually await expectasync mypromise withcontext msg not toberesolved description should transform an expectasync matcher with a chained then input await expectasync mypromise toberesolved then expected await expect mypromise resolves not tothrow then description should add a specific todo for tobepending input await expectasync mypromise tobepending expand down loading oops something went wrong retry uh oh there was an error while loading please reload this page toggle all file notes toggle all file annotations add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge suggestion cannot be applied right now please check back later footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
|
|
| Thumbnail images (randomly selected): * Images may be subject to copyright. | |  |
|
Verified site has: 60 subpage(s). Do you want to verify them? Verify pages:
|
The site also has references to the 5 subdomain(s)
|
The site also has 5 references to external domain(s).
|
|
|
Pages verified in the last hours (randomly selected):
|
|
Top 50 hastags from of all verified websites.
| |
|
|
|
|
|
|
Load Info| page size | 58847 | | load time (s) | 1.215184 | | redirect count | 1 | | speed download | 48433 | | server IP | 140.82.121.4 |
|
|
|
|
|
|
|
|
* Image may be subject to copyright.
|
|