site address:
github.com/angular/angular-cli/pull/34734/files redirected to: github.com/angular/angular-cli/pull/34734/files
site title:
fix(@angular/pwa): support projects with the pre-v18 src/assets layout by MeAkib · Pull Request #34734 · angular/angular-cli · GitHub
|
|
|
Our opinion (on Wednesday 18 November 2026 19:52:12 UTC):
- no comments
|
|
|
|
After content analysis of this website we propose the following hashtags:
|
|
|
|
Meta tags:
description= ng add @angular/pwa decides between the public and legacy src/assets layouts with host.exists(assetsDir), but Tree.exists() only matches files, so the legacy branch never runs and pre-v18 layout projects get the manifest and icons in a public directory their build does not serve. The manifest link injected into index.html then 404s and the application is not installable, while the schematic reports success.
Detect the directory through its entries instead and restore the layout that worked before the public directory support was introduced: the manifest is written to the source root, where the asset entry added to the workspace configuration and the injected manifest link already point, and the icons are written to the existing assets directory with the manifest referencing them as assets/icons/*. The workspace file is now written after the asset entry additions, which previously happened after writeWorkspace() and were never persisted. Projects using the public directory layout are unaffected.;
Headings (most frequently used words):
uh, oh, the, navigation, fix, angular, pwa, support, projects, with, pre, v18, src, assets, layout, 34734, are, footer, you, diff, view, menu, repository, there, no, files, selected, for, viewing, sure, want, to, change, base, filter, by, extension,
Text of the page (most frequently used words):
the (33), assets (24), file (19), #projects (18), angular (18), and (17), github (16), pwa (16), const (15), src (14), this (13), bar (13), manifest (13), tree (12), for (12), applied (11), options (11), icons (11), loading (10), you (9), line (9), all (9), reload (9), build (9), that (8), add (8), json (8), show (8), files (8), assetsdir (8), support (8), suggestion (7), cannot (7), suggestions (7), while (7), from (7), code (7), expect (7), apptree (7), exists (7), project (7), layout (7), open (7), posix (7), join (7), sign (7), changes (6), webmanifest (6), config (6), root (6), expand (6), diff (6), hidden (6), characters (6), unicode (6), path (6), filter (6), apply (6), iconspath (6), with (6), not (5), security (5), please (5), comments (5), change (5), commit (5), there (5), await (5), icon (5), public (5), packages (5), host (5), pre (5), v18 (5), fix (5), base (5), your (5), can (4), pull (4), was (4), error (4), page (4), number (4), bidirectional (4), may (4), review (4), learn (4), about (4), view (4), move (4), iconsdir (4), manifestdir (4), sourcepath (4), target (4), default (4), let (4), load (4), meakib (4), commits (4), copilot (4), community (3), navigation (3), request (3), batch (3), retry (3), parse (3), readcontent (3), schematicrunner (3), runschematic (3), defaultoptions (3), should (3), workspace (3), async (3), png (3), directory (3), delete (3), what (3), more (3), index_spec (3), additions (3), url (3), mergewith (3), template (3), service (3), are (3), assetentry (3), string (3), assetsdirentry (3), index (3), hide (3), whitespace (3), 34734 (3), branch (3), refname (3), account (3), quality (3), another (3), tab (3), window (3), refresh (3), session (3), developers (3), changelog (3), customer (3), enterprise (3), grade (3), features (3), contact (2), status (2), privacy (2), terms (2), footer (2), 2026 (2), merge (2), outdated (2), existing (2), create (2), single (2), only (2), one (2), viewing (2), toggle (2), architect (2), configuration (2), application (2), 72x72 (2), tobefalse (2), tobetrue (2), place (2), source (2), favicon (2), ico (2), describe (2), legacy (2), 222 (2), schematic (2), original (2), contains (2), text (2), interpreted (2), compiled (2), differently (2), than (2), appears (2), below (2), editor (2), reveals (2), desktop (2), edit (2), deletions (2), down (2), startswith (2), externalschematic (2), worker (2), swoptions (2), chain (2), writeworkspace (2), asset (2), export (2), function (2), pwaoptions (2), rule (2), already (2), hasassetsdir (2), length (2), selected (2), split (2), unified (2), failed (2), jump (2), extension (2), old (2), could (2), tags (2), branches (2), main (2), issue (2), insights (2), actions (2), 196 (2), repository (2), cli (2), signed (2), universe (2), training (2), integrations (2), stories (2), center (2), documentation (2), business (2), fixes (2), products (2), secret (2), perform, action, time, share, personal, information, manage, cookies, docs, inc, right, now, check, back, later, queued, multi, pending, reviews, has, been, marked, resolved, must, order, valid, applying, deleted, lines, supported, per, subset, closed, invalid, because, were, made, annotations, notes, oops, something, went, wrong, tocontain, tomatch, reference, relative, overwrite, stringify, undefined, gitkeep, beforeeach, swflag, tobe, ngsw, indexfiles, map, updateindexfile, schematics, return, written, after, above, they, persisted, else, 171, 177, array, isarray, buildtargets, testtargets, which, copies, served, sourceroot, subfiles, subdirs, getdir, matches, probe, contained, entries, title, setup, 151, 152, import, conversations, clear, filters, viewed, type, nbsp, nov, 1aaf30b, select, changed, checks, conversation, wants, into, some, removed, timeline, become, sure, want, nothing, found, choose, clicking, agree, our, occasionally, send, related, emails, statement, free, its, maintainers, have, question, new, items, requests, issues, message, dismiss, alert, switched, accounts, out, appearance, settings, search, pricing, event, talks, workshops, next, partners, company, forum, events, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, why, evaluate, see, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, latest, improvements, across, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, development, environments, codespaces, analysis, enforcement, automation, ship, coding, agent, tasks, automated, work, hosting, collaboration, platform, menu, skip, content,
Text of the page (random words):
fix angular pwa support projects with the pre v18 src assets layout by meakib pull request 34734 angular angular cli github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message angular angular cli repository navigation code issues 196 196 pull requests 19 19 actions security and quality 8 8 insights more items fix angular pwa support projects with the pre v18 src assets layout 34734 new issue have a question about this project sign up for a free github account to open an issue and contact its maintainers and the community sign up for github by clicking sign up for github you agree to our terms of service and privacy statement we ll occasionally send you account related emails already on github sign in to your account open meakib wants to merge 1 commit into angular main base main choose a base branch branches tags could not load branches branch not found refname loading refname default could not load tags nothing to show refname default loading are you sure you want to change the base some commits from the old base branch may be removed from the timeline and old review comments may become outdated loading change base from meakib fix pwa legacy assets layout conversation 0 commits 1 checks 39 files changed uh oh there was an error while loading please reload this page open fix angular pwa support projects with the pre v18 src assets layout 34734 show file tree hide file tree changes from all commits commits show all changes 1 commit select commit 1aaf30b fix angular pwa support projects with the pre v18 src assets layout meakib nov 16 2026 file filter filter by extension filter by extension ts nbsp 2 all 1 file type selected viewed files clear filters conversations failed to load comments retry loading uh oh there was an error while loading please reload this page jump to jump to file failed to load files retry loading uh oh there was an error while loading please reload this page diff view unified split hide whitespace apply and reload show whitespace diff view unified split hide whitespace apply and reload packages angular pwa pwa packages angular pwa pwa index ts index ts packages angular pwa pwa index_spec ts index_spec ts there are no files selected for viewing 43 changes 32 additions 11 deletions 43 packages angular pwa pwa index ts show comments view file edit file delete file open in desktop this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters original file line number diff line number diff line change expand up 13 6 13 7 import apply chain externalschematic filter mergewith move template expand down expand up 151 15 152 20 export default function options pwaoptions rule setup service worker schematic options const title swoptions options await writeworkspace host workspace let assetsdir posix join sourcepath assets const assetsdir posix join sourcepath assets tree exists only matches files so probe the directory for contained entries const assetsdirentry host getdir assetsdir const hasassetsdir host exists assetsdir assetsdirentry subfiles length 0 assetsdirentry subdirs length 0 let iconspath string if host exists assetsdir add manifest to asset configuration const assetentry posix join project sourceroot posix join project root src manifest webmanifest let manifestdir string let iconsdir string if hasassetsdir pre v18 project layout the manifest is served from the application root and the icons from the existing assets directory which the build already copies const assetentry posix join sourcepath manifest webmanifest for const target of buildtargets testtargets if target options if array isarray target options assets expand all 171 16 177 31 export default function options pwaoptions rule target options assets assetentry iconspath assets iconspath assets icons manifestdir sourcepath iconsdir assetsdir else assetsdir posix join project root public iconspath icons manifestdir iconsdir posix join project root public written after the asset additions above so that they are persisted await writeworkspace host workspace return chain externalschematic schematics angular service worker swoptions mergewith apply url files assets template options iconspath move assetsdir apply url files assets filter path path startswith icons template options iconspath move manifestdir mergewith apply url files assets filter path path startswith icons move iconsdir indexfiles map path updateindexfile path expand down 39 changes 39 additions 0 deletions 39 packages angular pwa pwa index_spec ts show comments view file edit file delete file open in desktop this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters original file line number diff line number diff line change expand up 222 4 222 43 describe pwa schematic expect swflag tobe projects bar ngsw config json describe legacy src assets project layout beforeeach apptree create projects bar src assets gitkeep apptree delete projects bar public favicon ico const config json parse apptree readcontent angular json const build config projects bar architect build build options assets projects bar src favicon ico projects bar src assets apptree overwrite angular json json stringify config undefined 2 it should place the manifest at the source root and the icons in the assets directory async const tree await schematicrunner runschematic ng add defaultoptions apptree expect tree exists projects bar src manifest webmanifest tobetrue expect tree exists projects bar src assets icons icon 72x72 png tobetrue expect tree exists projects bar public manifest webmanifest tobefalse expect tree exists projects bar public icons icon 72x72 png tobefalse it should reference the icons relative to the application root in the manifest async const tree await schematicrunner runschematic ng add defaultoptions apptree const manifest json parse tree readcontent projects bar src manifest webmanifest for const icon of manifest icons expect icon src tomatch assets icons icon d x d png it should add the manifest to the build assets in the workspace configuration async const tree await schematicrunner runschematic ng add defaultoptions apptree const config json parse tree readcontent angular json expect config projects bar architect build options assets tocontain projects bar src manifest webmanifest loading oops something went wrong retry uh oh there was an error while loading please reload this page toggle all file notes toggle all file annotations add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge suggestion cannot be applied right now please check back later footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
|
|
| Thumbnail images (randomly selected): * Images may be subject to copyright. | |  |
|
Verified site has: 58 subpage(s). Do you want to verify them? Verify pages:
|
The site also has references to the 5 subdomain(s)
|
The site also has 5 references to external domain(s).
|
|
|
Pages verified in the last hours (randomly selected):
|
|
Top 50 hastags from of all verified websites.
| |
|
|
|
|
|
|
Load Info| page size | 57726 | | load time (s) | 1.191771 | | redirect count | 1 | | speed download | 48468 | | server IP | 140.82.121.4 |
|
|
|
|
|
|
|
|
* Image may be subject to copyright.
|
|