Meta tags:
description= Use Case We should support filtering requests made to APIs defined with the JAX-RS API, just as we do for the Java EE Servlet API. Proposal I think it will likely make sense to leverage similar strategies for instrumenting JAX-RS resourc...;
Headings (most frequently used words):
commented, on, may, 2021, 25, navigation, ryandens, pavolloffay, to, metadata, footer, add, support, for, filtering, requests, apis, defined, with, jax, rs, 320, menu, repository, description, use, case, proposal, questions, address, if, any, activity, issue, actions, 24, 26, assignees, labels, type, projects, milestone, relationships, development,
Text of the page (most frequently used words):
the (41), and (26), for (25), jax (24), jersey (16), this (15), github (15), instrumentation (15), jetty (15), may (15), 2021 (15), you (14), #filter (14), with (13), servlet (12), ryandens (11), implementation (11), api (11), actions (10), requests (10), application (10), support (10), request (9), more (8), hypertrace (8), that (7), java (7), case (7), pavolloffay (7), agent (7), not (6), have (6), should (6), use (6), member (6), commented (6), using (6), dropwizard (6), headers (6), security (5), copilot (5), issue (5), sign (5), how (5), there (5), because (5), some (5), mean (5), run (5), build (5), org (5), defined (5), add (5), code (5), projects (4), extra (4), attention (4), needed (4), smallrye (4), jwt (4), server (4), able (4), all (4), otel (4), http (4), would (4), container (4), sure (4), what (4), make (4), another (4), filtering (4), apis (4), your (4), navigation (3), open (3), area (3), help (3), also (3), blocking (3), might (3), however (3), span (3), instrumenting (3), containers (3), think (3), leverage (3), each (3), across (3), was (3), are (3), surprising (3), author (3), events (3), these (3), running (3), but (3), report (3), response (3), bodies (3), evaluate (3), work (3), out (3), copy (3), link (3), 320 (3), quality (3), tab (3), window (3), refresh (3), session (3), reload (3), developers (3), changelog (3), customer (3), enterprise (3), grade (3), features (3), can (2), community (2), status (2), footer (2), app (2), pull (2), development (2), milestone (2), type (2), labels (2), assignees (2), metadata (2), already (2), added (2), wanted (2), look (2), https (2), com (2), main (2), jaxrs (2), before (2), single (2), url (2), pre (2), matching (2), solve (2), capture (2), instrumentations (2), leaning (2), towards (2), servers (2), existing (2), from (2), alternative (2), probably (2), writing (2), come (2), just (2), guess (2), depends (2), bootstrapped (2), offers (2), integration (2), describing (2), true (2), then (2), implements (2), directly (2), hander (2), undertow (2), finished (2), our (2), noop (2), additional (2), see (2), runs (2), instrument (2), necessary (2), simple (2), without (2), won (2), never (2), asked (2), netty (2), need (2), allowedmethodsfilter (2), body (2), any (2), sense (2), likely (2), resources (2), new (2), insights (2), repository (2), javaagent (2), signed (2), universe (2), training (2), integrations (2), stories (2), center (2), documentation (2), learn (2), business (2), fixes (2), products (2), secret (2), perform, action, time, share, personal, information, manage, cookies, contact, docs, privacy, terms, 2026, inc, branches, none, yet, relationships, comment, account, join, conversation, free, removed, dec, 2024, handles, blob, src, auth, jwtauthenticationfilter, l82, mentioned, direct, only, advantage, capturing, unmapped, target, outside, context, path, discriminator, www, logicbig, tutorials, tutorial, filters, html, works, write, implementations, lifecycle, creation, finish, error, handled, referring, artifact, personally, applications, bootstrap, jettyhttpcontainerfactory, yes, two, ways, understand, note, instruments, create, unmatched, past, bug, early, causing, recording, proceeding, implementing, stacktrace, executed, lang, thread, dumpstack, both, scenarios, multiple, levels, interfere, either, second, option, now, provides, better, coverage, side, different, solutions, usually, top, reactive, ones, things, did, exploratory, testing, found, results, sample, block, really, surprised, turns, module, registers, part, handling, chain, called, transforms, allows, data, allow, consider, servlet30andfilterinstrumentation, javax, sorry, been, clear, supporting, reporting, endpoint, exactly, fitlering, disabling, tracing, predefined, endpoints, patterns, taking, hear, were, looking, while, back, got, opinions, where, start, let, know, self, assigned, activity, specific, trying, web, leveraging, possible, could, targeting, internals, like, which, solution, worth, considering, questions, address, will, similar, strategies, done, opentelemetry, modules, bulk, according, minor, tweaks, here, want, proposal, made, opened, description, items, discussions, issues, message, dismiss, alert, switched, accounts, appearance, settings, search, pricing, event, talks, workshops, next, partners, about, company, forum, webinars, blog, resource, connect, premium, advanced, ons, trust, why, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, source, latest, improvements, one, place, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, environments, codespaces, analysis, enforcement, automation, ship, coding, tasks, automated, hosting, review, collaboration, platform, menu, skip, content,
Text of the page (random words):
add support for filtering requests to apis defined with jax rs issue 320 hypertrace javaagent github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message hypertrace javaagent repository navigation code issues 35 35 pull requests 4 4 discussions actions projects security and quality insights more items add support for filtering requests to apis defined with jax rs 320 new issue copy link new issue copy link open open add support for filtering requests to apis defined with jax rs 320 copy link assignees labels area instrumentation description ryandens opened on may 24 2021 issue body actions use case we should support filtering requests made to apis defined with the jax rs api just as we do for the java ee servlet api proposal i think it will likely make sense to leverage similar strategies for instrumenting jax rs resources as is done by opentelemetry in these modules we ll likely be able to do the bulk of the work according to the jax rs api with minor tweaks here and there for each jax rs implementation we want to support questions to address if any the specific use case i m trying to help solve is a jersey jax rs web application running on jetty leveraging dropwizard it s possible it could make sense to add support for this use case by targeting jetty internals like we do for netty which is another solution worth considering activity ryandens added area instrumentation on may 24 2021 ryandens self assigned this on may 24 2021 ryandens commented on may 24 2021 ryandens on may 24 2021 member author more actions pavolloffay i m taking a look at the dropwizard jersey jetty use case i hear you were looking at this a while back so if you ve got any opinions on where i should start out let me know pavolloffay commented on may 25 2021 pavolloffay on may 25 2021 member more actions what exactly do you mean by fitlering do you mean disabling tracing for predefined endpoints url patterns ryandens commented on may 25 2021 ryandens on may 25 2021 member author more actions sorry i should have been more clear i mean supporting the reporting of the request body headers and blocking a request using an implementation of org hypertrace agent filter api filter to an api endpoint defined with jax rs i did some exploratory testing of this and found some surprising results using a dropwizard sample application we report the request response bodies headers and can block requests using a org hypertrace agent filter api filter implementation i was really surprised by this but it turns out the dropwizard jersey module registers a javax servlet filter implementation as part of the request handling chain called allowedmethodsfilter the hypertrace servlet30andfilterinstrumentation transforms the allowedmethodsfilter and allows us to capture the data we need and allow for a org hypertrace agent filter api filter implementation to consider blocking the request however it is not necessary to run jersey jax rs application on jetty with a java ee servlet filter if you build a simple jersey jax rs application running on jetty but without using dropwizard we won t report the request response bodies and headers and the org hypertrace agent filter api filter implementation is never asked to evaluate the request headers we d need some additional instrumentation to make these things work for this use case pavolloffay commented on may 25 2021 pavolloffay on may 25 2021 member more actions usually jax rs runs on top of the servlet implementation or netty for reactive ones however it is not necessary to run jersey jax rs application on jetty with a java ee servlet filter if you build a simple jersey jax rs application running on jetty but without using dropwizard we won t report the request response bodies and headers and the org hypertrace agent filter api filter implementation is never asked to evaluate the request headers this is surprising i guess it also depends on how the application is bootstrapped because jersey for sure offers servlet integration if what you are describing is true then jersey implements directly jetty hander api there might be different solutions to this instrument servlet container jetty instrument server side jax rs in both of these scenarios you have to be sure that instrumentations on multiple levels do not interfere e g either servlet or jax rs instrumentation runs i would go with the second option for now as it provides better coverage note that otel agent instruments servlet containers app server e g to create events for unmatched requests and in the past there was a bug with undertow the undertow instrumentation finished early span causing our instrumentation to be noop a finished span is not recording events and in this case our instrumentation is noop before proceeding with implementing additional instrumentation i would run java lang thread dumpstack to see the stacktrace and make sure that no servlet is executed ryandens commented on may 25 2021 ryandens on may 25 2021 member author more actions this is surprising i guess it also depends on how the application is bootstrapped because jersey for sure offers servlet integration if what you are describing is true then jersey implements directly jetty hander api yes there are two ways as i understand it to run jersey on jetty jersey container jetty http jersey container jetty servlet i was referring to the jersey container jetty http artifact just because that s how i personally have run jersey jax rs applications using the jettyhttpcontainerfactory to bootstrap the application i m leaning towards instrumenting the http servers containers because i think we should be able to leverage some existing instrumentation from otel and the alternative would probably mean writing instrumentation for each jax rs implementation we come across pavolloffay commented on may 26 2021 pavolloffay on may 26 2021 member more actions i m leaning towards instrumenting the http servers containers because i think we should be able to leverage some existing instrumentation from otel and the alternative would probably mean writing instrumentation for each jax rs implementation we come across this is not how jax rs works you should be able to write single jax rs instrumentation and use it for all implementations the span lifecycle creation finish error capture is already handled by otel server instrumentations e g jetty in this case as i mentioned before the direct server instrumentation might have only a single advantage capturing unmapped requests e g requests that target url outside of the application context path however there is pre matching discriminator in jax rs that might solve this https www logicbig com tutorials java ee tutorial jax rs filters pre matching html also have a look at smallrye jwt how handles blocking in jax rs filter https github com smallrye smallrye jwt blob main implementation jwt jaxrs src main java io smallrye jwt auth jaxrs jwtauthenticationfilter java l82 ryandens added help wanted extra attention is needed extra attention is needed and removed help wanted extra attention is needed extra attention is needed on dec 9 2024 sign up for free to join this conversation on github already have an account sign in to comment metadata metadata assignees ryandens labels area instrumentation type no type projects no projects milestone no milestone relationships none yet development no branches or pull requests issue actions open in github copilot app footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
|