Meta tags:
description= Open-source JavaScript charting library behind Plotly and Dash - Fix stale zmin/zmax used for autocontour levels after Plotly.react when contours.coloring is none by capy-zhiao · Pull Request #8122 · plotly/plotly.js;
Headings (most frequently used words):
uh, oh, fix, stale, plotly, zhiao, navigation, zmin, zmax, used, for, autocontour, levels, after, react, when, contours, coloring, is, none, to, js, capy, 8117, contour, footer, commented, oct, 15, 2026, loading, 8122, menu, repository, 8122capy, wants, merge, commits, intoplotly, mainplotly, mainfrom, zmincapy, zmincopy, head, branch, name, clipboard, conversation, edited, there, was, an, error, while, please, reload, this, page, camdecoster, reviewers, assignees, labels, projects, milestone, development, participants,
Text of the page (most frequently used words):
the (31), #plotly (24), and (22), zmin (21), this (18), zmax (14), for (14), zauto (14), github (13), capy (13), zhiao (13), trace (12), that (11), applied (11), none (11), fix (11), undefined (11), contour (10), stale (10), while (9), code (8), reload (8), with (8), react (8), coloring (8), 2026 (7), suggestion (7), cannot (7), suggestions (7), from (7), 8117 (7), colorscale (7), calc (7), you (6), please (6), pull (6), there (6), was (6), loading (6), 8122 (6), contours (6), copy (6), can (5), security (5), request (5), add (5), error (5), page (5), sign (5), after (5), all (5), levels (5), false (5), already (4), are (4), full (4), setcontours (4), used (4), auto (4), autocontour (4), when (4), commits (4), oct (4), main (4), your (4), support (4), copilot (4), not (3), navigation (3), back (3), merge (3), line (3), batch (3), commit (3), one (3), camdecoster (3), conversation (3), hidden (3), characters (3), unicode (3), what (3), review (3), open (3), learn (3), branch (3), crosstracedefaults (3), _zmin (3), _zmax (3), new (3), range (3), drawn (3), into (3), fixes (3), quality (3), another (3), tab (3), window (3), refresh (3), session (3), developers (3), changelog (3), customer (3), enterprise (3), grade (3), features (3), build (3), time (2), community (2), status (2), footer (2), check (2), reviews (2), change (2), lines (2), single (2), only (2), changes (2), because (2), uses (2), may (2), issues (2), development (2), milestone (2), yet (2), projects (2), file (2), bidirectional (2), more (2), about (2), october (2), 2c74afe (2), 002dffe (2), draftlog (2), coerced (2), relinkprivatekeys (2), previous (2), onto (2), them (2), treat (2), does (2), added (2), sorry (2), something (2), went (2), wrong (2), reactions (2), markdown (2), link (2), commented (2), its (2), never (2), nothing (2), see (2), datarevision (2), test (2), checks (2), paths (2), way (2), mode (2), still (2), fixed (2), lib (2), aggnums (2), math (2), null (2), vals (2), changed (2), which (2), data (2), next (2), wants (2), head (2), name (2), clipboard (2), insights (2), actions (2), 727 (2), repository (2), signed (2), universe (2), training (2), integrations (2), stories (2), center (2), documentation (2), business (2), products (2), secret (2), perform, action, share, personal, information, manage, cookies, contact, docs, privacy, terms, inc, right, now, later, queued, multi, comments, pending, has, been, marked, resolved, outdated, must, existing, order, create, valid, applying, deleted, supported, per, viewing, subset, closed, invalid, were, made, participants, bug, updated, successfully, merging, close, these, labels, assignees, reviewers, have, account, comment, join, free, show, contains, text, interpreted, compiled, differently, than, appears, below, editor, reveals, compare, force, pushed, loring, attributes, put, falsy, ff311c5, don, reuse, reaction, reacted, thumbs, emoji, thanks, follow, contributor, self, assigned, referenced, thing, hit, checking, stackblitz, issue, layout, sets, notices, array, recalculated, bump, remove, regression, plots, reacts, object, whose, different, before, stay, start, end, size, contour_test, also, looked, skipping, contourcarpet, would, drop, kept, smaller, switch, rather, affects, path, explicit, goes, through, same, too, histogram2dcontour, true, heatmap, fill, min, max, copts, old, come, traced, skips, stays, runs, writes, carries, over, copies, treats, gets, isauto, colorscaledefaults, handlestyledefaults, edited, files, items, requests, message, dismiss, alert, switched, accounts, out, appearance, settings, search, pricing, event, talks, workshops, partners, company, forum, events, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, why, evaluate, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, source, latest, improvements, across, place, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, environments, codespaces, analysis, enforcement, automation, ship, coding, agent, tasks, automated, work, hosting, collaboration, platform, menu, skip, content,
Text of the page (random words):
fix stale zmin zmax used for autocontour levels after plotly react when contours coloring is none by capy zhiao pull request 8122 plotly plotly js github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message plotly plotly js repository navigation code issues 727 727 pull requests 82 82 actions security and quality insights more items fix stale zmin zmax used for autocontour levels after plotly react when contours coloring is none 8122 8122 open capy zhiao wants to merge 2 commits into plotly main plotly plotly js main from capy zhiao fix 8117 contour stale zmin capy zhiao plotly js fix 8117 contour stale zmin copy head branch name to clipboard conversation commits 2 2 checks files changed open fix stale zmin zmax used for autocontour levels after plotly react when contours coloring is none 8122 capy zhiao wants to merge 2 commits into plotly main plotly plotly js main from capy zhiao fix 8117 contour stale zmin capy zhiao plotly js fix 8117 contour stale zmin copy head branch name to clipboard conversation capy zhiao commented oct 15 2026 edited loading uh oh there was an error while loading please reload this page copy link copy markdown fixes 8117 i traced this to contours coloring none in that mode handlestyledefaults skips colorscaledefaults so zauto zmin and zmax are never coerced and zauto stays undefined contour calc js still runs colorscale calc after setcontours which writes zmin _zmin zmax _zmax onto the full trace on the next plotly react relinkprivatekeys carries _zmin _zmax over to the new full trace and colorscale crosstracedefaults copies them back into zmin zmax its isauto check treats undefined as auto by the time setcontours gets to if trace zauto zmin undefined zauto is undefined and zmin is the old data range so the levels come from the previous data and nothing is drawn i changed setcontours to treat an undefined zauto as auto which is what colorscale calc copts auto false and crosstracedefaults already do if trace zauto zmin undefined if trace zauto false zmin undefined zmin lib aggnums math min null vals if trace zauto zmax undefined if trace zauto false zmax undefined zmax lib aggnums math max null vals this only affects the coloring none path with fill lines or heatmap zauto is already true or false and zauto false with explicit zmin zmax still uses the fixed range histogram2dcontour goes through the same code so it is fixed too i also looked at skipping colorscale calc in contour calc js for coloring none the way contourcarpet calc js does that would drop zmin zmax from the full trace in that mode so i kept the smaller change i can switch if you d rather go that way test a plotly react regression test in contour_test js it plots a coloring none contour reacts with a new trace object whose z is in a different range and checks contours start end size and that contour paths are drawn before the fix the levels stay at 2 8 1 and no paths are drawn one thing i hit while checking the stackblitz from the issue its layout sets datarevision 6 so plotly react never notices the new z array and nothing is recalculated bump or remove datarevision to see the fix there sorry something went wrong uh oh there was an error while loading please reload this page all reactions capy zhiao added a commit to capy zhiao plotly js that referenced this pull request oct 15 2026 add draftlog for plotly 8122 002dffe camdecoster self assigned this oct 15 2026 camdecoster commented oct 15 2026 copy link copy markdown contributor thanks for the pr i ll review and follow up 1 capy zhiao reacted with thumbs up emoji all reactions 1 reaction sorry something went wrong uh oh there was an error while loading please reload this page capy zhiao added 2 commits october 15 2026 15 38 fix plotly 8117 don t reuse stale zmin zmax for autocontour when co ff311c5 loring is none with contours coloring none the colorscale attributes are not coerced so zauto is undefined on the full trace after plotly react relinkprivatekeys colorscale crosstracedefaults put the previous _zmin _zmax back onto zmin zmax and setcontours used them because trace zauto was falsy treat an undefined zauto as auto as colorscale calc already does add draftlog for plotly 8122 2c74afe capy zhiao force pushed the fix 8117 contour stale zmin branch from 002dffe to 2c74afe compare october 15 2026 19 39 this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters sign up for free to join this conversation on github already have an account sign in to comment reviewers no reviews uh oh there was an error while loading please reload this page assignees camdecoster labels none yet projects none yet milestone no milestone development successfully merging this pull request may close these issues bug contour trace updated with plotly react uses stale zmin zmax uh oh there was an error while loading please reload this page 2 participants add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge suggestion cannot be applied right now please check back later footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
|