Meta tags:
description= Open-source JavaScript charting library behind Plotly and Dash - fix: Account for marker size when picking the hovered WebGL point by adimalkar · Pull Request #8170 · plotly/plotly.js;
Headings (most frequently used words):
fix, marker, uh, oh, for, navigation, account, size, when, picking, the, hovered, webgl, point, to, plotly, js, adimalkar, 8082, gl, hover, footer, this, comment, 8170, menu, repository, 8170adimalkar, wants, merge, commits, intoplotly, mainplotly, mainfrom, sizeadimalkar, sizecopy, head, branch, name, clipboard, conversation, commented, nov, 11, 2026, why, is, correct, behavior, change, tests, copilot, ai, left, choose, reason, hiding, reviewers, assignees, labels, projects, milestone, development, participants,
Text of the page (most frequently used words):
the (74), #marker (31), this (26), and (26), for (20), point (19), copilot (17), size (16), #review (16), code (14), plotly (14), github (13), hover (13), webgl (12), applied (11), scattergl (11), center (11), pull (9), splom (9), with (9), pointer (9), when (9), adimalkar (9), that (8), request (8), from (8), one (8), was (8), same (8), markers (8), scatter (8), fix (8), suggestion (7), cannot (7), suggestions (7), while (7), reload (7), scatterpolargl (7), not (6), learn (6), comment (6), copy (6), inside (6), sizes (6), 8082 (6), big (6), you (5), can (5), security (5), 2026 (5), please (5), change (5), there (5), account (5), sign (5), all (5), 8170 (5), drawn (5), picking (5), its (5), edge (5), radius (5), hovered (5), main (5), small (5), now (4), merge (4), add (4), changes (4), error (4), loading (4), page (4), more (4), about (4), quality (4), scatterpolar (4), distance (4), search (4), commits (4), tests (4), run (4), your (4), support (4), navigation (3), line (3), batch (3), only (3), because (3), points (3), left (3), cost (3), balanced (3), effort (3), each (3), conversation (3), hidden (3), characters (3), unicode (3), open (3), choose (3), repository (3), billing (3), requested (3), settings (3), reason (3), trace (3), last (3), does (3), won (3), use (3), hoverdistance (3), smaller (3), large (3), box (3), traces (3), fixes (3), wins (3), into (3), another (3), tab (3), window (3), refresh (3), session (3), developers (3), changelog (3), customer (3), enterprise (3), grade (3), features (3), build (3), share (2), community (2), status (2), footer (2), comments (2), reviews (2), has (2), resolved (2), outdated (2), existing (2), order (2), single (2), commit (2), may (2), issues (2), development (2), milestone (2), none (2), yet (2), projects (2), preview (2), analysis (2), low (2), picks (2), already (2), have (2), file (2), bidirectional (2), what (2), reactions (2), sorry (2), something (2), went (2), wrong (2), organization (2), source (2), hiding (2), markdown (2), link (2), reviewed (2), nov (2), november (2), default (2), position (2), two (2), tie (2), expectations (2), plot (2), 30px (2), next (2), which (2), test (2), scores (2), top (2), always (2), did (2), result (2), scoring (2), spatial (2), index (2), largest (2), whose (2), range (2), suites (2), image (2), changed (2), npm (2), chrome (2), 237 (2), 1e5 (2), within (2), label (2), out (2), 8px (2), before (2), svg (2), events (2), behavior (2), why (2), wants (2), head (2), branch (2), name (2), clipboard (2), insights (2), actions (2), 727 (2), signed (2), universe (2), training (2), integrations (2), stories (2), documentation (2), business (2), products (2), secret (2), perform, action, time, personal, information, manage, cookies, contact, docs, privacy, terms, inc, right, check, back, later, queued, multi, pending, been, marked, must, create, valid, applying, deleted, lines, supported, per, viewing, subset, closed, invalid, were, made, participants, bug, ignores, overlapping, successfully, merging, close, these, labels, assigned, assignees, least, approving, required, applies, everyone, most, thorough, high, max, deep, moderate, efficient, lite, adaptive, reviewers, join, free, show, contains, text, interpreted, compiled, differently, than, appears, below, editor, reveals, owner, members, paid, license, unable, user, who, insufficient, remaining, quota, try, requesting, lower, level, hide, duplicate, off, topic, abuse, spam, will, displayed, describe, others, problem, 3632735, draftlog, due, automatic, gives, too, instead, nearer, 36c7508, update, match, laps, three, 400px, middle, also, correctly, a50a450, neighboring, over, prefers, used, different, overlapped, until, came, near, inherits, take, widen, find, 983d004, added, developed, assistance, claude, human, ran, jasmine, baselines, draw, shader, regl, codegen, pass, syntax, lint, 115, 117, failures, are, ohlc, candlestick, lasso, fail, way, machine, 90f954a, select, locally, 157, scattergl_select, gl2d_plot_interact, hover_spikeline, gl2d_click, new, finds, outside, hovers, but, hover_test, still, anchors, item, five, 7px, trial, both, 6px, figure, scatterpolargl_test, several, picked, nearest, hovermode, spikedistance, affect, every, 80px, first, issue, snippet, after, case, give, their, counterparts, checked, real, gets, through, grows, half, computes, convert, moves, math, call, them, getpointdistance, getaxisdistance, measured, correct, closes, makes, they, pick, commented, files, checks, items, requests, message, dismiss, alert, switched, accounts, appearance, pricing, event, talks, workshops, partners, company, forum, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, evaluate, see, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, latest, improvements, across, place, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, environments, codespaces, enforcement, automation, ship, coding, agent, tasks, automated, work, hosting, collaboration, platform, menu, skip, content,
Text of the page (random words):
fix account for marker size when picking the hovered webgl point by adimalkar pull request 8170 plotly plotly js github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message plotly plotly js repository navigation code issues 727 727 pull requests 82 82 actions security and quality insights more items fix account for marker size when picking the hovered webgl point 8170 8170 open adimalkar wants to merge 4 commits into plotly main plotly plotly js main from adimalkar fix 8082 gl hover marker size adimalkar plotly js fix 8082 gl hover marker size copy head branch name to clipboard conversation commits 4 4 checks files changed open fix account for marker size when picking the hovered webgl point 8170 adimalkar wants to merge 4 commits into plotly main plotly plotly js main from adimalkar fix 8082 gl hover marker size adimalkar plotly js fix 8082 gl hover marker size copy head branch name to clipboard conversation adimalkar commented nov 11 2026 copy link copy markdown this pr makes scattergl scatterpolargl and splom use marker size when they pick the hovered point as scatter does closes 8082 why this is correct scatter scores a point by its distance to the marker edge inside a marker a smaller marker wins scattergl and splom measured only the distance to the marker center so the marker drawn on top always won this pr moves the existing scatter math into getaxisdistance and getpointdistance in scatter hover js with no change in behavior scattergl and splom now call them each radius is half of the sizes size that convert already computes for the webgl markers for large traces the spatial index search box grows by the largest marker radius scatterpolargl gets the fix through scattergl behavior change the webgl traces now give the same result as their svg counterparts i checked this with real pointer events in chrome case svg webgl before webgl after issue snippet a size 6 b size 20 same point a b a one trace sizes 6 20 at the same point small big small big marker drawn first pointer 8px from center b a b splom sizes 6 20 big small scatterpolargl vs scatterpolar sizes 6 20 small big small 1e5 points pointer 30px inside an 80px marker big no hover big changes that affect every webgl plot with markers a point is in range when the pointer is within hoverdistance of the marker edge spikedistance and the label order in x hovermode use the scatter scoring when the pointer is inside several markers of the same size the point drawn last wins before webgl picked the nearest center the last item changes five expectations in scatterpolargl_test js the default pointer is 3 7px from point 2 and 5 8px from point 26 of trial 3 both markers have a 6px radius scatterpolar picks point 26 for the same figure the hover label still anchors at the marker center in webgl i left that out of this pr tests new tests in hover_test js hover on points at the same position the smaller marker wins for scatter scattergl and splom a marker hovers when its edge but not its center is within hoverdistance a 1e5 point scattergl trace finds a marker whose center is outside the search box suites run locally chrome 157 hover 237 237 scattergl 48 48 splom 51 51 gl2d_click 12 12 hover_spikeline 45 45 scatterpolargl 32 32 gl2d_plot_interact 16 16 scattergl_select 20 20 select 115 117 the two failures are the ohlc and candlestick lasso tests which fail the same way on main 90f954a on this machine npm run lint and npm run test syntax pass no image baselines change hover does not draw in the image tests i did not run regl codegen because no shader code changed this change was developed with ai assistance claude code a human reviewed the code and ran the jasmine suites sorry something went wrong uh oh there was an error while loading please reload this page all reactions adimalkar added 3 commits november 11 2026 03 12 account for marker size when picking the hovered webgl point 983d004 scatter scores a point by its distance to the marker edge and inside a marker it prefers the smaller one scattergl and splom used the distance to the marker center only so the marker drawn on top always won when markers of different sizes overlapped and a large marker did not hover until the pointer came near its center scatterpolargl inherits the scattergl result share the scatter scoring with scattergl and splom and take each radius from the webgl marker sizes widen the spatial index search box by the largest radius so large traces find markers whose edge is in range fixes plotly 8082 use one point in the hoverdistance test so no neighboring marker over a50a450 laps with three size 80 markers on a 400px plot the pointer 30px from the middle marker was also inside the next one which correctly won the tie update scatterpolargl hover expectations to match scatterpolar 36c7508 the default pointer position is inside two same size markers of one trace scatterpolar gives the tie to the point drawn last point 26 and now scatterpolargl does too instead of picking the nearer center point 2 copilot ai balanced review requested due to automatic review settings november 11 2026 09 14 add draftlog for plotly 8170 3632735 copilot ai reviewed nov 11 2026 copilot ai left a comment copy link copy markdown there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota try requesting a review at a lower effort level an organization owner can choose the repository organization as the billing source for reviews requested by members with a paid copilot license learn about copilot code review billing review the copilot code review billing settings sorry something went wrong uh oh there was an error while loading please reload this page all reactions this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters sign up for free to join this conversation on github already have an account sign in to comment reviewers copilot code review copilot copilot review effort balanced adaptive preview copilot picks the effort for each pull request lite efficient review low cost balanced deep analysis moderate cost max preview most thorough high cost applies to this pull request for everyone learn more about copilot code review copilot left review comments at least 1 approving review is required to merge this pull request uh oh there was an error while loading please reload this page assignees no one assigned labels none yet projects none yet milestone no milestone development successfully merging this pull request may close these issues bug scattergl and splom hover ignores marker size for overlapping points uh oh there was an error while loading please reload this page 2 participants add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge suggestion cannot be applied right now please check back later footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
|