Meta tags:
description= CLI tool for Angular. Contribute to angular/angular-cli development by creating an account on GitHub.;
Headings (most frequently used words):
uh, oh, the, this, fix, angular, ssr, sep, 14, 2026, comment, navigation, glivter, pr, code, bot, choose, reason, for, hiding, resolve, request, path, through, router, url, grammar, before, matching, to, cli, route, matcher, what, is, behavior, footer, commented, loading, gemini, assist, 34091, menu, repository, 34091glivter, wants, merge, commit, intoangular, mainangular, mainfrom, divergenceglivter, divergencecopy, head, branch, name, clipboard, conversation, checklist, type, current, new, tests, does, introduce, breaking, change, other, information, review, edited, there, was, an, error, while, please, reload, page, google, cla, left, reviewers, assignees, labels, projects, milestone, development, participants,
Text of the page (most frequently used words):
the (128), and (55), this (42), #angular (42), route (29), path (25), router (24), that (21), page (21), with (21), ssr (20), for (20), #comment (17), pathname (17), serializer (17), request (16), while (15), from (14), code (14), was (14), github (13), 2026 (12), one (12), there (12), fix (12), copy (12), applied (11), reload (11), glivter (11), before (11), all (11), which (10), can (9), cannot (9), please (9), pull (9), change (9), loading (9), divergence (9), reason (9), check (8), error (8), review (8), bot (8), more (8), than (8), matcher (8), are (8), through (8), serialized (8), suggestion (7), suggestions (7), because (7), still (7), characters (7), match (7), metacharacters (7), url (7), sep (7), fast (7), your (7), home (7), you (6), not (6), status (6), gemini (6), assist (6), sign (6), learn (6), grammar (6), defaulturlserializer (6), against (6), rendermode (6), matrix (6), parse (6), 33555 (6), quality (6), choose (6), hiding (6), return (6), queryorfragment (6), string (6), includes (6), cli (6), security (5), commit (5), only (5), were (5), whose (5), what (5), open (5), matching (5), serverrouter (5), resolve (5), selects (5), another (5), client (5), server (5), same (5), parameters (5), rather (5), measured (5), reactions (5), sorry (5), something (5), went (5), wrong (5), tests (5), every (5), markdown (5), link (5), serialize (5), main (5), features (5), merge (4), been (4), resolved (4), outdated (4), add (4), single (4), per (4), changes (4), closed (4), may (4), requested (4), alan (4), agius4 (4), already (4), have (4), added (4), branch (4), input (4), two (4), disagree (4), response (4), headers (4), into (4), body (4), character (4), comes (4), catch (4), rendered (4), stripmatrixparams (4), covers (4), its (4), exactly (4), paths (4), would (4), 2fb (4), bug (4), duplicate (4), will (4), const (4), url_serializer (4), normalizeurlpath (4), packages (4), side (4), test (4), build (4), fixes (4), 34091 (4), support (4), copilot (4), action (3), information (3), navigation (3), now (3), line (3), reviews (3), existing (3), batch (3), these (3), awaiting (3), reviewer (3), conversation (3), hidden (3), unicode (3), about (3), 018fcbe (3), pushed (3), tokenises (3), unparseable (3), resolves (3), cache (3), under (3), policy (3), where (3), parentheses (3), own (3), next (3), returned (3), unchanged (3), encoding (3), behaviour (3), normalisation (3), today (3), rewrites (3), across (3), first (3), over (3), 583 (3), probes (3), disagrees (3), them (3), matchers (3), out (3), hide (3), low (3), off (3), topic (3), abuse (3), spam (3), displayed (3), describe (3), others (3), problem (3), search (3), query (3), like (3), view (3), cla (3), google (3), name (3), tab (3), window (3), refresh (3), session (3), developers (3), changelog (3), customer (3), enterprise (3), grade (3), docs (2), community (2), footer (2), comments (2), has (2), lines (2), made (2), issues (2), development (2), milestone (2), none (2), projects (2), area (2), least (2), reviewers (2), left (2), file (2), bidirectional (2), label (2), september (2), compare (2), 6d6decb (2), force (2), splitting (2), parses (2), silently (2), discarded (2), verified (2), preload (2), component (2), renders (2), appending (2), produces (2), configuration (2), control (2), store (2), private (2), plus (2), frame (2), options (2), deny (2), served (2), neither (2), header (2), declared (2), fixed (2), surfaced (2), urls (2), failing (2), their (2), handled (2), case (2), interior (2), remaining (2), ones (2), class (2), symptom (2), peer (2), dependency (2), package (2), malformed (2), percent (2), keeps (2), runs (2), stripped (2), leave (2), skip (2), allowlist (2), never (2), printable (2), ascii (2), range (2), denylist (2), inputs (2), nobody (2), thought (2), enumerate (2), 85c18b4 (2), 34090 (2), front (2), real (2), parser (2), set (2), other (2), slice (2), reproduces (2), fragment (2), matched (2), try (2), function (2), export (2), avoid (2), performance (2), overhead (2), parsing (2), serializing (2), requests (2), standard (2), utils (2), reviewed (2), checks (2), source (2), commented (2), value (2), new (2), published (2), confirmed (2), fail (2), team (2), favour (2), tree (2), use (2), does (2), expected (2), both (2), end (2), user (2), preserved (2), application (2), issue (2), behavior (2), documented (2), outlet (2), syntax (2), message (2), wants (2), head (2), clipboard (2), insights (2), actions (2), 196 (2), repository (2), signed (2), universe (2), training (2), integrations (2), stories (2), center (2), documentation (2), business (2), products (2), secret (2), perform, time, share, personal, manage, cookies, contact, privacy, terms, inc, right, back, later, queued, multi, pending, marked, must, order, create, valid, applying, deleted, supported, viewing, subset, invalid, participants, successfully, merging, close, yet, labels, assigned, assignees, approvals, affect, requirements, account, join, free, show, contains, text, interpreted, compiled, differently, appears, below, editor, reveals, self, october, oct, therefore, given, normalising, alone, matter, rejected, among, apart, closes, come, different, confusion, expose, data, public, referenced, ecc6313, pinning, normalised, here, shape, fixing, cheap, standing, disagreeing, empty, segment, anything, unrecognised, takes, slow, full, space, 20b, 2bb, bailing, skips, taken, suggested, conservative, enough, author, incoming, common, hot, since, vast, majority, without, any, immediately, present, avoids, invoking, relatively, expensive, unnecessarily, 272, 262, src, thread, introduces, normalization, using, ensures, correctly, aligns, handling, semicolons, double, slashes, feedback, suggests, optimizing, contain, robot, most, date, section, bottom, failed, invocation, thanks, looks, contribution, project, look, need, contributor, license, agreement, reaction, reacted, eyes, emoji, testing, produced, assistance, equivalence, table, asserted, executed, reasoned, also, reported, via, oss, vrp, 559764571, hunter, triaged, invited, disclose, publicly, originally, filed, turned, additional, coverage, prior, art, sweep, missed, searched, vocabulary, tokenisation, words, reporter, credit, catching, skyzerozx, limited, currently, agrees, actually, yes, introduce, breaking, green, 257, specs, undefined, equal, object, failure, reproducing, defect, selection, select, metadata, unknown, matches, nothing, 123, routes, router_spec, directly, divergent, spellings, ordinary, including, assumed, url_spec, supplies, custom, diverges, normalises, durable, injects, larger, happy, take, direction, instead, internal, patch, progress, matters, urlserializer, known, residual, stated, preserves, they, going, tokenising, agree, intentional, secondary, parameter, deliberately, unnamed, group, mean, primary, 64507, seg, configured, number, current, bugfix, type, updated, follows, our, guidelines, checklist, edited, files, changed, commits, items, dismiss, alert, switched, accounts, appearance, settings, pricing, event, talks, workshops, partners, company, forum, events, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, why, evaluate, see, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, enterprises, stage, businesses, latest, improvements, place, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, environments, codespaces, analysis, enforcement, automation, ship, coding, agent, tasks, automated, work, hosting, collaboration, platform, menu, content,
Text of the page (random words):
lopers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message angular angular cli repository navigation code issues 196 196 pull requests 20 20 actions security and quality 8 8 insights more items fix angular ssr resolve the request path through the router s url grammar before matching 34091 34091 open glivter wants to merge 1 commit into angular main angular angular cli main from glivter fix ssr route matcher divergence glivter angular cli fix ssr route matcher divergence copy head branch name to clipboard conversation commits 1 1 checks files changed open fix angular ssr resolve the request path through the router s url grammar before matching 34091 glivter wants to merge 1 commit into angular main angular angular cli main from glivter fix ssr route matcher divergence glivter angular cli fix ssr route matcher divergence copy head branch name to clipboard conversation glivter commented sep 14 2026 edited loading uh oh there was an error while loading please reload this page copy link copy markdown pr checklist the commit message follows our guidelines tests for the changes have been added for bug fixes features docs have been added updated for bug fixes features pr type bugfix what is the current behavior issue number 33555 serverrouter match tokenises the pathname by splitting on while angular router parses it with defaulturlserializer a grammar in which and are metacharacters and unparseable input is silently discarded the two disagree on which route a request is verified against the published angular router 22 1 6 serialize parse x input router resolves to page page page page page page page page a 1 b a 1 because serverrouter match selects the response s headers status rendermode and preload while angular router selects the component that renders into the body appending one character to a path produces a response whose body comes from one route and whose per route configuration comes from another a route configured with cache control no store private and x frame options deny is served under the catch all s policy with neither header and a route declared rendermode client is server rendered the angular router side is intentional name seg is the documented secondary outlet syntax k v the documented matrix parameter syntax and angular angular 64507 deliberately made an unnamed group mean the primary outlet what is the new behavior serverrouter match resolves the pathname through the router s own serializer before tokenising it so both matchers agree on which route a request is this is the same divergence that 85c18b4 fixed for matrix parameters where it surfaced as urls failing to match their route stripmatrixparams handled that case parentheses and interior are the remaining ones going through the serializer covers the class rather than the next symptom and angular router is already a peer dependency of this package normalisation runs before stripmatrixparams because the serializer preserves matrix parameters so they are still stripped exactly as today a path the serializer cannot parse is returned unchanged so malformed percent encoding keeps its existing behaviour known residual stated up front an application that supplies a custom urlserializer still diverges because this normalises with defaulturlserializer the durable fix is to build and query the route tree through the serializer the application injects which is a larger change i am happy to take this in that direction instead or to have this closed in favour of an internal patch if one is already in progress the issue matters more than the pr tests packages angular ssr test utils url_spec ts covers normalizeurlpath directly the divergent spellings an unchanged ordinary path preserved encoding including 2f preserved matrix parameters and an unparseable path returned as is every expected value was measured against angular router 22 1 6 rather than assumed packages angular ssr test routes router_spec ts covers the end to end selection home home home and home select the same route metadata as home user 123 x selects user and an unknown route still matches nothing both were confirmed to fail against main before the change with the failure reproducing the real defect home expected undefined to equal object route home rendermode 0 packages angular ssr test test is green with the change 257 specs does this pr introduce a breaking change yes no every path that does not use the router s metacharacters tokenises exactly as before the behaviour change is limited to paths where the two matchers currently disagree and there the server now agrees with what is actually rendered other information originally filed as 34090 which turned out to be a duplicate of 33555 and has been closed in its favour the additional coverage from it is now a comment on 33555 my prior art sweep missed 33555 because i searched my own vocabulary route tree tokenisation and matcher divergence rather than the words a reporter would use credit to skyzerozx for catching it also reported via the google oss vrp as 559764571 which the bug hunter team triaged and invited me to disclose publicly this change and its testing were produced with ai assistance the equivalence table and every value asserted in the new tests were executed against the published angular router 22 1 6 rather than reasoned about and the tests were confirmed to fail before the fix sorry something went wrong uh oh there was an error while loading please reload this page 1 gemini code assist bot reacted with eyes emoji all reactions 1 reaction google cla bot commented sep 14 2026 copy link copy markdown thanks for your pull request it looks like this may be your first contribution to a google open source project before we can look at your pull request you ll need to sign a contributor license agreement cla view this failed invocation of the cla check for more information for the most up to date status view the checks section at the bottom of the pull request all reactions sorry something went wrong uh oh there was an error while loading please reload this page angular robot bot added the area angular ssr label sep 14 2026 gemini code assist bot reviewed sep 14 2026 view reviewed changes gemini code assist bot left a comment copy link copy markdown there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment code review this pull request introduces url path normalization in the angular ssr server router using the client side defaulturlserializer this ensures that server side route matching correctly aligns with the client side router s handling of metacharacters like parentheses semicolons and double slashes the feedback suggests optimizing normalizeurlpath with a fast path check to avoid the performance overhead of parsing and serializing standard paths that do not contain these metacharacters sorry something went wrong uh oh there was an error while loading please reload this page all reactions comment thread packages angular ssr src utils url ts comment on lines 262 to 272 export function normalizeurlpath pathname string string try const serialized url_serializer serialize url_serializer parse pathname serialize reproduces the query string and fragment only the path is matched const queryorfragment serialized search return queryorfragment 1 serialized serialized slice 0 queryorfragment catch return pathname gemini code assist bot sep 14 2026 copy link copy markdown there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment to avoid the performance overhead of parsing and serializing every single incoming request url path which is a common hot path in ssr we can add a fast path check since the vast majority of requests will be standard paths without any router metacharacters like or we can return the pathname immediately if none of these characters are present this avoids invoking the relatively expensive defaulturlserializer parser and serializer unnecessarily export function normalizeurlpath pathname string string if pathname includes pathname includes pathname includes pathname includes pathname includes pathname includes return pathname try const serialized url_serializer serialize url_serializer parse pathname serialize reproduces the query string and fragment only the path is matched const queryorfragment serialized search return queryorfragment 1 serialized serialized slice 0 queryorfragment catch return pathname sorry something went wrong uh oh there was an error while loading please reload this page all reactions glivter sep 14 2026 copy link copy markdown author there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment taken with one change to the character set because i measured the suggested one first and it is not conservative enough bailing out only on and skips normalisation for every other input defaulturlserializer rewrites over 583 probes across the printable ascii range against angular router 22 1 6 that check disagrees with the serializer on 87 of them a b fast path a b serializer a 20b a b fast path a b serializer a 2bb 41 fast path 41 serializer a a 2fb fast path a 2fb serializer a 2fb the full set of characters that can change a path is space and a denylist here would be the same shape as the bug this pr is fixing a cheap character check standing in front of a real parser and disagreeing with it on the inputs nobody thought to enumerate so the fast path is an allowlist of the characters the serializer never rewrites plus a check for an empty segment and anything unrecognised takes the slow path measured over the same 583 probes it disagrees with the serializer on 0 pushed in 018fcbe with tests pinning that a b a b 41 and a 2fb are still normalised sorry something went wrong uh oh there was an error while loading please reload this page all reactions glivter force pushed the fix ssr route matcher divergence branch from ecc6313 to 018fcbe compare september 14 2026 20 57 this was referenced sep 14 2026 angular ssr route policy confusion can expose client only data under public cache headers 33555 open angular ssr the route matcher and angular router disagree so per route headers status and rendermode come from a different route than the one rendered 34090 closed fix angular ssr resolve the request path through the router s url 6d6decb grammar before matching serverrouter match tokenises the pathname by splitting on while angular router parses it with defaulturlserializer a grammar in which and are metacharacters and unparseable input is silently discarded the two therefore disagree on which route a request is verified against angular router 22 1 6 page page page and page all resolve to page and a 1 b resolves to a 1 because serverrouter match selects the response s headers status rendermode and preload while angular router selects the component that renders into the body appending a single character to a path produces a response whose body comes from one route and whose per route configuration comes from another a route given cache control no store private plus x frame options deny is served under the catch all s policy with neither header and a route declared rendermode client is server rendered this is the same divergence that 85c18b4 fixed for matrix parameters where it surfaced as urls failing to match their route stripmatrixparams handled that case parentheses and interior are the remaining ones normalising through the router s own serializer covers the class rather than the next symptom and angular router is already a peer dependency of this package a path the serializer cannot parse is returned unchanged so malformed percent encoding keeps its existing behaviour and normalisation runs before stripmatrixparams so matrix parameters are still stripped exactly as today paths the serializer would leave alone skip the parse that check is an allowlist of the characters it never rewrites measured across the printable ascii range a denylist of the metacharacters that matter today was measured first and rejected over 583 probes it disagrees with the serializer on 87 of them a b a b and 41 among them which would leave the two matchers apart on exactly the inputs nobody thought to enumerate closes angular 33555 glivter force pushed the fix ssr route matcher divergence branch from 018fcbe to 6d6decb compare september 14 2026 21 48 alan agius4 added the action review the pr is still awaiting reviews from at least one requested reviewer label oct 30 2026 alan agius4 self requested a review october 30 2026 14 54 this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters sign up for free to join this conversation on github already have an account sign in to comment reviewers alan agius4 awaiting requested review from alan agius4 1 more reviewer gemini code assist bot gemini code assist bot left review comments reviewers whose approvals may not affect merge requirements uh oh there was an error while loading please reload this page assignees no one assigned labels action review the pr is still awaiting reviews from at least one requested reviewer area angular ssr projects none yet milestone no milestone development successfully merging this pull request may close these issues uh oh there was an error while loading please reload this page 2 participants add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be...
|