If you are not sure if the website you would like to visit is secure, you can verify it here. Enter the website address of the page and see parts of its content and the thumbnail images on this site. None (if any) dangerous scripts on the referenced page will be executed. Additionally, if the selected site contains subpages, you can verify it (review) in batches containing 5 pages.
favicon.ico: github.com/angular/angular-cli/pull/34602/files - fix(@schematics/angular): cast.

site address: github.com/angular/angular-cli/pull/34602/files redirected to: github.com/angular/angular-cli/pull/34602/files

site title: fix(@schematics/angular): cast createSpyObj to MockedObject for jasmine.SpyObj variables in refactor-jasmine-vitest by thekhegay · Pull Request #34602 · angular/angular-cli · GitHub

Our opinion (on Wednesday 18 November 2026 23:27:38 UTC):

GREEN status (no comments) - no comments
After content analysis of this website we propose the following hashtags:



Meta tags:
description=PR Checklist The commit message follows our guidelines: htt????/github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes Other... Please describe: What is the current behavior? Issue Number: N/A Pattern from Angular testing guide let heroServiceSpy: jasmine.SpyObj HeroService ; beforeEach(() = heroServiceSpy = jasmine.createSpyObj( HeroService , [ getHeroes ]); ); is migrated to MockedObject HeroService variable and object literal with only getHeroes. Jasmine createSpyObj returns any so it compiled before, after migration tsc fails with error TS2322: Type getHeroes: Mock Procedure ; is not assignable to type MockedObject HeroService . File is reported as transformed and there is no TODO What is the new behavior? When createSpyObj initializes or is assigned to variable annotated with jasmine.SpyObj T , literal is cast as MockedObject T and type import is added. Declaration is looked up in nearest enclosing block, so svc declared in two describe blocks gets its own type in each. Migrated spec from above passes tsc --strict (TS 6.0, vitest 5.0) New spec cases cover assignment, initializer and two describe blocks with same name, they fail on main Does this PR introduce a breaking change? Yes No Other information Cast types members that were not spied as present, same as jasmine.SpyObj T with untyped createSpyObj did before migration. Other option is TODO without cast, I went with cast since it keeps migrated tests compiling;

Headings (most frequently used words):

uh, oh, jasmine, to, for, navigation, fix, schematics, angular, cast, createspyobj, mockedobject, spyobj, variables, in, refactor, vitest, 34602, are, footer, you, diff, view, menu, repository, there, no, files, selected, viewing, sure, want, change, the, base, filter, by, extension,

Text of the page (most frequently used words):
#jasmine (51), myservice (43), mockedobject (32), the (27), createspyobj (25), type (24), parent (23), file (19), spyobj (19), github (16), methoda (16), and (16), angular (16), for (16), this (15), const (15), vitest (15), cast (14), return (14), undefined (13), that (12), from (12), let (12), applied (11), loading (11), schematics (11), reload (10), you (9), while (9), line (9), node (9), not (8), all (8), mockname (8), svc (8), import (8), show (8), refactor (8), suggestion (7), cannot (7), suggestions (7), code (7), input (7), description (7), should (7), bar (7), describe (7), foo (7), variable (7), open (7), current (7), thekhegay (7), sign (7), please (6), changes (6), there (6), expand (6), expected (6), diff (6), hidden (6), characters (6), unicode (6), text (6), fix (6), commits (6), security (5), comments (5), change (5), was (5), error (5), page (5), with (5), other (5), packages (5), transformers (5), function (5), spy (5), name (5), typearguments (5), base (5), your (5), can (4), 2026 (4), pull (4), add (4), methodb (4), beforeeach (4), any (4), call (4), number (4), bidirectional (4), may (4), review (4), learn (4), about (4), view (4), getspyobjtypearguments (4), left (4), declaration (4), statement (4), another (4), typename (4), factory (4), spyobjliteral (4), files (4), load (4), support (4), copilot (4), community (3), navigation (3), request (3), resolved (3), batch (3), commit (3), retry (3), down (3), already (3), when (3), assigned (3), original (3), compiled (3), what (3), more (3), spy_spec (3), 112 (3), isidentifier (3), typenode (3), spyobjtypearguments (3), hide (3), whitespace (3), filter (3), 34602 (3), variables (3), branch (3), refname (3), account (3), quality (3), tab (3), window (3), refresh (3), session (3), developers (3), changelog (3), customer (3), enterprise (3), grade (3), features (3), build (3), contact (2), status (2), privacy (2), terms (2), footer (2), right (2), merge (2), has (2), marked (2), outdated (2), existing (2), single (2), only (2), one (2), viewing (2), toggle (2), block (2), initializes (2), transformcreatespyobj (2), 187 (2), 118 (2), service (2), contains (2), interpreted (2), differently (2), than (2), appears (2), below (2), editor (2), reveals (2), desktop (2), delete (2), edit (2), additions (2), findenclosingvariabledeclaration (2), nodearray (2), getassignedspyobjtypearguments (2), finds (2), annotation (2), continue (2), conversation (2), member (2), addvitesttypeimport (2), ctx (2), why (2), literal (2), its (2), createobjectliteralexpression (2), properties (2), true (2), 114 (2), are (2), selected (2), apply (2), split (2), unified (2), failed (2), jump (2), extension (2), fixup (2), oct (2), select (2), tree (2), old (2), default (2), could (2), tags (2), branches (2), main (2), issue (2), insights (2), actions (2), 196 (2), repository (2), cli (2), signed (2), universe (2), training (2), integrations (2), stories (2), center (2), documentation (2), business (2), fixes (2), products (2), secret (2), perform, action, time, share, personal, information, manage, cookies, docs, inc, now, check, back, later, queued, multi, pending, reviews, been, must, order, create, valid, applying, deleted, lines, supported, per, subset, closed, invalid, because, were, made, annotations, notes, oops, something, went, wrong, transform, array, methods, enclosing, second, explicit, argument, union, testcases, spyon, mymethod, unknownstrategy, deletions, createspyobjwitharray, operatortoken, kind, syntaxkind, equalstoken, isbinaryexpression, isvariabledeclaration, outside, parentheses, given, declarationlist, declarations, find, isvariablestatement, statements, isblock, issourcefile, variabledeclaration, string, declared, same, used, blocks, enclose, nearest, first, isqualifiedname, comment, thread, istypereferencenode, types, isuniontypenode, under, strictnullchecks, createtypereferencenode, createasexpression, pendingvitesttypeimports, returns, which, assignment, transformed, untyped, spied, members, assignable, isasexpression, istypeassertionexpression, gives, isparenthesizedexpression, 459, 460, export, refactorcontext, getpromiseresolverejectmethod, createpropertyaccess, addvitestvalueimport, typescript, 113, deletion, conversations, clear, filters, viewed, nbsp, nov, 89e35f4, befdb9c, jasmi, 991f480, hold, shift, click, range, changed, checks, wants, into, some, removed, timeline, become, sure, want, nothing, found, choose, clicking, agree, our, occasionally, send, related, emails, free, maintainers, have, question, project, new, items, requests, issues, message, dismiss, alert, switched, accounts, out, appearance, settings, search, pricing, event, talks, workshops, next, partners, company, forum, events, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, evaluate, see, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, source, latest, improvements, across, place, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, development, environments, codespaces, analysis, enforcement, automation, ship, coding, agent, tasks, projects, automated, work, hosting, collaboration, platform, menu, skip, content,


Text of the page (random words):
fix schematics angular cast createspyobj to mockedobject for jasmine spyobj variables in refactor jasmine vitest by thekhegay pull request 34602 angular angular cli github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message angular angular cli repository navigation code issues 196 196 pull requests 20 20 actions security and quality 8 8 insights more items fix schematics angular cast createspyobj to mockedobject for jasmine spyobj variables in refactor jasmine vitest 34602 new issue have a question about this project sign up for a free github account to open an issue and contact its maintainers and the community sign up for github by clicking sign up for github you agree to our terms of service and privacy statement we ll occasionally send you account related emails already on github sign in to your account open thekhegay wants to merge 3 commits into angular main base main choose a base branch branches tags could not load branches branch not found refname loading refname default could not load tags nothing to show refname default loading are you sure you want to change the base some commits from the old base branch may be removed from the timeline and old review comments may become outdated loading change base from thekhegay jasmine vitest createspyobj type conversation 8 commits 3 checks 10 files changed uh oh there was an error while loading please reload this page open fix schematics angular cast createspyobj to mockedobject for jasmine spyobj variables in refactor jasmine vitest 34602 show file tree hide file tree changes from all commits commits show all changes 3 commits select commit hold shift click to select a range 991f480 fix schematics angular cast createspyobj to mockedobject for jasmi thekhegay oct 30 2026 befdb9c fixup fix schematics angular cast createspyobj to mockedobject fo thekhegay oct 30 2026 89e35f4 fixup fix schematics angular cast createspyobj to mockedobject fo thekhegay nov 3 2026 file filter filter by extension filter by extension ts nbsp 2 all 1 file type selected viewed files clear filters conversations failed to load comments retry loading uh oh there was an error while loading please reload this page jump to jump to file failed to load files retry loading uh oh there was an error while loading please reload this page diff view unified split hide whitespace apply and reload show whitespace diff view unified split hide whitespace apply and reload packages schematics angular refactor jasmine vitest transformers packages schematics angular refactor jasmine vitest transformers jasmine spy ts jasmine spy ts packages schematics angular refactor jasmine vitest transformers jasmine spy_spec ts jasmine spy_spec ts there are no files selected for viewing 114 changes 113 additions 1 deletion 114 packages schematics angular refactor jasmine vitest transformers jasmine spy ts show comments view file edit file delete file open in desktop this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters original file line number diff line number diff line change expand up 16 6 16 7 import ts from typescript import addvitesttypeimport addvitestvalueimport createpropertyaccess getpromiseresolverejectmethod expand down expand up 459 7 460 118 export function transformcreatespyobj node ts node ctx refactorcontext ts n return ts factory createobjectliteralexpression properties true const spyobjliteral ts factory createobjectliteralexpression properties true let parent node parent while parent ts isparenthesizedexpression parent parent parent parent an existing cast on the call already gives the literal its type if parent ts isasexpression parent ts istypeassertionexpression parent return spyobjliteral the literal only has the spied members so it is not assignable to the mockedobject t that a jasmine spyobj t annotation is transformed to jasmine s untyped createspyobj returns any which is why the original assignment compiled const spyobjtypearguments node typearguments getassignedspyobjtypearguments parent if spyobjtypearguments return spyobjliteral addvitesttypeimport ctx pendingvitesttypeimports mockedobject return ts factory createasexpression spyobjliteral ts factory createtypereferencenode mockedobject spyobjtypearguments function getspyobjtypearguments type ts typenode undefined ts nodearray ts typenode undefined jasmine spyobj t undefined under strictnullchecks if type ts isuniontypenode type for const member of type types const typearguments getspyobjtypearguments member if typearguments return typearguments return undefined if type ts istypereferencenode type comment thread thekhegay marked this conversation as resolved resolved uh oh there was an error while loading please reload this page ts isqualifiedname type typename ts isidentifier type typename left type typename left text jasmine type typename right text spyobj return type typearguments return undefined finds the declaration of a variable in the blocks that enclose a node nearest first so that a variable declared in another describe block with the same name is not used function findenclosingvariabledeclaration node ts node name string ts variabledeclaration undefined for let current node parent current current current parent if ts isblock current ts issourcefile current continue for const statement of current statements if ts isvariablestatement statement continue const declaration statement declarationlist declarations find d ts isidentifier d name d name text name if declaration return declaration return undefined finds the t of a jasmine spyobj t annotation on the variable that a createspyobj call initializes const spy jasmine spyobj t or is assigned to spy given the call s parent outside any parentheses function getassignedspyobjtypearguments parent ts node undefined ts nodearray ts typenode undefined if parent return undefined if ts isvariabledeclaration parent return getspyobjtypearguments parent type if ts isbinaryexpression parent parent operatortoken kind ts syntaxkind equalstoken ts isidentifier parent left return undefined return getspyobjtypearguments findenclosingvariabledeclaration parent parent left text type function createspyobjwitharray expand down 112 changes 112 additions 0 deletions 112 packages schematics angular refactor jasmine vitest transformers jasmine spy_spec ts show comments view file edit file delete file open in desktop this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters original file line number diff line number diff line change expand up 187 6 187 118 vi spyon service mymethod and unknownstrategy describe transformcreatespyobj const testcases description should cast jasmine createspyobj to mockedobject when assigned to a jasmine spyobj variable input let myservice jasmine spyobj myservice myservice jasmine createspyobj myservice methoda expected import type mockedobject from vitest let myservice mockedobject myservice myservice methoda vi fn mockname myservice methoda as mockedobject myservice description should cast jasmine createspyobj to mockedobject when it initializes a jasmine spyobj variable input const myservice jasmine spyobj myservice jasmine createspyobj myservice methoda expected import type mockedobject from vitest const myservice mockedobject myservice methoda vi fn mockname myservice methoda as mockedobject myservice description should cast jasmine createspyobj to mockedobject when assigned to a jasmine spyobj union variable input let myservice jasmine spyobj myservice undefined myservice jasmine createspyobj myservice methoda expected import type mockedobject from vitest let myservice mockedobject myservice undefined myservice methoda vi fn mockname myservice methoda as mockedobject myservice description should cast jasmine createspyobj with an explicit type argument to mockedobject input const myservice jasmine createspyobj myservice myservice methoda expected import type mockedobject from vitest const myservice methoda vi fn mockname myservice methoda as mockedobject myservice description should not add a second cast to a jasmine createspyobj call that is already cast input let myservice jasmine spyobj myservice myservice jasmine createspyobj myservice methoda as jasmine spyobj myservice const other jasmine createspyobj other other methodb as any expected import type mockedobject from vitest let myservice mockedobject myservice myservice methoda vi fn mockname myservice methoda as mockedobject myservice const other methodb vi fn mockname other methodb as any description should cast jasmine createspyobj to the jasmine spyobj type of the variable in the enclosing describe block input describe foo let svc jasmine spyobj foo beforeeach svc jasmine createspyobj foo a describe bar let svc jasmine spyobj bar beforeeach svc jasmine createspyobj bar b expected import type mockedobject from vitest describe foo let svc mockedobject foo beforeeach svc a vi fn mockname foo a as mockedobject foo describe bar let svc mockedobject bar beforeeach svc b vi fn mockname bar b as mockedobject bar description should transform jasmine createspyobj with an array of methods input const myservice jasmine createspyobj myservice methoda methodb expand down loading oops something went wrong retry uh oh there was an error while loading please reload this page toggle all file notes toggle all file annotations add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge suggestion cannot be applied right now please check back later footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
Thumbnail images (randomly selected): * Images may be subject to copyright.GREEN status (no comments)
  • Unified Diff View
  • Split Diff View

Verified site has: 60 subpage(s). Do you want to verify them? Verify pages:

1-5 6-10 11-15 16-20 21-25 26-30 31-35 36-40 41-45 46-50
51-55 56-60


Top 50 hastags from of all verified websites.

Supplementary Information (add-on for SEO geeks)*- See more on header.verify-www.com

Header

HTTP/1.1 301 Moved Permanently
Content-Length 0
Location htt????/github.com/angular/angular-cli/pull/34602/files
connection close
HTTP/2 200
date Wed, 18 Nov 2026 23:27:37 GMT
content-type text/html; charset=utf-8
vary X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With, X-GitHub-Client-Version, Sec-Fetch-Site,Accept-Encoding, Accept, X-Requested-With
cache-control no-cache
etag W/ 13a54c0f475c5cc090f30afcecdcf526
strict-transport-security max-age=31536000; includeSubdomains; preload
x-frame-options deny
x-content-type-options nosniff
x-xss-protection 0
referrer-policy no-referrer-when-downgrade
content-security-policy default-src none ; base-uri self ; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src self uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net productionresultssa1.blob.core.windows.net productionresultssa2.blob.core.windows.net productionresultssa3.blob.core.windows.net productionresultssa4.blob.core.windows.net productionresultssa5.blob.core.windows.net productionresultssa6.blob.core.windows.net productionresultssa7.blob.core.windows.net productionresultssa8.blob.core.windows.net productionresultssa9.blob.core.windows.net productionresultssa10.blob.core.windows.net productionresultssa11.blob.core.windows.net productionresultssa12.blob.core.windows.net productionresultssa13.blob.core.windows.net productionresultssa14.blob.core.windows.net productionresultssa15.blob.core.windows.net productionresultssa16.blob.core.windows.net productionresultssa17.blob.core.windows.net productionresultssa18.blob.core.windows.net productionresultssa19.blob.core.windows.net productionresultssa30.blob.core.windows.net productionresultssa31.blob.core.windows.net productionresultssa32.blob.core.windows.net github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com wss://*.wps.githubcopilot.com wss://production-copilot-host.webpubsub.azure.com wss://production-copilot-host-centralus.webpubsub.azure.com wss://production-copilot-host-centralus-02.webpubsub.azure.com wss://production-copilot-host-westus.webpubsub.azure.com wss://production-copilot-host-westus3.webpubsub.azure.com wss://production-copilot-host-eastasia.webpubsub.azure.com wss://production-copilot-host-austriaeast.webpubsub.azure.com api.github.com/cmc_internal/api/; font-src github.githubassets.com; form-action self github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors none ; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src self data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com user-images.githubusercontent.com private-user-images.githubusercontent.com opengraph.githubassets.com repository-images.githubusercontent.com marketplace-screenshots.githubusercontent.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com explore-feed.github.com *.googleusercontent.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src self ; media-src github.com user-images.githubusercontent.com secured-user-images.githubusercontent.com private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com sha256-6nkh0w49y4npXaU0CPIq0z+XDtPnpaDFECgj6Y9vmx4= ; style-src unsafe-inline github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
server github.com
content-encoding gzip
accept-ranges bytes
set-cookie _gh_sess=kdVJM3pUy9m1ySPGamrOVd1jVTDK1rWkq6E2F3Du9R%2BgrakYLJWahhDvfqB%2FpeXqd5%2B6C9R3tsTbjO3HPn61UMbeu2kpdCOCJoHfhdZgBkpjfYYpZsEAZ1XR4rD4a8G83t4CW6l1tC%2FtvFBilnP2itGmT6J9lsxWvM%2BxknHCT25jj%2BOM%2Bpeo35Cdax76Vf0NbYNh2%2B81sttsPQeJ7M5vKm0sJ1qW%2FmeE9EgTjVd2KVSvvU45Ur5HFK%2Fwi36c57GcOM8qv61hgXkU6gbXwaJRlA%3D%3D--vwfBHCNtAbtP12xS--iuyyA1lRv8Ba3mNQNNxmPw%3D%3D; path=/; HttpOnly; secure; SameSite=Lax
set-cookie _octo=GH1.1.1517735615.1795044456; expires=Thu, 18 Nov 2027 23:27:36 GMT; domain=.github.com; path=/; secure; SameSite=Lax
set-cookie logged_in=no; expires=Thu, 18 Nov 2027 23:27:36 GMT; domain=.github.com; path=/; HttpOnly; secure; SameSite=Lax
x-github-request-id BE4A:35C0F7:1F5BC0C:2D38FD3:6AFE3468
x-github-edge-region fra

Meta Tags

title="fix(@schematics/angular): cast createSpyObj to MockedObject for jasmine.SpyObj variables in refactor-jasmine-vitest by thekhegay · Pull Request #34602 · angular/angular-cli · GitHub"
charset="utf-8"
name="react-profiling" content="0" data-turbo-transient="true"
name="react-import-map" content="react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322" data-turbo-track="reload"
name="route-pattern" content="/:user_id/:repository/pull/:id/files(.:format)" data-turbo-transient
name="route-controller" content="pull_requests" data-turbo-transient
name="route-action" content="files" data-turbo-transient
name="fetch-nonce" content="v2:4638d6b6-eaff-06f2-bd4f-8f1feed59800"
name="current-catalog-service-hash" content="ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b"
name="request-id" content="BE4A:35C0F7:1F5BC0C:2D38FD3:6AFE3468" data-pjax-transient="true"
name="html-safe-nonce" content="7226098129e3355e7e14bbdba4d89e5ea8c0994b2e24df75353a0f556271f603" data-pjax-transient="true"
name="visitor-payload" content="eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTRBOjM1QzBGNzoxRjVCQzBDOjJEMzhGRDM6NkFGRTM0NjgiLCJ2aXNpdG9yX2lkIjoiNjUxODYyNDgzMjE5NDQ5MTQ5NiIsInJlZ2lvbl9lZGdlIjoiZnJhIiwicmVnaW9uX3JlbmRlciI6ImZyYSJ9" data-pjax-transient="true"
name="visitor-hmac" content="e7b69a38203a5ce3f94801847d0345fd699b3ef6622f508bfe690a234f2f166a" data-pjax-transient="true"
name="hovercard-subject-tag" content="pull_request:5082612902" data-turbo-transient
name="github-keyboard-shortcuts" content="repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot" data-turbo-transient="true"
name="selected-link" value="repo_pulls" data-turbo-transient
name="google-site-verification" content="Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I"
name="octolytics-url" content="htt????/collector.github.com/github/collect"
name="analytics-location" content="/<user-name>/<repo-name>/pull_requests/show/files" data-turbo-transient="true"
name="user-login" content=""
name="viewport" content="width=device-width"
name="description" content="PR Checklist The commit message follows our guidelines: htt????/github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes Other... Please describe: What is the current behavior? Issue Number: N/A Pattern from Angular testing guide let heroServiceSpy: jasmine.SpyObj<HeroService>; beforeEach(() => { heroServiceSpy = jasmine.createSpyObj('HeroService', ['getHeroes']); }); is migrated to MockedObject<HeroService> variable and object literal with only getHeroes. Jasmine createSpyObj returns any so it compiled before, after migration tsc fails with error TS2322: Type '{ getHeroes: Mock<Procedure>; }' is not assignable to type 'MockedObject<HeroService>'. File is reported as transformed and there is no TODO What is the new behavior? When createSpyObj initializes or is assigned to variable annotated with jasmine.SpyObj<T>, literal is cast as MockedObject<T> and type import is added. Declaration is looked up in nearest enclosing block, so svc declared in two describe blocks gets its own type in each. Migrated spec from above passes tsc --strict (TS 6.0, vitest 5.0) New spec cases cover assignment, initializer and two describe blocks with same name, they fail on main Does this PR introduce a breaking change? Yes No Other information Cast types members that were not spied as present, same as jasmine.SpyObj<T> with untyped createSpyObj did before migration. Other option is TODO without cast, I went with cast since it keeps migrated tests compiling"
property="fb:app_id" content="1401488693436528"
name="apple-itunes-app" content="app-id=1477376905, app-argument=htt????/github.com/angular/angular-cli/pull/34602/files"
name="twitter:image" content="htt????/avatars.githubusercontent.com/u/5451538?s=400&v=4"
name="twitter:site" content="@github"
name="twitter:card" content="summary_large_image"
name="twitter:title" content="fix(@schematics/angular): cast createSpyObj to MockedObject for jasmine.SpyObj variables in refactor-jasmine-vitest by thekhegay · Pull Request #34602 · angular/angular-cli"
name="twitter:description" content="PR Checklist The commit message follows our guidelines: htt????/github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug..."
property="og:image" content="htt????/avatars.githubusercontent.com/u/5451538?s=400&v=4"
property="og:image:alt" content="PR Checklist The commit message follows our guidelines: htt????/github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug..."
property="og:site_name" content="GitHub"
property="og:type" content="object"
property="og:title" content="fix(@schematics/angular): cast createSpyObj to MockedObject for jasmine.SpyObj variables in refactor-jasmine-vitest by thekhegay · Pull Request #34602 · angular/angular-cli"
property="og:url" content="htt????/github.com/angular/angular-cli/pull/34602"
property="og:description" content="PR Checklist The commit message follows our guidelines: htt????/github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug..."
name="hostname" content="github.com"
name="expected-hostname" content="github.com"
http-equiv="x-pjax-version" content="7c91d74f3b8c0f06bd7d1b095630d22a58f1beca63f12272ec4dd5d589145cf2" data-turbo-track="reload"
http-equiv="x-pjax-csp-version" content="adddfd507de4c4b0b130ff1dbf3c31681ba97e7a45dc69da056946fc5370dfd4" data-turbo-track="reload"
http-equiv="x-pjax-css-version" content="da37a124316120c46a7ac5f1f3faf1b2eb992aa46a47bf3bb59d2c4f87142b79" data-turbo-track="reload"
http-equiv="x-pjax-js-version" content="d70e31220a67f6376c108d2416fa8e7df854c1065b1672ab7a88ab6dc3a809e2" data-turbo-track="reload"
name="turbo-cache-control" content="no-preview" data-turbo-transient=""
name="diff-view" content="unified" data-turbo-transient
name="go-import" content="github.com/angular/angular-cli git htt????/github.com/angular/angular-cli.git"
name="octolytics-dimension-user_id" content="139426"
name="octolytics-dimension-user_login" content="angular"
name="octolytics-dimension-repository_id" content="36891867"
name="octolytics-dimension-repository_nwo" content="angular/angular-cli"
name="octolytics-dimension-repository_public" content="true"
name="octolytics-dimension-repository_is_fork" content="false"
name="octolytics-dimension-repository_network_root_id" content="36891867"
name="octolytics-dimension-repository_network_root_nwo" content="angular/angular-cli"
name="robots" content="noindex, nofollow"
name="turbo-body-classes" content="logged-out env-production page-responsive full-width"
name="disable-turbo" content="true"
name="browser-stats-url" content="htt????/api.github.com/_private/browser/stats"
name="browser-errors-url" content="htt????/api.github.com/_private/browser/errors"
name="release" content="ccb88d9c92abe69245b429398c8a57ae87070c7c" data-turbo-track="reload"
name="ui-target" content="full"
name="theme-color" content="#1e2327"
name="color-scheme" content="light dark"

Load Info

page size63163
load time (s)1.391247
redirect count1
speed download45408
server IP 140.82.121.3
* all occurrences of the string "http://" have been changed to "htt???/"