Meta tags:
description= CLI tool for Angular. Contribute to angular/angular-cli development by creating an account on GitHub.;
Headings (most frequently used words):
uh, oh, fix, angular, for, negated, jasmine, vitest, comment, navigation, schematics, add, todo, expectasync, matchers, in, refactor, to, cli, meakib, expect, code, footer, left, choose, reason, hiding, this, 34619, menu, repository, 34619meakib, wants, merge, commits, intoangular, mainangular, mainfrom, asyncmeakib, asynccopy, head, branch, name, clipboard, conversation, review, commented, oct, 31, 2026, gemini, assist, bot, alan, agius4, reviewers, assignees, labels, projects, milestone, development, participants,
Text of the page (most frequently used words):
this (25), angular (24), comment (20), #vitest (19), the (18), jasmine (17), for (15), #negated (15), expectasync (14), github (13), code (13), applied (11), while (11), add (11), there (11), reload (11), schematics (11), todo (11), and (11), was (10), meakib (10), fix (10), matchers (10), not (9), please (9), refactor (9), async (9), 2026 (8), error (8), loading (8), page (8), review (8), copy (8), suggestion (7), cannot (7), suggestions (7), alan (7), agius4 (7), pull (6), from (6), resolved (6), changes (6), bot (6), left (6), all (6), reason (6), cli (6), you (5), that (5), security (5), request (5), gemini (5), assist (5), more (5), have (5), sign (5), learn (5), reviewed (5), quality (5), can (4), merge (4), requested (4), matcher (4), choose (4), hiding (4), expect (4), main (4), 34619 (4), your (4), support (4), copilot (4), navigation (3), line (3), comments (3), outdated (3), existing (3), batch (3), one (3), because (3), were (3), may (3), conversation (3), hidden (3), characters (3), unicode (3), open (3), packages (3), transformers (3), thread (3), view (3), reactions (3), sorry (3), something (3), went (3), wrong (3), markdown (3), link (3), such (3), toberesolved (3), equivalent (3), test (3), oct (3), with (3), commits (3), another (3), tab (3), window (3), refresh (3), session (3), developers (3), changelog (3), customer (3), enterprise (3), grade (3), features (3), build (3), community (2), status (2), footer (2), now (2), check (2), has (2), been (2), single (2), commit (2), these (2), issues (2), development (2), milestone (2), projects (2), area (2), reviewers (2), file (2), bidirectional (2), what (2), about (2), november (2), atchers (2), fixup (2), nov (2), hide (2), low (2), duplicate (2), off (2), topic (2), abuse (2), spam (2), will (2), displayed (2), describe (2), others (2), problem (2), tool (2), added (2), promise (2), unchanged (2), without (2), migrated (2), failed (2), runtime (2), does (2), exist (2), exact (2), unsupported (2), them (2), wants (2), into (2), head (2), branch (2), name (2), clipboard (2), insights (2), actions (2), 196 (2), repository (2), signed (2), universe (2), training (2), integrations (2), stories (2), center (2), documentation (2), business (2), fixes (2), products (2), secret (2), perform, action, time, share, personal, information, manage, cookies, contact, docs, privacy, terms, inc, right, back, later, queued, multi, pending, reviews, marked, must, change, order, create, valid, applying, deleted, lines, supported, only, per, viewing, subset, closed, invalid, made, participants, successfully, merging, close, none, yet, labels, assigned, assignees, whose, approvals, affect, requirements, reviewer, awaiting, already, account, join, free, show, contains, text, interpreted, compiled, differently, than, appears, below, editor, reveals, 96f96b9, matcher_spec, c40aefa, thanks, inline, regarding, deduplicating, handling, other, modifiers, transformexpectasync, collaborator, updates, refactoring, detect, during, transformations, since, direct, records, prompting, manual, migration, corresponding, unit, also, verify, behavior, are, additional, feedback, provide, label, robot, 4c69f0c, reaction, reacted, eyes, emoji, contributor, commented, files, changed, checks, items, requests, message, dismiss, alert, switched, accounts, out, appearance, settings, search, pricing, event, talks, workshops, next, partners, company, forum, events, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, why, evaluate, see, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, source, latest, improvements, across, place, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, environments, codespaces, analysis, enforcement, automation, ship, coding, agent, tasks, automated, work, hosting, collaboration, platform, menu, skip, content,
Text of the page (random words):
fix schematics angular add a todo for negated expectasync matchers in refactor jasmine vitest by meakib pull request 34619 angular angular cli github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message angular angular cli repository navigation code issues 196 196 pull requests 20 20 actions security and quality 8 8 insights more items fix schematics angular add a todo for negated expectasync matchers in refactor jasmine vitest 34619 34619 open meakib wants to merge 3 commits into angular main angular angular cli main from meakib fix jasmine vitest negated expect async meakib angular cli fix jasmine vitest negated expect async copy head branch name to clipboard conversation commits 3 3 checks files changed open fix schematics angular add a todo for negated expectasync matchers in refactor jasmine vitest 34619 meakib wants to merge 3 commits into angular main angular angular cli main from meakib fix jasmine vitest negated expect async meakib angular cli fix jasmine vitest negated expect async copy head branch name to clipboard conversation meakib commented oct 31 2026 copy link copy markdown contributor negated async matchers such as expectasync promise not toberesolved were left unchanged without a todo comment so the migrated test failed at runtime because expectasync does not exist in vitest negated async matchers have no exact vitest equivalent so add the existing unsupported expectasync matcher todo comment to them sorry something went wrong uh oh there was an error while loading please reload this page 1 gemini code assist bot reacted with eyes emoji all reactions 1 reaction fix schematics angular add a todo for negated expectasync matchers 4c69f0c in refactor jasmine vitest negated async matchers such as expectasync promise not toberesolved were left unchanged without a todo comment so the migrated test failed at runtime because expectasync does not exist in vitest negated async matchers have no exact vitest equivalent so add the existing unsupported expectasync matcher todo comment to them angular robot bot added the area schematics angular label oct 31 2026 gemini code assist bot reviewed oct 31 2026 view reviewed changes gemini code assist bot left a comment copy link copy markdown there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment code review this pull request updates the jasmine to vitest refactoring tool to detect negated async matchers such as not toberesolved during expectasync transformations since these matchers do not have a direct equivalent in vitest the tool now records a todo comment prompting manual migration a corresponding unit test has also been added to verify this behavior there are no review comments and i have no additional feedback to provide sorry something went wrong uh oh there was an error while loading please reload this page all reactions alan agius4 requested changes nov 3 2026 view reviewed changes alan agius4 left a comment copy link copy markdown collaborator there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment thanks for the pr i left an inline comment on transformexpectasync regarding deduplicating the check and handling other expectasync modifiers sorry something went wrong uh oh there was an error while loading please reload this page all reactions comment thread packages schematics angular refactor jasmine vitest transformers jasmine matcher ts resolved uh oh there was an error while loading please reload this page fixup fix schematics angular add a todo for negated expectasync m c40aefa atchers in refactor jasmine vitest meakib requested a review from alan agius4 november 3 2026 09 44 alan agius4 reviewed nov 4 2026 view reviewed changes comment thread packages schematics angular refactor jasmine vitest transformers jasmine matcher ts resolved uh oh there was an error while loading please reload this page comment thread packages schematics angular refactor jasmine vitest transformers jasmine matcher_spec ts resolved uh oh there was an error while loading please reload this page fixup fix schematics angular add a todo for negated expectasync m 96f96b9 atchers in refactor jasmine vitest meakib requested a review from alan agius4 november 4 2026 15 14 this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters sign up for free to join this conversation on github already have an account sign in to comment reviewers alan agius4 awaiting requested review from alan agius4 1 more reviewer gemini code assist bot gemini code assist bot left review comments reviewers whose approvals may not affect merge requirements uh oh there was an error while loading please reload this page assignees no one assigned labels area schematics angular projects none yet milestone no milestone development successfully merging this pull request may close these issues uh oh there was an error while loading please reload this page 2 participants add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge suggestion cannot be applied right now please check back later footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
|