site address:
github.com/angular/angular-cli/pull/34685/files redirected to: github.com/angular/angular-cli/pull/34685/files
site title:
fix(@schematics/angular): set explicit type for the application root component by nagahara-naoki · Pull Request #34685 · angular/angular-cli · GitHub
|
|
|
Our opinion (on Wednesday 18 November 2026 17:09:24 UTC):
- no comments
|
|
|
|
After content analysis of this website we propose the following hashtags:
|
|
|
|
Meta tags:
description= PR Checklist
The commit message follows our guidelines: htt????/github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
PR Type
Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
Other... Please describe:
What is the current behavior?
When the workspace sets @schematics/angular:component : type : component , ng generate application --file-name-style-guide=2025 inherits that type for its root component. It generates app.component.css, while the application template generates app.ts referencing ./app.css. The first build fails with NG2008, and extra app.component.* files are left in the application.
Issue Number: Closes #34684
What is the new behavior?
Pass an explicit empty type when generating the application root component with the 2025 naming style, so the component files match the application templates: app.ts, app.html, and app.css.
The 2016 branch continues to pass type: component . Ordinary component generation still uses the workspace default. This follows the approach used in #34450 and #34472.
The new E2E test sets the workspace component type, generates and builds applications using both naming styles, checks their stylesheet references and the absence of the incorrectly named root component, and verifies that a separately generated component still uses the workspace type.
Does this PR introduce a breaking change?
Yes
No
Other information
Validated locally against main at d5035923f0e357b2526c98110125eee04b05192f:
Before the fix, the new regression test fails during the generated application s build with NG2008.
After the fix, the regression test and the existing schematic-defaults E2E test both pass.
The Angular schematics unit suite reports 976 specs, 0 failures, and 1 existing pending spec.
Prettier, ESLint on the production file, and git diff --check pass.
Commands:
pnpm bazel test //tests:e2e_node24 \
--config=e2e --config=no-sharding \
--test_filter= tests/generate/ application/application-workspace-type-default,schematic-defaults .ts \
--test_arg=--esbuild --nocache_test_results
pnpm bazel test //packages/schematics/angular:test --config=no-sharding
The full CLI repository test suite was not run.;
Headings (most frequently used words):
uh, oh, for, the, navigation, fix, schematics, angular, set, explicit, type, application, root, component, 34685, are, footer, you, diff, view, menu, repository, there, no, files, selected, viewing, sure, want, to, change, base, filter, by, extension,
Text of the page (most frequently used words):
file (20), the (17), github (16), #application (15), and (15), for (14), angular (14), this (13), #component (12), type (12), applied (11), loading (10), you (9), line (9), reload (9), app (9), schematics (9), from (8), all (8), show (8), that (7), suggestion (7), cannot (7), suggestions (7), while (7), code (7), await (7), project (7), tests (7), default (7), style (7), open (7), sign (7), changes (6), diff (6), hidden (6), characters (6), unicode (6), not (5), security (5), please (5), comments (5), change (5), commit (5), there (5), generate (5), fix (5), base (5), your (5), can (4), pull (4), was (4), error (4), page (4), workspace (4), 2016 (4), build (4), const (4), number (4), bidirectional (4), may (4), review (4), learn (4), about (4), view (4), componentoptions (4), files (4), load (4), nagahara (4), naoki (4), set (4), explicit (4), root (4), commits (4), support (4), copilot (4), community (3), navigation (3), request (3), add (3), batch (3), retry (3), expectfiletomatch (3), projects (3), 2025 (3), example (3), skip (3), apppath (3), componentname (3), import (3), utils (3), what (3), more (3), e2e (3), packages (3), index (3), hide (3), whitespace (3), filter (3), 34685 (3), branch (3), refname (3), account (3), quality (3), another (3), tab (3), window (3), refresh (3), session (3), developers (3), changelog (3), customer (3), enterprise (3), grade (3), features (3), contact (2), status (2), privacy (2), terms (2), footer (2), 2026 (2), merge (2), outdated (2), single (2), one (2), viewing (2), toggle (2), src (2), export (2), expectfilenottoexist (2), css (2), development (2), false (2), config (2), updatejsonfile (2), function (2), original (2), contains (2), text (2), interpreted (2), compiled (2), differently (2), than (2), appears (2), below (2), editor (2), reveals (2), desktop (2), delete (2), edit (2), additions (2), deletions (2), expand (2), options (2), 420 (2), are (2), selected (2), apply (2), split (2), unified (2), failed (2), jump (2), extension (2), tree (2), old (2), could (2), tags (2), branches (2), main (2), issue (2), insights (2), actions (2), 196 (2), repository (2), cli (2), signed (2), with (2), universe (2), training (2), integrations (2), stories (2), center (2), documentation (2), business (2), fixes (2), products (2), secret (2), perform, action, time, share, personal, information, manage, cookies, docs, inc, right, now, check, back, later, queued, multi, pending, reviews, has, been, marked, resolved, must, existing, order, create, valid, applying, deleted, lines, supported, only, per, subset, closed, invalid, because, were, made, annotations, notes, oops, something, went, wrong, class, ordinary, generation, should, still, use, styleurl, configuration, install, ssr, name, guide, json, async, process, down, return, else, addtypetoclassname, filenamestyleguide, getcomponentoptions, applicationoptions, partial, componentopti, conversations, clear, filters, viewed, nbsp, nov, c3f60f9, select, changed, checks, conversation, wants, into, some, removed, timeline, become, sure, want, nothing, found, choose, already, clicking, agree, our, occasionally, send, related, emails, statement, service, free, its, maintainers, have, question, new, items, requests, issues, message, dismiss, alert, switched, accounts, out, appearance, settings, search, pricing, event, talks, workshops, next, partners, company, forum, events, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, why, evaluate, see, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, source, latest, improvements, across, place, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, environments, codespaces, analysis, enforcement, automation, ship, coding, agent, tasks, automated, work, hosting, collaboration, platform, menu, content,
Text of the page (random words):
fix schematics angular set explicit type for the application root component by nagahara naoki pull request 34685 angular angular cli github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message angular angular cli repository navigation code issues 196 196 pull requests 20 20 actions security and quality 8 8 insights more items fix schematics angular set explicit type for the application root component 34685 new issue have a question about this project sign up for a free github account to open an issue and contact its maintainers and the community sign up for github by clicking sign up for github you agree to our terms of service and privacy statement we ll occasionally send you account related emails already on github sign in to your account open nagahara naoki wants to merge 1 commit into angular main base main choose a base branch branches tags could not load branches branch not found refname loading refname default could not load tags nothing to show refname default loading are you sure you want to change the base some commits from the old base branch may be removed from the timeline and old review comments may become outdated loading change base from nagahara naoki fix application component type conversation 0 commits 1 checks 11 files changed uh oh there was an error while loading please reload this page open fix schematics angular set explicit type for the application root component 34685 show file tree hide file tree changes from all commits commits show all changes 1 commit select commit c3f60f9 fix schematics angular set explicit type for the application root nagahara naoki nov 11 2026 file filter filter by extension filter by extension ts nbsp 2 all 1 file type selected viewed files clear filters conversations failed to load comments retry loading uh oh there was an error while loading please reload this page jump to jump to file failed to load files retry loading uh oh there was an error while loading please reload this page diff view unified split hide whitespace apply and reload show whitespace diff view unified split hide whitespace apply and reload packages schematics angular application packages schematics angular application index ts index ts tests e2e tests generate application tests e2e tests generate application application workspace type default ts application workspace type default ts there are no files selected for viewing 2 changes 2 additions 0 deletions 2 packages schematics angular application index ts show comments view file edit file delete file open in desktop this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters original file line number diff line number diff line change expand up 420 6 420 8 function getcomponentoptions options applicationoptions partial componentopti if options filenamestyleguide 2016 componentoptions type component componentoptions addtypetoclassname false else componentoptions type return componentoptions expand down 34 changes 34 additions 0 deletions 34 tests e2e tests generate application application workspace type default ts show comments view file edit file delete file open in desktop this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters original file line number diff line number diff line change 0 0 1 34 import expectfilenottoexist expectfiletomatch from utils fs import ng from utils process import updatejsonfile from utils project export default async function await updatejsonfile angular json config config schematics schematics angular component type component for const style of 2025 2016 const project app style const apppath projects project src app const componentname style 2016 app component app await ng generate application project file name style guide style style css ssr false skip install await ng build project configuration development await expectfiletomatch apppath componentname ts styleurl componentname css await expectfilenottoexist apppath style 2016 app app component ts ordinary component generation should still use the workspace default await ng generate component example project app 2025 skip tests await expectfiletomatch projects app 2025 src app example example component ts export class loading oops something went wrong retry uh oh there was an error while loading please reload this page toggle all file notes toggle all file annotations add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge suggestion cannot be applied right now please check back later footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
|
|
| Thumbnail images (randomly selected): * Images may be subject to copyright. | |  |
|
Verified site has: 58 subpage(s). Do you want to verify them? Verify pages:
|
The site also has references to the 5 subdomain(s)
|
The site also has 5 references to external domain(s).
|
|
|
Pages verified in the last hours (randomly selected):
|
|
Top 50 hastags from of all verified websites.
| |
|
|
|
|
|
|
Load Info| page size | 52584 | | load time (s) | 1.114683 | | redirect count | 1 | | speed download | 47202 | | server IP | 140.82.121.4 |
|
|
|
|
|
|
|
|
* Image may be subject to copyright.
|
|