site address:
github.com/angular/angular-cli/pull/34736/files redirected to: github.com/angular/angular-cli/pull/34736/files
site title:
fix(@angular/build): refresh template diagnostics on Windows after an external template changes by thekhegay · Pull Request #34736 · angular/angular-cli · GitHub
|
|
|
Our opinion (on Wednesday 18 November 2026 14:21:15 UTC):
- no comments
|
|
|
|
After content analysis of this website we propose the following hashtags:
|
|
|
|
Meta tags:
description= PR Checklist
The commit message follows our guidelines: htt????/github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
PR Type
Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
Other... Please describe:
What is the current behavior?
Issue Number: #34725
On Windows SourceFileCache.invalidate puts path.normalized paths (backslashes) into modifiedFiles, but resource dependencies from compiler have forward slashes. So modifiedFiles.has(resourceDependency) in AotCompilation never matches, diagnostics cache of the component is not dropped and template errors stay stale after editing external template
What is the new behavior?
Resource dependency is normalized before the lookup, same as referencedFiles are normalized in SourceFileCache.invalidate. On POSIX normalize doesnt change anything
Does this PR introduce a breaking change?
Yes
No
Other information
No test: mismatch only happens with Windows separators, cant reproduce it on Linux/macOS. Issue has repro repo with output from both platforms;
Headings (most frequently used words):
template, uh, oh, navigation, fix, angular, build, refresh, diagnostics, on, windows, after, an, external, changes, 34736, are, footer, you, diff, view, menu, repository, there, no, files, selected, for, viewing, sure, want, to, change, the, base, filter, by, extension,
Text of the page (most frequently used words):
github (16), and (15), this (13), #angular (13), from (12), applied (11), the (11), file (11), loading (10), for (10), build (10), you (9), reload (9), template (9), changes (8), all (8), refresh (8), suggestion (7), cannot (7), suggestions (7), while (7), code (7), import (7), sign (7), line (6), diagnostics (6), windows (6), commits (6), that (5), not (5), security (5), please (5), there (5), resourcedependency (5), show (5), open (5), thekhegay (5), fix (5), base (5), your (5), can (4), pull (4), comments (4), has (4), change (4), was (4), error (4), page (4), expand (4), hostoptions (4), modifiedfiles (4), diff (4), files (4), load (4), after (4), support (4), copilot (4), community (3), navigation (3), 2026 (3), request (3), add (3), batch (3), commit (3), retry (3), node (3), cli (3), hidden (3), characters (3), unicode (3), may (3), review (3), learn (3), about (3), view (3), whitespace (3), filter (3), 34736 (3), external (3), branch (3), refname (3), account (3), quality (3), another (3), tab (3), window (3), session (3), developers (3), changelog (3), customer (3), enterprise (3), grade (3), features (3), contact (2), status (2), privacy (2), terms (2), footer (2), merge (2), outdated (2), single (2), one (2), viewing (2), toggle (2), down (2), normalize (2), 331 (2), utils (2), relative (2), path (2), assert (2), type (2), number (2), bidirectional (2), what (2), more (2), compilation (2), are (2), selected (2), apply (2), hide (2), split (2), unified (2), failed (2), jump (2), extension (2), nov (2), select (2), old (2), default (2), could (2), tags (2), branches (2), main (2), issue (2), insights (2), actions (2), 196 (2), repository (2), signed (2), with (2), universe (2), training (2), integrations (2), stories (2), center (2), documentation (2), business (2), fixes (2), products (2), secret (2), perform, action, time, share, personal, information, manage, cookies, docs, inc, right, now, check, back, later, queued, multi, pending, reviews, been, marked, resolved, must, existing, order, create, valid, applying, deleted, lines, supported, only, per, subset, closed, invalid, because, were, made, annotations, notes, oops, something, went, wrong, continue, css, scss, sass, less, test, const, resourcedependencies, state, size, export, class, aotcompilation, extends, typescriptcompilation, profileasync, profilesync, profiling, usetypechecking, environment, options, typescript, compiler, original, contains, text, interpreted, compiled, differently, than, appears, below, editor, reveals, desktop, delete, edit, packages, src, tools, aot, additions, deletions, conversations, clear, filters, viewed, nbsp, fixup, 9a58469, 8df8406, hold, shift, click, range, changed, checks, conversation, wants, into, some, removed, timeline, become, sure, want, nothing, found, choose, already, clicking, agree, our, occasionally, send, related, emails, statement, service, free, its, maintainers, have, question, project, new, items, requests, issues, message, dismiss, alert, switched, accounts, out, appearance, settings, search, pricing, event, talks, workshops, next, partners, company, forum, events, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, why, evaluate, see, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, source, latest, improvements, across, place, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, development, environments, codespaces, analysis, enforcement, automation, ship, coding, agent, tasks, projects, automated, work, hosting, collaboration, platform, menu, skip, content,
Text of the page (random words):
fix angular build refresh template diagnostics on windows after an external template changes by thekhegay pull request 34736 angular angular cli github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message angular angular cli repository navigation code issues 196 196 pull requests 20 20 actions security and quality 8 8 insights more items fix angular build refresh template diagnostics on windows after an external template changes 34736 new issue have a question about this project sign up for a free github account to open an issue and contact its maintainers and the community sign up for github by clicking sign up for github you agree to our terms of service and privacy statement we ll occasionally send you account related emails already on github sign in to your account open thekhegay wants to merge 2 commits into angular main base main choose a base branch branches tags could not load branches branch not found refname loading refname default could not load tags nothing to show refname default loading are you sure you want to change the base some commits from the old base branch may be removed from the timeline and old review comments may become outdated loading change base from thekhegay build windows template diagnostics conversation 3 commits 2 checks 10 files changed uh oh there was an error while loading please reload this page open fix angular build refresh template diagnostics on windows after an external template changes 34736 changes from all commits commits show all changes 2 commits select commit hold shift click to select a range 8df8406 fix angular build refresh template diagnostics on windows after an thekhegay nov 16 2026 9a58469 fixup fix angular build refresh template diagnostics on windows a thekhegay nov 17 2026 file filter filter by extension filter by extension ts nbsp 1 all 1 file type selected viewed files clear filters conversations failed to load comments retry loading uh oh there was an error while loading please reload this page jump to jump to file failed to load files retry loading uh oh there was an error while loading please reload this page diff view unified split hide whitespace apply and reload show whitespace diff view unified split hide whitespace apply and reload there are no files selected for viewing 5 changes 3 additions 2 deletions 5 packages angular build src tools angular compilation aot compilation ts show comments view file edit file delete file open in desktop this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters original file line number diff line number diff line change expand up 8 7 8 7 import type as ng from angular compiler cli import assert from node assert import relative from node path import normalize relative from node path import ts from typescript import usetypechecking from utils environment options import profileasync profilesync from utils profiling expand down expand up 331 7 331 8 export class aotcompilation extends typescriptcompilation if this state hostoptions modifiedfiles size for const resourcedependency of resourcedependencies if hostoptions modifiedfiles has resourcedependency hostoptions modifiedfiles has resourcedependency hostoptions modifiedfiles has normalize resourcedependency css scss sass less i test resourcedependency continue expand down loading oops something went wrong retry uh oh there was an error while loading please reload this page toggle all file notes toggle all file annotations add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge suggestion cannot be applied right now please check back later footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
|
|
| Thumbnail images (randomly selected): * Images may be subject to copyright. | |  |
|
Verified site has: 58 subpage(s). Do you want to verify them? Verify pages:
|
The site also has references to the 5 subdomain(s)
|
The site also has 5 references to external domain(s).
|
|
|
Pages verified in the last hours (randomly selected):
|
|
Top 50 hastags from of all verified websites.
| |
|
|
|
|
|
|
Load Info| page size | 48609 | | load time (s) | 1.067235 | | redirect count | 1 | | speed download | 45556 | | server IP | 140.82.121.3 |
|
|
|
|
|
|
|
|
* Image may be subject to copyright.
|
|