Meta tags:
description= Open-source JavaScript charting library behind Plotly and Dash - fix(pie): clear stale leader lines when outside labels move back inside by b84330808 · Pull Request #8146 · plotly/plotly.js;
Headings (most frequently used words):
fix, pie, stale, uh, oh, labels, navigation, clear, leader, lines, when, outside, move, back, inside, to, plotly, js, b84330808, footer, commented, oct, 26, 2026, 8146, menu, repository, 8146b84330808, wants, merge, commits, intoplotly, mainplotly, mainfrom, textlineb84330808, textlinecopy, head, branch, name, clipboard, conversation, cause, tests, screenshots, koolade85, reviewers, assignees, projects, milestone, development, participants,
Text of the page (most frequently used words):
the (46), and (27), this (21), plotly (18), pie (15), for (14), github (13), #labels (12), that (11), applied (11), #leader (10), fix (10), stale (10), lines (9), outside (9), label (9), b84330808 (9), back (8), pull (8), code (8), suggestion (7), cannot (7), suggestions (7), while (7), request (7), reload (7), draw (7), inside (7), 2026 (6), line (6), koolade85 (6), all (6), copy (6), plot (6), with (6), test (6), you (5), security (5), please (5), change (5), error (5), textline (5), when (5), review (5), sign (5), hidden (5), without (5), relayout (5), move (5), can (4), merge (4), from (4), there (4), was (4), loading (4), page (4), window (4), then (4), fixes (4), clear (4), commits (4), new (4), main (4), 8146 (4), your (4), support (4), copilot (4), navigation (3), has (3), add (3), batch (3), only (3), were (3), none (3), conversation (3), characters (3), unicode (3), open (3), learn (3), oct (3), claude (3), number (3), redraw (3), react (3), moved (3), plottextlines (3), its (3), other (3), reset (3), state (3), slice (3), after (3), same (3), npm (3), run (3), quality (3), another (3), tab (3), refresh (3), session (3), developers (3), changelog (3), customer (3), enterprise (3), grade (3), features (3), build (3), not (2), community (2), status (2), footer (2), single (2), commit (2), one (2), changes (2), may (2), issues (2), development (2), milestone (2), yet (2), projects (2), requested (2), file (2), bidirectional (2), text (2), what (2), more (2), about (2), self (2), october (2), sorry (2), something (2), went (2), wrong (2), reactions (2), markdown (2), link (2), commented (2), authored (2), opus (2), noreply (2), anthropic (2), com (2), rename (2), recalc (2), resize (2), through (2), reuses (2), calcdata (2), points (2), set (2), labelextrax (2), labelextray (2), ylabelmid (2), current (2), kept (2), values (2), previous (2), scootlabels (2), treated (2), drew (2), old (2), every (2), start (2), each (2), 5616 (2), 4979 (2), first (2), slices (2), 300x300 (2), resized (2), pass (2), windows (2), funnelarea (2), sunburst (2), treemap (2), tests (2), draws (2), where (2), 1000x1000 (2), wants (2), into (2), head (2), branch (2), name (2), clipboard (2), insights (2), actions (2), 727 (2), repository (2), signed (2), universe (2), training (2), integrations (2), stories (2), center (2), documentation (2), business (2), products (2), secret (2), perform, action, time, share, personal, information, manage, cookies, contact, docs, privacy, terms, inc, right, now, check, later, queued, multi, comments, pending, reviews, been, marked, resolved, outdated, must, existing, order, create, valid, applying, deleted, supported, per, viewing, subset, closed, invalid, because, made, participants, remains, size, gets, large, successfully, merging, close, these, assignees, least, approving, required, awaiting, reviewers, already, have, account, comment, join, free, show, contains, interpreted, compiled, differently, than, appears, below, editor, reveals, assigned, thanks, take, closer, look, follow, contributor, ab2ac81, draftlog, example, step, shifted, 52ca054, added, others, used, write, holds, placeholder, will, draftlogs, 0000_fix, moves, image, baselines, know, mock, resizes, before, figure, drawn, 700x700, textposition, auto, screenshots, reports, count, checkout, getcomputedstyle, syntax, typecheck, lint, ran, suites, headless, chrome, uniform, options, fails, machine, uniformtext, icicle, legend, jasmine, suite, some, need, calls, expects, positions, are, lower, pie_test, also, clears, longer, such, avoid, src, traces, cause, remove, offsets, stay, files, changed, checks, items, requests, message, dismiss, alert, switched, accounts, out, appearance, settings, search, pricing, event, talks, workshops, next, partners, company, forum, events, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, why, evaluate, see, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, source, latest, improvements, across, place, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, environments, codespaces, analysis, enforcement, automation, ship, coding, agent, tasks, automated, work, hosting, collaboration, platform, menu, skip, content,
Text of the page (random words):
fix pie clear stale leader lines when outside labels move back inside by b84330808 pull request 8146 plotly plotly js github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message plotly plotly js repository navigation code issues 727 727 pull requests 82 82 actions security and quality insights more items fix pie clear stale leader lines when outside labels move back inside 8146 8146 open b84330808 wants to merge 2 commits into plotly main plotly plotly js main from b84330808 fix pie stale textline b84330808 plotly js fix pie stale textline copy head branch name to clipboard conversation commits 2 2 checks files changed open fix pie clear stale leader lines when outside labels move back inside 8146 b84330808 wants to merge 2 commits into plotly main plotly plotly js main from b84330808 fix pie stale textline b84330808 plotly js fix pie stale textline copy head branch name to clipboard conversation b84330808 commented oct 26 2026 copy link copy markdown remove the stale leader lines and label offsets that stay on a pie after its labels move back inside fixes 4979 and 5616 cause a redraw without a recalc reuses the calcdata points a resize through plotly relayout or plotly react is such a redraw plot in src traces pie plot js set labelextrax labelextray and ylabelmid only for the labels that were outside on the current draw a label that moved back inside kept the values of the previous draw scootlabels then treated the label as an outside label and plottextlines drew its old leader line the other outside labels moved to avoid the stale label fix reset this state for every slice at the start of each draw the reset also clears the state of hidden slices so plottextlines no longer draws a line for a hidden slice tests new jasmine test in pie_test js pie relayout suite the test draws a pie at 300x300 px where some labels need leader lines then the test calls plotly relayout to 1000x1000 px the test expects the same leader lines and label positions as a new plot at 1000x1000 px without the fix the resized plot has 3 leader lines where the new plot has none and 3 labels are 2 to 8 px lower i ran the pie funnelarea legend sunburst treemap and icicle suites in headless chrome on windows the uniformtext react with new uniform text options test fails for pie funnelarea sunburst and treemap on this machine with and without the change all other tests pass npm run lint and npm run typecheck pass npm run test syntax reports the same getcomputedstyle count error with and without the change on this windows checkout screenshots the same figure 8 slices textposition auto first drawn at 300x300 px and then resized with plotly relayout to 700x700 px before after the change moves no image baselines that i know of no mock resizes a pie after the first draw draftlogs 0000_fix md holds a placeholder number i will rename it to the number of this pull request i used claude code to write this change sorry something went wrong uh oh there was an error while loading please reload this page all reactions b84330808 and others added 2 commits october 26 2026 12 47 fix pie clear stale leader lines when outside labels move back inside 52ca054 a redraw without a recalc for example a resize through relayout or react reuses the calcdata points the plot step set labelextrax labelextray and ylabelmid only for labels that were outside on the current draw a label that moved back inside kept the values of the previous draw scootlabels then treated the label as an outside label and plottextlines drew its old leader line and shifted the other labels reset this state for every slice at the start of each draw fixes plotly 4979 and plotly 5616 co authored by claude opus 5 5 noreply anthropic com rename the draftlog to the pull request number ab2ac81 co authored by claude opus 5 5 noreply anthropic com koolade85 commented oct 26 2026 copy link copy markdown contributor thanks for the pr we ll take a closer look and follow up all reactions sorry something went wrong uh oh there was an error while loading please reload this page koolade85 self assigned this oct 26 2026 koolade85 self requested a review october 26 2026 20 56 this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters sign up for free to join this conversation on github already have an account sign in to comment reviewers koolade85 awaiting requested review from koolade85 at least 1 approving review is required to merge this pull request uh oh there was an error while loading please reload this page assignees koolade85 labels none yet projects none yet milestone no milestone development successfully merging this pull request may close these issues textline remains when window size gets large uh oh there was an error while loading please reload this page 2 participants add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge suggestion cannot be applied right now please check back later footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
|