Meta tags:
description= The interactive graphing library for Python :sparkles: - Fix `px.ecdf` counting missing values as observations by CyberNativeAI · Pull Request #5842 · plotly/plotly.py;
Headings (most frequently used words):
fix, ecdf, missing, uh, oh, navigation, to, px, counting, values, as, observations, plotly, py, ai, branch, footer, commented, oct, 2026, 5842, menu, repository, 5842cybernativeai, wants, merge, commit, intoplotly, mainplotly, mainfrom, cybernative, valuescybernative, valuescopy, head, name, clipboard, conversation, cybernativeai, 23, link, issue, description, of, change, demo, testing, strategy, guidelines, koolade85, 26, this, has, not, been, deployed, reviewers, assignees, labels, projects, milestone, development, participants,
Text of the page (most frequently used words):
the (38), and (24), this (21), values (14), github (13), #missing (13), #plotly (13), applied (11), ecdf (11), fix (11), code (9), not (8), there (8), for (8), that (7), suggestion (7), cannot (7), suggestions (7), while (7), pull (7), reload (7), all (7), with (7), you (6), request (6), from (6), none (6), koolade85 (6), copy (6), main (6), can (5), security (5), 2026 (5), please (5), review (5), sign (5), nan (5), group (5), point (5), before (5), cybernative (5), merge (4), commit (4), were (4), was (4), error (4), loading (4), page (4), open (4), rows (4), null (4), counting (4), observations (4), changelog (4), tests (4), same (4), data (4), cybernativeai (4), 5842 (4), your (4), support (4), copilot (4), navigation (3), line (3), add (3), batch (3), have (3), conversation (3), hidden (3), characters (3), unicode (3), below (3), learn (3), branch (3), link (3), oct (3), value (3), extra (3), documentation (3), test_optional (3), test_px (3), ecdfmode (3), each (3), pandas (3), fig (3), issue (3), quality (3), another (3), tab (3), window (3), refresh (3), session (3), developers (3), customer (3), enterprise (3), grade (3), features (3), build (3), community (2), status (2), footer (2), has (2), been (2), change (2), single (2), only (2), one (2), changes (2), because (2), may (2), issues (2), development (2), milestone (2), yet (2), projects (2), required (2), requested (2), file (2), bidirectional (2), what (2), more (2), about (2), sorry (2), something (2), went (2), wrong (2), reactions (2), markdown (2), commented (2), self (2), whose (2), included (2), cumulative (2), sum (2), total (2), short (2), had (2), them (2), company (2), guidelines (2), over (2), dataframe (2), three (2), without (2), those (2), row (2), out (2), gives (2), ecdfnorm (2), curve (2), tolist (2), import (2), wants (2), into (2), head (2), name (2), clipboard (2), insights (2), actions (2), 649 (2), repository (2), signed (2), universe (2), training (2), integrations (2), stories (2), center (2), business (2), fixes (2), products (2), secret (2), perform, action, time, share, personal, information, manage, cookies, contact, docs, privacy, terms, inc, right, now, check, back, later, queued, multi, comments, pending, reviews, marked, resolved, outdated, must, existing, order, create, valid, applying, deleted, lines, supported, per, viewing, subset, closed, invalid, made, participants, successfully, merging, close, these, labels, assignees, least, approving, awaiting, reviewers, already, account, comment, join, free, show, contains, text, interpreted, compiled, differently, than, appears, editor, reveals, deployments, deployed, thanks, take, closer, look, follow, contributor, october, assigned, stopped, drop, sorting, 9275573, prepared, llc, run, using, agents, added, entry, needed, prs, reviewed, confirm, follows, conduct, adds, parametrized, suite, constructors, cases, fail, everything, else, passes, 1081, pass, skipped, xfailed, ran, collected, installed, our, environment, pytz, xarray, test_trendline, test_imshow, fcc3c8e, test_px_functions, test_ecdf_ignores_missing_values, testing, strategy, numbers, instead, screenshot, snippet, above, after, 3333333333333333, 6666666666666666, demo, cause, block, sorts, then, takes, every, filters, where, base, column, just, sort, logic, new, cum_sum, nulls_last, true, make_figure, happens, largest, count, within, color, orientation, reversed, complementary, percent, expected, result, observed, are, docstring, represent, should, prints, current, print, express, counts, nullable, polars, pyarrow, observation, stops, gets, drops, description, separate, carries, report, reproduction, well, would, rather, track, files, changed, checks, commits, items, requests, message, dismiss, alert, switched, accounts, appearance, settings, search, pricing, event, talks, workshops, next, partners, forum, events, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, why, evaluate, see, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, source, latest, improvements, across, place, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, environments, codespaces, analysis, enforcement, automation, ship, coding, agent, tasks, automated, work, hosting, collaboration, platform, menu, skip, content,
Text of the page (random words):
fix px ecdf counting missing values as observations by cybernativeai pull request 5842 plotly plotly py github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message plotly plotly py repository navigation code issues 649 649 pull requests 87 87 actions security and quality insights more items fix px ecdf counting missing values as observations 5842 5842 open cybernativeai wants to merge 1 commit into plotly main plotly plotly py main from cybernative ai fix ecdf missing values cybernative ai plotly py fix ecdf missing values copy head branch name to clipboard conversation commits 1 1 checks files changed open fix px ecdf counting missing values as observations 5842 cybernativeai wants to merge 1 commit into plotly main plotly plotly py main from cybernative ai fix ecdf missing values cybernative ai plotly py fix ecdf missing values copy head branch name to clipboard conversation cybernativeai commented oct 23 2026 copy link copy markdown link to issue there is no separate issue this pr carries the report and a reproduction we can open an issue as well if you would rather track it there description of change px ecdf counts a row whose value is missing pandas nan none nullable na polars or pyarrow null as an observation so the curve stops short of 1 and gets an extra point at the missing x this pr drops those rows from each group before the cumulative sum import pandas as pd import plotly express as px fig px ecdf pd dataframe v 3 1 2 none x v print fig data 0 x tolist fig data 0 y tolist prints this on current main 7 1 0 gives the same values 1 0 2 0 3 0 nan 0 25 0 5 0 75 1 0 the expected result is y 1 3 2 3 1 at x 1 2 3 with no point at nan all three observed values are at or below 3 so by the docstring values represent data at or below the point the curve should be 1 there not 0 75 the same happens with ecdfnorm percent 75 at the largest value ecdfnorm none an extra point with count 4 ecdfmode complementary and reversed orientation h and within each color group data without missing values gives the same values as before cause in make_figure the ecdfmode block sorts each group with nulls_last true then takes cum_sum and the group total over every row null rows included the fix filters out rows where the base column is null just before that sort the pandas code in 5 24 1 had the same logic so this is not new demo numbers instead of a screenshot from the snippet above before 1 0 2 0 3 0 nan 0 25 0 5 0 75 1 0 after 1 0 2 0 3 0 0 3333333333333333 0 6666666666666666 1 0 testing strategy adds test_ecdf_ignores_missing_values to tests test_optional test_px test_px_functions py parametrized over the suite s dataframe constructors and the three ecdfmode values 15 cases on main fcc3c8e without the fix those 15 fail and everything else in tests test_optional test_px passes with the fix all 1081 tests there pass 10 skipped 4 xfailed we ran only tests test_optional test_px and test_imshow py and test_trendline py were not collected because xarray and pytz were not installed in our environment guidelines i have reviewed the pull request guidelines and the code of conduct and confirm that this pr follows them i have added an entry to the changelog if needed not required for documentation prs prepared by cybernative ai llc an ai run company using ai agents sorry something went wrong uh oh there was an error while loading please reload this page all reactions fix px ecdf counting missing values as observations 9275573 rows whose value is missing nan none na null were included in the cumulative sum and the group total so the ecdf stopped short of 1 and had an extra point at the missing x drop them before sorting koolade85 self assigned this oct 26 2026 koolade85 self requested a review october 26 2026 20 58 koolade85 commented oct 26 2026 copy link copy markdown contributor thanks for the pr we ll take a closer look and follow up all reactions sorry something went wrong uh oh there was an error while loading please reload this page this branch has not been deployed no deployments this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters sign up for free to join this conversation on github already have an account sign in to comment reviewers koolade85 awaiting requested review from koolade85 at least 1 approving review is required to merge this pull request uh oh there was an error while loading please reload this page assignees koolade85 labels none yet projects none yet milestone no milestone development successfully merging this pull request may close these issues uh oh there was an error while loading please reload this page 2 participants add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge suggestion cannot be applied right now please check back later footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
|