Meta tags:
description= The interactive graphing library for Python :sparkles: - Deduplicate the optional FigureWidget import in graph_objects codegen by DawnofGenX · Pull Request #5850 · plotly/plotly.py;
Headings (most frequently used words):
uh, oh, 2026, comment, this, choose, reason, for, hiding, dawnofgenx, figurewidget, codegen, oct, 27, camdecoster, nov, 11, optional, navigation, to, deduplicate, the, import, in, graph_objects, plotly, py, dedupe, branch, footer, commented, 5850, menu, repository, 5850dawnofgenx, wants, merge, commits, intoplotly, mainplotly, mainfrom, 5849dawnofgenx, 5849copy, head, name, clipboard, conversation, link, issue, description, of, change, demo, testing, strategy, additional, information, guidelines, left, has, not, been, deployed, reviewers, assignees, labels, projects, milestone, development, participants,
Text of the page (most frequently used words):
the (81), this (50), and (36), #comment (34), figurewidget (29), graph_objs (26), #plotly (25), codegen (21), reason (21), for (20), copy (20), there (18), was (18), graph_objects (18), import (16), please (15), optional (15), while (14), reload (14), changelog (14), dawnofgenx (14), choose (14), hiding (14), 2026 (13), github (13), applied (13), all (13), __init__ (13), you (12), code (11), error (11), loading (11), page (11), outdated (10), learn (10), link (10), ipywidgets (10), fallback (10), quality (10), check (9), from (9), camdecoster (9), more (9), sorry (9), something (9), went (9), wrong (9), reactions (9), markdown (9), block (9), suggestion (8), resolved (8), changes (8), duplicate (8), will (8), tests (8), test_core (8), 5849 (8), can (7), that (7), cannot (7), suggestions (7), pull (7), change (7), add (7), when (7), ruff (7), hide (7), low (7), off (7), topic (7), abuse (7), spam (7), displayed (7), describe (7), others (7), problem (7), request (6), test_figure_widget_backend (6), generator (6), main (6), 61bb49e (6), dedupe (6), rel_path (6), oct (6), not (5), security (5), only (5), sign (5), file (5), branch (5), could (5), still (5), missing_ (5), class (5), your (5), now (4), merge (4), one (4), review (4), another (4), diff (4), python (4), commands (4), format (4), test_figurewidget_reexport (4), author (4), nov (4), export (4), into (4), every (4), other (4), owns (4), deduplicate (4), graph_objects_rel_classes (4), contributor (4), 5850 (4), support (4), copilot (4), navigation (3), back (3), line (3), has (3), batch (3), these (3), labels (3), requested (3), already (3), have (3), conversation (3), hidden (3), characters (3), unicode (3), open (3), reverted (3), resolves (3), tree (3), pushed (3), head (3), entry (3), both (3), generated (3), like (3), fixes (3), datatype_rel_class_imports (3), split (3), which (3), thread (3), documentation (3), with (3), commits (3), tab (3), window (3), refresh (3), session (3), developers (3), customer (3), enterprise (3), grade (3), features (3), build (3), information (2), community (2), status (2), footer (2), been (2), must (2), deleted (2), lines (2), single (2), commit (2), per (2), because (2), may (2), issues (2), development (2), milestone (2), none (2), yet (2), projects (2), addressed (2), contains (2), bidirectional (2), what (2), appears (2), about (2), look (2), thing (2), workflow (2), unless (2), label (2), passed (2), test_optional_imports (2), changed (2), files (2), suggested (2), inline (2), list (2), form (2), runs (2), over (2), whole (2), repo (2), three (2), commented (2), november (2), compare (2), ad6cb64 (2), force (2), try (2), identical (2), end (2), each (2), exports (2), including (2), figure (2), behaviour (2), unchanged (2), regression (2), test (2), forced (2), failure (2), same (2), committed (2), append (2), 307 (2), fails (2), next (2), update (2), reviewed (2), guidelines (2), adds (2), wants (2), name (2), clipboard (2), insights (2), actions (2), 649 (2), repository (2), signed (2), universe (2), training (2), integrations (2), stories (2), center (2), business (2), products (2), secret (2), perform, action, time, share, personal, manage, cookies, contact, docs, privacy, terms, inc, right, later, queued, multi, comments, pending, reviews, marked, existing, order, create, valid, applying, supported, viewing, subset, closed, invalid, were, made, participants, bug, successfully, merging, close, assignees, reviewers, account, join, free, show, text, interpreted, compiled, differently, than, below, editor, reveals, deployments, deployed, take, get, chance, myself, fail, gets, maintainers, stays, raises, anywidget, dependency, missing, importerror, __all__, _figurewidget, pytest, after, regeneration, clean, verification, wrapped, points, are, rebased, onto, current, refactor, 6e5184b, emitted, producing, emit, real, present, absent, proving, invariant, identity, duplicated, 6ebc63d, just, formatter, stable, pass, running, insists, wrapping, let, simplify, bit, instead, duplicating, owned, handles, def, __getattr__, import_name, 314, 306, upstream, longer, heads, carries, revert, internal, doesn, need, removed, gone, rest, suite, passes, remove, seems, overkill, thanks, make, left, view, self, assigned, added, needed, required, prs, confirm, follows, them, conduct, ran, pinned, produces, agree, additional, asserts, invariants, its, own, last, assertion, signal, unmodified, testing, strategy, user, visible, visual, object, falls, unavailable, missing_anywidget, demo, wrote, plus, leaving, emits, regenerated, hand, edited, description, closes, issue, checks, items, requests, message, dismiss, alert, switched, accounts, out, appearance, settings, search, pricing, event, talks, workshops, partners, company, forum, events, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, why, evaluate, see, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, source, latest, improvements, across, place, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, environments, codespaces, analysis, enforcement, automation, ship, coding, agent, tasks, automated, work, hosting, collaboration, platform, menu, skip, content,
Text of the page (random words):
deduplicate the optional figurewidget import in graph_objects codegen by dawnofgenx pull request 5850 plotly plotly py github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message plotly plotly py repository navigation code issues 649 649 pull requests 87 87 actions security and quality insights more items deduplicate the optional figurewidget import in graph_objects codegen 5850 5850 open dawnofgenx wants to merge 2 commits into plotly main plotly plotly py main from dawnofgenx dedupe figurewidget codegen 5849 dawnofgenx plotly py dedupe figurewidget codegen 5849 copy head branch name to clipboard conversation commits 2 2 checks files changed open deduplicate the optional figurewidget import in graph_objects codegen 5850 dawnofgenx wants to merge 2 commits into plotly main plotly plotly py main from dawnofgenx dedupe figurewidget codegen 5849 dawnofgenx plotly py dedupe figurewidget codegen 5849 copy head branch name to clipboard conversation dawnofgenx commented oct 27 2026 copy link copy markdown link to issue closes 5849 description of change the code generator wrote the optional figurewidget import block the try import plus the missing_ fallback into both plotly graph_objs __init__ py and plotly graph_objects __init__ py leaving an identical block at the end of each generated file graph_objects re exports every other class from graph_objs including figure and graph_objs already owns the optional import and the fallback so the generator now emits the block only for graph_objs and adds graph_objs figurewidget to graph_objects re export list the change is in codegen __init__ py plotly graph_objects __init__ py is regenerated python commands py codegen not hand edited demo n a no user visible or visual change behaviour is unchanged plotly graph_objects figurewidget is the same object as plotly graph_objs figurewidget and still falls back to plotly missing_anywidget figurewidget when ipywidgets is unavailable testing strategy adds tests test_core test_figure_widget_backend test_figurewidget_reexport py which asserts the three invariants graph_objects figurewidget is graph_objs figurewidget the forced ipywidgets failure fallback still resolves and plotly graph_objects __init__ py contains no optional ipywidgets import block of its own the last assertion is the regression signal it fails on unmodified main additional information optional ran python commands py codegen on the committed tree with the pinned ruff and it produces no diff so the generated file and the generator agree guidelines i have reviewed the pull request guidelines and the code of conduct and confirm that this pr follows them i have added an entry to the changelog if needed not required for documentation prs sorry something went wrong uh oh there was an error while loading please reload this page all reactions camdecoster self assigned this oct 27 2026 camdecoster requested changes oct 27 2026 view reviewed changes camdecoster left a comment copy link copy markdown contributor there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment thanks for the update could you please make these changes sorry something went wrong uh oh there was an error while loading please reload this page all reactions comment thread tests test_core test_figure_widget_backend test_figurewidget_reexport py outdated camdecoster oct 27 2026 copy link copy markdown contributor there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment could you please remove this test it seems like overkill sorry something went wrong uh oh there was an error while loading please reload this page all reactions dawnofgenx nov 11 2026 copy link copy markdown author there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment removed in 61bb49e tests test_core test_figure_widget_backend test_figurewidget_reexport py is gone the rest of the suite still passes 19 passed in tests test_core test_figure_widget_backend tests test_core test_optional_imports sorry something went wrong uh oh there was an error while loading please reload this page all reactions comment thread changelog md camdecoster oct 27 2026 copy link copy markdown contributor there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment could you please revert these changes this is an internal update and doesn t need a changelog entry sorry something went wrong uh oh there was an error while loading please reload this page all reactions dawnofgenx nov 11 2026 copy link copy markdown author there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment reverted in 61bb49e changelog md is back to upstream and no longer appears in the diff one heads up the check changelog workflow fails when a pr has no changelog change unless it carries the no changelog label and i can t add labels could you add it when you next look at this sorry something went wrong uh oh there was an error while loading please reload this page all reactions comment thread codegen __init__ py outdated comment on lines 306 to 314 307 6 307 11 def __getattr__ import_name graph_objs rel_path split 1 for rel_path in datatype_rel_class_imports figurewidget is owned by graph_objs which handles the optional ipywidgets import and the missing_ fallback re export it from graph_objs like every other class instead of duplicating the optional import block in graph_objects graph_objects_rel_classes append graph_objs figurewidget camdecoster oct 27 2026 copy link copy markdown contributor there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment let s simplify this a bit suggested change graph_objects_rel_classes append graph_objs figurewidget graph_objects_rel_classes graph_objs rel_path split 1 for rel_path in datatype_rel_class_imports graph_objs owns the optional ipywidgets import and the fallback graph_objs figurewidget sorry something went wrong uh oh there was an error while loading please reload this page all reactions dawnofgenx nov 11 2026 copy link copy markdown author there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment applied in 61bb49e ruff format check which ci runs over the whole repo insists on wrapping the generator so the committed form is graph_objects_rel_classes graph_objs rel_path split 1 for rel_path in datatype_rel_class_imports graph_objs owns the optional ipywidgets import and the fallback graph_objs figurewidget same thing as your suggestion just formatter stable ruff format check codegen __init__ py and ruff check codegen __init__ py both pass and running python commands py codegen is a no op on the tree sorry something went wrong uh oh there was an error while loading please reload this page all reactions deduplicate optional figurewidget import in codegen 6ebc63d the code generator emitted the optional figurewidget import block try import ipywidgets missing_ fallback into both plotly graph_objs __init__ py and plotly graph_objects __init__ py producing an identical block at the end of each generated file graph_objects already re exports every other class from graph_objs including figure and graph_objs owns the optional ipywidgets import and the missing_ fallback emit the block only for graph_objs and re export figurewidget from graph_objs in graph_objects like every other class behaviour is unchanged plotly graph_objects figurewidget still resolves to the real class when ipywidgets is present and to the missing_ fallback when it is absent add a regression test proving the invariant identity forced failure fallback and no duplicated ipywidgets block in graph_objects fixes plotly 5849 dawnofgenx force pushed the dedupe figurewidget codegen 5849 branch from 6e5184b to ad6cb64 compare november 11 2026 04 03 refactor codegen inline the figurewidget re export per review 61bb49e dawnofgenx force pushed the dedupe figurewidget codegen 5849 branch from ad6cb64 to 61bb49e compare november 11 2026 04 08 dawnofgenx commented nov 11 2026 copy link copy markdown author all three review points are addressed in 61bb49e rebased onto current main deleted tests test_core test_figure_widget_backend test_figurewidget_reexport py reverted the changelog md entry the pr diff is now only codegen __init__ py and plotly graph_objects __init__ py applied the suggested inline list form at codegen __init__ py the generator is wrapped because ruff format check runs over the whole repo in ci verification on the pushed head ruff format check ruff check clean on the changed files python commands py codegen is a no op on the tree no diff after regeneration pytest tests test_core test_figure_widget_backend tests test_core test_optional_imports 19 passed figurewidget still resolves to plotly graph_objs _figurewidget figurewidget stays in graph_objs __all__ and raises the anywidget importerror when the optional dependency is missing one thing i can t do myself the check changelog workflow will fail on this pr now that the changelog change is reverted unless it gets the no changelog label only maintainers can add labels could you take another look when you get a chance all reactions sorry something went wrong uh oh there was an error while loading please reload this page this branch has not been deployed no deployments this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters sign up for free to join this conversation on github already have an account sign in to comment reviewers camdecoster camdecoster requested changes requested changes must be addressed to merge this pull request uh oh there was an error while loading please reload this page assignees camdecoster labels none yet projects none yet milestone no milestone development successfully merging this pull request may close these issues bug duplicate figurewidget import code in graph_objects and graph_objs uh oh there was an error while loading please reload this page 2 participants add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge suggestion cannot be applied right now please check back later footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
|