Meta tags:
description= The interactive graphing library for Python :sparkles: - Accept CSS color formats supported by plotly.js in the color validator by ShawnNotFound · Pull Request #5868 · plotly/plotly.py;
Headings (most frequently used words):
uh, oh, color, css, plotly, shawnnotfound, this, comment, navigation, to, commented, nov, 2026, accept, formats, supported, by, js, in, the, validator, py, fix, branch, footer, loading, chrikrah, left, choose, reason, for, hiding, 5868, menu, repository, 5868shawnnotfound, wants, merge, commits, intoplotly, mainplotly, mainfrom, validationshawnnotfound, validationcopy, head, name, clipboard, conversation, edited, there, was, an, error, while, please, reload, page, link, issue, description, of, change, demo, testing, strategy, additional, information, optional, guidelines, 10, has, not, been, deployed, reviewers, assignees, labels, projects, milestone, development, participants,
Text of the page (most frequently used words):
the (32), color (30), this (28), #plotly (27), and (21), that (13), github (13), css (13), for (13), #shawnnotfound (13), rgb (13), copy (12), applied (11), while (11), reload (11), comment (11), 2026 (10), from (10), there (10), was (10), please (9), code (9), loading (9), validator (9), none (9), all (9), fix (9), pull (8), error (8), page (8), changelog (8), python (8), head (8), suggestion (7), cannot (7), suggestions (7), request (7), merge (7), line (7), koolade85 (7), with (7), nov (7), main (7), you (6), can (6), review (6), chrikrah (6), link (6), reason (6), not (5), security (5), supported (5), add (5), invalid (5), formats (5), more (5), have (5), sign (5), learn (5), sorry (5), something (5), went (5), wrong (5), reactions (5), markdown (5), them (5), passed (5), 255 (5), quality (5), reviewed (5), validation (5), accept (5), now (4), changes (4), rejects (4), accepts (4), open (4), branch (4), added (4), ff0000 (4), light (4), blue (4), basevalidators (4), hsl (4), choose (4), hiding (4), deg (4), signed (4), commits (4), 5868 (4), your (4), support (4), copilot (4), navigation (3), resolved (3), outdated (3), valid (3), batch (3), one (3), may (3), left (3), conversation (3), hidden (3), characters (3), unicode (3), than (3), what (3), strings (3), commented (3), entry (3), fd6f3ac (3), perform_validate_coerce (3), 20000 (3), test_color_validator (3), 145 (3), each (3), ref (3), colorvalidator (3), scatter (3), 100 (3), unclosed (3), into (3), regex (3), lab (3), fixes (3), keyword (3), documentation (3), before (3), another (3), tab (3), window (3), refresh (3), session (3), developers (3), customer (3), enterprise (3), grade (3), features (3), build (3), time (2), information (2), community (2), status (2), footer (2), comments (2), has (2), been (2), change (2), single (2), commit (2), were (2), bug (2), these (2), issues (2), development (2), milestone (2), yet (2), projects (2), required (2), reviewers (2), requested (2), file (2), bidirectional (2), about (2), thanks (2), parser (2), renders (2), author (2), spaces (2), blocking (2), git (2), archive (2), pypi (2), overlaid (2), seconds (2), pytest (2), tests (2), cacheprovider (2), 3c1aeba (2), failed (2), 121 (2), _plotly_utils (2), marker (2), nothing (2), blocks (2), hide (2), low (2), duplicate (2), off (2), topic (2), abuse (2), spam (2), will (2), displayed (2), describe (2), others (2), problem (2), view (2), split (2), run (2), digits (2), many (2), function (2), digit (2), base (2), 527cd14 (2), same (2), grad (2), rad (2), turn (2), self (2), november (2), 5867 (2), exponent (2), numbers (2), angle (2), units (2), other (2), any (2), space (2), transparent (2), are (2), accepted (2), rejected (2), syntax (2), guidelines (2), like (2), valueerror (2), wants (2), name (2), clipboard (2), insights (2), actions (2), 649 (2), repository (2), universe (2), training (2), integrations (2), stories (2), center (2), business (2), products (2), secret (2), perform, action, share, personal, manage, cookies, contact, docs, privacy, terms, inc, right, check, back, later, queued, multi, pending, reviews, marked, must, existing, order, create, applying, deleted, lines, only, per, viewing, subset, closed, because, made, participants, successfully, merging, close, labels, assignees, least, approving, whose, approvals, affect, requirements, reviewer, awaiting, already, account, join, free, show, contains, text, interpreted, compiled, differently, appears, below, editor, reveals, deployments, deployed, reaction, reacted, thumbs, emoji, checking, those, too, matches, a6eb0a4, rejecting, colors, non, raise, where, returned, exported, ones, 002, test_plotly_utils, validators, 28s, kept, 90s, probe, fails, milliseconds, here, side, swapped, could, ways, took, quadratic, reject, 0e4b97d, avoid, backtracking, long, runs, swap, else, input, 84498cc, 5000, 731, spacing, case, variants, hwb, lch, oklab, oklch, set, number, pattern, anywhere, backtracks, quadratically, token, _re_css_value, assigned, mentioned, allow, but, 772ae7e, needed, prs, confirm, follows, conduct, old, removed, matching, didn, handle, new, handles, whitespace, itself, step, gone, don, form, still, additional, optional, cases, checked, against, culori, uses, testing, strategy, after, value, type, builtins, str, received, property, marker_color, graph_objects, import, demo, parses, values, raised, even, though, srgb, description, closes, issue, edited, files, changed, checks, items, requests, message, dismiss, alert, switched, accounts, out, appearance, settings, search, pricing, event, talks, workshops, next, partners, company, forum, events, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, why, evaluate, see, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, source, latest, improvements, across, place, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, environments, codespaces, analysis, enforcement, automation, ship, coding, agent, tasks, automated, work, hosting, collaboration, platform, menu, skip, content,
Text of the page (random words):
accept css color formats supported by plotly js in the color validator by shawnnotfound pull request 5868 plotly plotly py github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message plotly plotly py repository navigation code issues 649 649 pull requests 87 87 actions security and quality insights more items accept css color formats supported by plotly js in the color validator 5868 5868 open shawnnotfound wants to merge 5 commits into plotly main plotly plotly py main from shawnnotfound fix css color validation shawnnotfound plotly py fix css color validation copy head branch name to clipboard conversation commits 5 5 checks files changed open accept css color formats supported by plotly js in the color validator 5868 shawnnotfound wants to merge 5 commits into plotly main plotly plotly py main from shawnnotfound fix css color validation shawnnotfound plotly py fix css color validation copy head branch name to clipboard conversation shawnnotfound commented nov 3 2026 edited loading uh oh there was an error while loading please reload this page copy link copy markdown link to issue closes 5867 description of change the color validator now accepts the css color syntax that plotly js parses signed and exponent numbers angle units other than deg the none keyword any color color space and transparent before values like lab 50 40 59 5 or color srgb 1 0 0 raised a valueerror even though plotly js renders them demo import plotly graph_objects as go go scatter marker_color lab 50 40 59 5 before valueerror invalid value of type builtins str received for the color property of scatter marker after accepted testing strategy added valid and invalid cases to test_color_validator py i checked each of them against culori the parser plotly js uses so the validator accepts and rejects the same strings additional information optional the old code removed spaces before matching so the regex didn t have to handle them the new regex handles whitespace itself so that step is gone strings that don t form a valid color function like rgb 255 0 or rgb 1 2 3 4 are still rejected guidelines i have reviewed the pull request guidelines and the code of conduct and confirm that this pr follows them i have added an entry to the changelog if needed not required for documentation prs sorry something went wrong uh oh there was an error while loading please reload this page all reactions shawnnotfound added 2 commits november 2 2026 22 02 accept css color syntax supported by plotly js in colorvalidator 772ae7e allow signed and exponent numbers angle units other than deg the none keyword any color color space and the transparent keyword these are all accepted by plotly js 4 but were rejected by the python validator add changelog entry 527cd14 koolade85 mentioned this pull request nov 4 2026 bug color validator rejects css color formats that plotly js accepts 5867 open koolade85 self assigned this nov 5 2026 koolade85 self requested a review november 5 2026 20 41 chrikrah reviewed nov 8 2026 view reviewed changes chrikrah left a comment copy link copy markdown there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment shawnnotfound blocking the number pattern in _re_css_value can split a digit run anywhere so an unclosed rgb backtracks quadratically one token fixes it r d d d e d deg grad rad turn none r d d d e d deg grad rad turn none plotly 7 1 0 from pypi _plotly_utils basevalidators py overlaid from each ref python 3 12 colorvalidator perform_validate_coerce seconds input base 84498cc head 527cd14 head fix rgb 1 5000 0 05 3 03 0 05 rgb 1 20000 0 05 41 96 0 05 rgb 1 1 1 20000 x 0 05 45 95 0 05 python m pytest test_color_validator py q p no cacheprovider head 145 passed basevalidators py at base 24 failed 121 passed head fix 145 passed 731 spacing and case variants of rgb hsl hwb lab lch oklab oklch and color head and head fix accept the same set can you swap that line in nothing else blocks sorry something went wrong uh oh there was an error while loading please reload this page all reactions avoid backtracking on long digit runs in the color regex 0e4b97d d d could split a run of digits in many ways so an unclosed color function with many digits took quadratic time to reject shawnnotfound commented nov 8 2026 copy link copy markdown author thanks i have swapped that line all reactions sorry something went wrong uh oh there was an error while loading please reload this page merge branch main into fix css color validation fd6f3ac chrikrah reviewed nov 9 2026 view reviewed changes chrikrah left a comment copy link copy markdown there was a problem hiding this comment choose a reason for hiding this comment the reason will be displayed to describe this comment to others learn more choose a reason spam abuse off topic outdated duplicate resolved low quality hide comment shawnnotfound unclosed rgb fails in milliseconds nothing here blocks a merge from my side fd6f3ac exported with git archive plotly 7 1 0 from pypi with basevalidators py overlaid python 3 12 python t py perform_validate_coerce on rgb 20000 ones seconds 0 002 python m pytest tests test_plotly_utils validators test_color_validator py q p no cacheprovider 145 passed in 0 28s basevalidators py from main 3c1aeba tests kept 24 failed 121 passed in 0 90s _plotly_utils from git archive at each ref python 3 12 14 python i probe py ref colorvalidator color scatter marker perform_validate_coerce 3c1aeba light blue light blue ff0000 ff0000 hsl 0 100 50 hsl 0 100 50 rgb 255 0 0 rgb 255 0 0 fd6f3ac light blue none ff0000 none hsl 0 100 50 none rgb 255 0 0 rgb 255 0 0 non blocking light blue and ff0000 now raise where main returned them invalid css so a fix changelog line sorry something went wrong uh oh there was an error while loading please reload this page all reactions add changelog entry for rejecting colors with invalid spaces a6eb0a4 shawnnotfound commented nov 10 2026 copy link copy markdown author thanks for checking added a changelog line for it plotly js s color parser rejects those strings too so the validator now matches what plotly js renders 1 koolade85 reacted with thumbs up emoji all reactions 1 reaction sorry something went wrong uh oh there was an error while loading please reload this page this branch has not been deployed no deployments this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters sign up for free to join this conversation on github already have an account sign in to comment reviewers koolade85 awaiting requested review from koolade85 1 more reviewer chrikrah chrikrah left review comments reviewers whose approvals may not affect merge requirements at least 1 approving review is required to merge this pull request uh oh there was an error while loading please reload this page assignees koolade85 labels none yet projects none yet milestone no milestone development successfully merging this pull request may close these issues bug color validator rejects css color formats that plotly js accepts uh oh there was an error while loading please reload this page 3 participants add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge suggestion cannot be applied right now please check back later footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
|