Meta tags:
description= The interactive graphing library for Python :sparkles: - Keep axis-spanning shapes on an empty subplot selected by row and col by LukeTheoJohnson · Pull Request #5871 · plotly/plotly.py;
Headings (most frequently used words):
uh, oh, empty, an, navigation, to, keep, axis, spanning, shapes, on, subplot, selected, by, row, and, col, plotly, py, luketheojohnson, fix, add, hline, branch, footer, loading, this, 5871, menu, repository, 5871luketheojohnson, wants, merge, commits, intoplotly, mainplotly, mainfrom, subplotsluketheojohnson, subplotscopy, head, name, clipboard, conversation, commented, nov, 2026, edited, there, was, error, while, please, reload, page, link, issue, description, of, change, demo, testing, strategy, additional, information, optional, guidelines, has, not, been, deployed, reviewers, assignees, labels, projects, milestone, development, participants,
Text of the page (most frequently used words):
and (27), this (22), the (20), github (13), empty (13), #plotly (13), applied (11), for (10), luketheojohnson (10), row (10), col (10), code (9), was (9), fig (9), that (8), pull (8), add (8), subplot (8), suggestion (7), cannot (7), suggestions (7), while (7), request (7), reload (7), shapes (7), subplots (7), main (7), not (6), 2026 (6), from (6), change (6), review (6), all (6), you (5), can (5), security (5), please (5), single (5), one (5), there (5), loading (5), add_hline (5), make_subplots (5), koolade85 (5), sign (5), changelog (5), axis (5), selected (5), check (4), merge (4), error (4), page (4), have (4), keep (4), spanning (4), commits (4), with (4), copy (4), fix (4), hline (4), 5871 (4), your (4), support (4), copilot (4), navigation (3), line (3), batch (3), none (3), requested (3), conversation (3), hidden (3), characters (3), unicode (3), open (3), learn (3), more (3), branch (3), november (3), documentation (3), explicit (3), exclude_empty_subplots (3), tests (3), layout (3), len (3), print (3), cols (3), rows (3), quality (3), another (3), tab (3), window (3), refresh (3), session (3), developers (3), customer (3), enterprise (3), grade (3), features (3), build (3), information (2), community (2), status (2), footer (2), now (2), has (2), been (2), marked (2), commit (2), only (2), changes (2), because (2), may (2), these (2), issues (2), development (2), milestone (2), yet (2), projects (2), required (2), file (2), bidirectional (2), what (2), about (2), self (2), nov (2), entry (2), added (2), reviewed (2), guidelines (2), cell (2), default (2), when (2), pass (2), selections (2), several (2), still (2), skip (2), plus (2), are (2), changed (2), files (2), ruff (2), grid (2), out (2), prints (2), link (2), wants (2), into (2), head (2), name (2), clipboard (2), insights (2), actions (2), 649 (2), repository (2), signed (2), universe (2), training (2), integrations (2), stories (2), center (2), business (2), fixes (2), products (2), secret (2), perform, action, time, share, personal, manage, cookies, contact, docs, privacy, terms, inc, right, back, later, queued, multi, comments, pending, reviews, resolved, outdated, must, existing, order, create, valid, applying, deleted, lines, supported, per, viewing, subset, closed, invalid, were, made, participants, working, populated, successfully, merging, close, labels, assignees, least, approving, awaiting, reviewers, already, account, comment, join, free, show, contains, text, interpreted, compiled, differently, than, appears, below, editor, reveals, deployments, deployed, assigned, ready, 076cd1c, number, c56b97e, reactions, sorry, something, went, wrong, needed, prs, confirm, follows, them, conduct, used, claude, help, write, tested, myself, blank, draws, too, facet_col_wrap, also, ignored, told, apart, keeping, would, mean, changing, sentinel, true, before, shape, dropped, without, warning, even, workaround, covering, ones, false, additional, optional, under, same, failures, clean, codegen, output, matches, committed, _figurewidget, _figure, format, test_optional, test_autoshapes, test_subplots, test_figure_factory, test_px, test_core, new, run, four, methods, against, column, list, where, other, secondary, facet, fail, two, skipped, range, keeps, its, indexerror, test_axis_span_shapes, testing, strategy, import, demo, ignore, select, suggested, here, add_vrect, add_hrect, add_vline, description, 5136, closes, issue, contributor, markdown, commented, edited, checks, items, requests, message, dismiss, alert, switched, accounts, appearance, settings, search, pricing, event, talks, workshops, next, partners, company, forum, events, webinars, blog, resource, connect, resources, premium, advanced, ons, trust, why, evaluate, see, industries, government, manufacturing, financial, services, healthcare, industry, nonprofits, startups, team, enterprises, stage, businesses, source, latest, improvements, across, place, developer, articles, sponsors, trending, repos, explore, customize, certifications, scanning, leak, prevention, protection, vulnerability, detection, remediation, secure, cloud, environments, codespaces, analysis, enforcement, automation, ship, coding, agent, tasks, automated, work, hosting, collaboration, platform, menu, content,
Text of the page (random words):
keep axis spanning shapes on an empty subplot selected by row and col by luketheojohnson pull request 5871 plotly plotly py github skip to content navigation menu sign in products platform github repository hosting code review and collaboration copilot ai coding agent for tasks projects and automated work build ship actions ci cd and automation code quality quality analysis fixes and enforcement codespaces cloud development environments secure code security vulnerability detection and remediation secret protection secret scanning and leak prevention all features developers learn documentation training certifications build build with copilot customize copilot integrations explore trending repos github sponsors developer articles changelog changelog your source for the latest features improvements and fixes across github products all in one place businesses by stage enterprises team startups nonprofits by industry healthcare financial services manufacturing government see all industries evaluate github why github customer stories business insights trust center add ons github advanced security enterprise grade code security copilot for business enterprise grade ai features premium support enterprise grade 24 7 support resources learn connect documentation resource center blog events webinars community forum customer stories integrations support customer support training github status company about partners changelog github universe github universe the event for developers by developers talks workshops and what s next for github pricing search sign in sign up appearance settings you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message plotly plotly py repository navigation code issues 649 649 pull requests 87 87 actions security and quality insights more items keep axis spanning shapes on an empty subplot selected by row and col 5871 5871 open luketheojohnson wants to merge 2 commits into plotly main plotly plotly py main from luketheojohnson fix add hline empty subplots luketheojohnson plotly py fix add hline empty subplots copy head branch name to clipboard conversation commits 2 2 checks files changed open keep axis spanning shapes on an empty subplot selected by row and col 5871 luketheojohnson wants to merge 2 commits into plotly main plotly plotly py main from luketheojohnson fix add hline empty subplots luketheojohnson plotly py fix add hline empty subplots copy head branch name to clipboard conversation luketheojohnson commented nov 6 2026 edited loading uh oh there was an error while loading please reload this page copy link copy markdown contributor link to issue closes 5136 description of change change add_hline add_vline add_hrect and add_vrect to ignore exclude_empty_subplots when row and col select a single subplot as suggested here demo from plotly subplots import make_subplots fig make_subplots rows 1 cols 1 fig add_hline y 0 5 print len fig layout shapes fig make_subplots rows 2 cols 2 fig add_hline y 0 5 row 2 col 1 print len fig layout shapes fig make_subplots rows 2 cols 2 fig add_hline y 0 5 print len fig layout shapes on main this prints 0 0 0 with this change it prints 1 1 0 testing strategy new tests in test_axis_span_shapes py run all four methods against a single subplot an explicit row col col all on a one column grid and list selections plus a grid where the other cell is none an empty secondary axis and an empty facet these 19 fail on main and pass with this change two more check that several empty subplots are still skipped and one that an out of range row keeps its indexerror tests test_core plus test_px test_figure_factory test_subplots and test_autoshapes under tests test_optional have the same failures as main ruff check and ruff format check are clean on the changed files and codegen output matches the committed _figure py and _figurewidget py additional information optional before the shape was dropped without warning if the selected subplot was empty even when it was the only one or was requested by row and col the workaround was to pass exclude_empty_subplots false selections covering several subplots still skip empty ones an explicit exclude_empty_subplots true is also ignored for a single subplot because it can t be told apart from the default keeping it would mean changing the default to a sentinel an explicit row col on a blank facet_col_wrap cell now draws there too i used claude code to help write this change i ve reviewed and tested it myself guidelines i have reviewed the pull request guidelines and the code of conduct and confirm that this pr follows them i have added an entry to the changelog if needed not required for documentation prs sorry something went wrong uh oh there was an error while loading please reload this page all reactions luketheojohnson added 2 commits november 6 2026 21 36 keep axis spanning shapes on an empty subplot selected by row and col c56b97e add pr number to changelog entry 076cd1c luketheojohnson marked this pull request as ready for review november 6 2026 09 00 koolade85 self requested a review november 9 2026 20 53 koolade85 self assigned this nov 9 2026 this branch has not been deployed no deployments this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters sign up for free to join this conversation on github already have an account sign in to comment reviewers koolade85 awaiting requested review from koolade85 at least 1 approving review is required to merge this pull request uh oh there was an error while loading please reload this page assignees koolade85 labels none yet projects none yet milestone no milestone development successfully merging this pull request may close these issues add_hline not working for make_subplots if not populated uh oh there was an error while loading please reload this page 2 participants add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge suggestion cannot be applied right now please check back later footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time
|