Meta tags:
description=This PR splits the SensitiveStorage library in several files, one for each query. The *Query.qll naming convention has been followed, and the base CleartextStorageQuery.qll library has been general...;

Headings (most frequently used words):

uh, oh, commented, 2021, sep, atorralba, loading, aug, github, actions, bot, 23, saved, searches, java, refactor, cleartext, storage, queries, 6493, navigation, footer, 17, edited, there, was, an, error, while, please, reload, this, page, aschackmull, search, code, repositories, users, issues, pull, requests, provide, feedback, menu, use, to, filter, your, results, more, quickly, conversation, 22, reviewers, assignees, labels, projects, milestone, development, participants,

Text of the page (most frequently used words):
this (47), the (46), 2021 (29), #github (27), atorralba (24), while (22), reload (22), was (21), #loading (21), please (20), there (20), java (20), error (19), page (19), code (18), sep (17), aschackmull (16), storage (16), all (16), and (16), security (15), cleartext (14), query (13), applied (12), changes (12), for (12), refactor (12), you (11), resolved (11), view (11), reviewed (11), from (10), merged (10), link (10), pull (9), sign (9), sorry (9), something (9), went (9), wrong (9), reactions (9), commented (9), contributor (9), copy (9), your (8), differences (8), can (7), suggestion (7), cannot (7), suggestions (7), branch (7), qll (7), queries (7), actions (7), that (6), change (6), show (6), sensitive (6), reports (6), aug (6), enterprise (6), not (5), community (5), request (5), outdated (5), issues (5), documentation (5), review (5), hide (5), lib (5), semmle (5), workflow (5), search (5), information (4), navigation (4), has (4), been (4), create (4), commit (4), were (4), these (4), note (4), have (4), account (4), september (4), main (4), cleartextstoragequery (4), compare (4), force (4), pushed (4), commits (4), with (4), performance (4), new (4), base (4), bot (4), available (4), run (4), open (4), 6493 (4), support (4), manage (3), 2026 (3), now (3), line (3), comments (3), add (3), batch (3), one (3), may (3), projects (3), conversation (3), into (3), author (3), library (3), added (3), are (3), after (3), head (3), compared (3), framework (3), coverage (3), hidden (3), characters (3), unicode (3), about (3), insights (3), models (3), requests (3), signed (3), settings (3), codeql (3), another (3), tab (3), window (3), refresh (3), session (3), saved (3), use (3), feedback (3), grade (3), features (3), platform (3), solutions (3), explore (3), contact (2), privacy (2), terms (2), footer (2), must (2), deleted (2), single (2), development (2), milestone (2), does (2), need (2), required (2), labels (2), approved (2), already (2), free (2), b52a2cd (2), users (2), com (2), cleartextstoragecookiequery (2), d0b9920 (2), instead (2), sinks (2), better (2), fix (2), encryption (2), sanitizer (2), remove (2), cached (2), sensitivesource (2), reaction (2), reacted (2), emoji (2), sure (2), why (2), evaluation (2), took (2), but (2), edited (2), should (2), android (2), 710a9f3 (2), generated (2), will (2), picked (2), nightly (2), job (2), gets (2), found (2), comparison (2), artifact (2), artifacts (2), august (2), changed (2), files (2), generalized (2), file (2), bidirectional (2), more (2), jump (2), our (2), issue (2), discussions (2), appearance (2), cancel (2), see (2), searches (2), repositories (2), copilot (2), business (2), advanced (2), developer (2), topics (2), archive (2), source (2), customer (2), services (2), devops (2), build (2), web (2), capture (2), jan (2), perform, action, time, share, personal, cookies, docs, status, inc, right, check, back, later, queued, merge, multi, pending, reviews, marked, existing, order, valid, applying, lines, supported, only, per, viewing, subset, closed, invalid, because, made, participants, successfully, merging, close, none, yet, assigned, assignees, reviewers, comment, join, a031b2a, thanks, authored, anders, schack, mulligen, noreply, apply, b12a0b7, discards, exprs, sources, precision, 51d2b52, property, flowsto, 563e8a2, unused, a30554e, refactored, libraries, eyes, perf, eval, still, integration, tests, failing, though, done, apparently, negative, impact, 164s, 223s, seems, like, normal, tradeoff, depending, which, runs, first, plus, 60s, improvement, cleartextstoragecookie, cleartextstorageproperties, thumbs, definitely, characteristics, longer, makes, sense, perfectly, fine, make, thorough, flowstocached, databases, 6492, promote, using, sharedpreferences, experimental, 6468, referenced, label, rebase, building, top, previous, prs, facilitate, recent, removed, previously, reported, d590906, filesystem, 6576, mentioned, times, most, recently, 4dbd67f, title, requested, owner, team, splits, several, each, naming, convention, followed, extensible, sanitizers, taint, steps, being, used, shared, preferences, also, benefit, sensitivestorage, contains, text, interpreted, compiled, differently, than, what, appears, below, editor, reveals, learn, checks, bottom, clicking, agree, occasionally, send, related, emails, statement, service, its, maintainers, question, project, additional, options, 376, 916, star, fork, notification, notifications, public, message, dismiss, alert, switched, accounts, out, resetting, focus, qualifiers, name, filter, results, quickly, submit, include, email, address, contacted, read, every, piece, take, input, very, seriously, provide, syntax, tips, clear, pricing, premium, ons, powered, collections, trending, program, accelerator, maintainer, lab, programs, fund, developers, sponsors, partners, trust, center, forum, skills, ebooks, events, webinars, stories, type, software, topic, resources, industries, government, manufacturing, financial, healthcare, industry, cases, devsecops, app, modernization, case, nonprofits, startups, small, medium, teams, enterprises, company, size, marketplace, changelog, blog, stop, leaks, before, they, start, secret, protection, secure, find, vulnerabilities, application, plan, track, work, instant, dev, environments, codespaces, automate, any, workflows, integrate, external, tools, mcp, registry, prompts, deploy, intelligent, apps, spark, write, creation, toggle, menu, skip, content, wayback, machine, http, org, 20260110163226, https, timestamps, fail, success, 2027, 2025, feb, dec,

Text of the page (random words):
java refactor cleartext storage queries by atorralba pull request 6493 github codeql github 1 capture 10 jan 2026 dec jan feb 10 2025 2026 2027 success fail about this capture timestamps the wayback machine http web archive org web 20260110163226 https github com github codeql pull 6493 skip to content navigation menu toggle navigation sign in appearance settings platform ai code creation github copilot write better code with ai github spark build and deploy intelligent apps github models manage and compare prompts mcp registry new integrate external tools developer workflows actions automate any workflow codespaces instant dev environments issues plan and track work code review manage code changes application security github advanced security find and fix vulnerabilities code security secure your code as you build secret protection stop leaks before they start explore why github documentation blog changelog marketplace view all features solutions by company size enterprises small and medium teams startups nonprofits by use case app modernization devsecops devops ci cd view all use cases by industry healthcare financial services manufacturing government view all industries view all solutions resources explore by topic ai software development devops security view all topics explore by type customer stories events webinars ebooks reports business insights github skills support services documentation customer support community forum trust center partners open source community github sponsors fund open source developers programs security lab maintainer community accelerator archive program repositories topics trending collections enterprise enterprise solutions enterprise platform ai powered developer platform available add ons github advanced security enterprise grade security features copilot for business enterprise grade ai features premium support enterprise grade 24 7 support pricing search or jump to search code repositories users issues pull requests search clear search syntax tips provide feedback we read every piece of feedback and take your input very seriously include my email address so i can be contacted cancel submit feedback saved searches use saved searches to filter your results more quickly name query to see all available qualifiers see our documentation cancel create saved search sign in sign up appearance settings resetting focus you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session you switched accounts on another tab or window reload to refresh your session dismiss alert message github codeql public notifications you must be signed in to change notification settings fork 1 9k star 9 1k code issues 916 pull requests 376 discussions actions projects 0 models security uh oh there was an error while loading please reload this page insights additional navigation options code issues pull requests discussions actions projects models security insights java refactor cleartext storage queries 6493 new issue have a question about this project sign up for a free github account to open an issue and contact its maintainers and the community sign up for github by clicking sign up for github you agree to our terms of service and privacy statement we ll occasionally send you account related emails already on github sign in to your account jump to bottom merged aschackmull merged 5 commits into github main from atorralba atorralba cleartext storage query refactor sep 23 2021 merged java refactor cleartext storage queries 6493 aschackmull merged 5 commits into github main from atorralba atorralba cleartext storage query refactor sep 23 2021 conversation 17 commits 5 checks 0 files changed uh oh there was an error while loading please reload this page conversation this file contains hidden or bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters copy link contributor atorralba commented aug 17 2021 edited loading uh oh there was an error while loading please reload this page this pr splits the sensitivestorage library in several files one for each query the query qll naming convention has been followed and the base cleartextstoragequery qll library has been generalized to have extensible sinks sanitizers and taint steps the encryption sanitizer that was being used in the shared preferences query has also been generalized and now all sensitive storage queries benefit from it sorry something went wrong uh oh there was an error while loading please reload this page all reactions atorralba requested a review from a team as a code owner august 17 2021 10 12 github actions bot added documentation java labels aug 17 2021 copy link contributor github actions bot commented aug 17 2021 ️ the head of this pr and the base branch were compared for differences in the framework coverage reports the generated reports are available in the artifacts of this workflow run the differences will be picked up by the nightly job after the pr gets merged the differences can be found in the comparison artifact of this workflow run all reactions sorry something went wrong uh oh there was an error while loading please reload this page atorralba changed the title java refactor sensitive storage queries java refactor cleartext storage queries aug 17 2021 atorralba force pushed the atorralba cleartext storage query refactor branch 2 times most recently from 4dbd67f to 710a9f3 compare august 23 2021 14 56 copy link contributor github actions bot commented aug 23 2021 ️ the head of this pr and the base branch were compared for differences in the framework coverage reports the generated reports are available in the artifacts of this workflow run the differences will be picked up by the nightly job after the pr gets merged the differences can be found in the comparison artifact of this workflow run all reactions sorry something went wrong uh oh there was an error while loading please reload this page atorralba mentioned this pull request aug 31 2021 java create new query cleartext storage of sensitive information in android filesystem 6576 merged atorralba force pushed the atorralba cleartext storage query refactor branch from 710a9f3 to d590906 compare september 3 2021 11 26 copy link contributor github actions bot commented sep 3 2021 ️ the head of this pr and the base branch were compared for differences in the framework coverage reports a recent commit removed the previously reported differences all reactions sorry something went wrong uh oh there was an error while loading please reload this page copy link contributor author atorralba commented sep 3 2021 force pushed to rebase this refactor to main instead of building on top of previous prs this should facilitate the review all reactions sorry something went wrong uh oh there was an error while loading please reload this page atorralba added the no change note required this pr does not need a change note label sep 3 2021 this was referenced sep 3 2021 java promote cleartext storage of sensitive information using sharedpreferences from experimental 6468 merged java create new query cleartext storage of sensitive information in android databases 6492 merged copy link contributor aschackmull commented sep 6 2021 this definitely changes the performance characteristics of these 3 queries and it no longer makes sense for sensitivesource flowstocached to be cached this may be perfectly fine but you should make sure to do a thorough performance evaluation 1 atorralba reacted with thumbs up emoji all reactions 1 reaction sorry something went wrong uh oh there was an error while loading please reload this page aschackmull reviewed sep 6 2021 view reviewed changes java ql lib semmle code java security cleartextstoragequery qll outdated show resolved hide resolved uh oh there was an error while loading please reload this page aschackmull reviewed sep 6 2021 view reviewed changes java ql lib semmle code java security cleartextstoragequery qll show resolved hide resolved uh oh there was an error while loading please reload this page copy link contributor author atorralba commented sep 22 2021 edited loading uh oh there was an error while loading please reload this page aschackmull performance evaluation done apparently there s no negative impact on performance after this pr cleartextstorageproperties ql took 164s but cleartextstoragecookie ql took 223s so it seems like a normal tradeoff depending on which query runs first plus a 60s improvement still not sure why the integration tests are failing though all reactions sorry something went wrong uh oh there was an error while loading please reload this page copy link contributor aschackmull commented sep 23 2021 do you have a link to the perf eval 1 atorralba reacted with eyes emoji all reactions 1 reaction sorry something went wrong uh oh there was an error while loading please reload this page atorralba added 4 commits september 23 2021 10 42 refactored cleartext storage libraries a30554e remove unused library 563e8a2 remove cached property from sensitivesource flowsto 51d2b52 fix encryption sanitizer d0b9920 it now discards sensitive exprs sources instead of sinks for better precision atorralba force pushed the atorralba cleartext storage query refactor branch from b12a0b7 to d0b9920 compare september 23 2021 08 42 aschackmull reviewed sep 23 2021 view reviewed changes java ql lib semmle code java security cleartextstoragecookiequery qll outdated show resolved hide resolved uh oh there was an error while loading please reload this page aschackmull reviewed sep 23 2021 view reviewed changes java ql lib semmle code java security cleartextstoragecookiequery qll outdated show resolved hide resolved uh oh there was an error while loading please reload this page aschackmull reviewed sep 23 2021 view reviewed changes java ql lib semmle code java security cleartextstoragequery qll outdated show resolved hide resolved uh oh there was an error while loading please reload this page apply code review comments b52a2cd co authored by anders schack mulligen aschackmull users noreply github com copy link contributor author atorralba commented sep 23 2021 thanks for your comments aschackmull applied in b52a2cd all reactions sorry something went wrong uh oh there was an error while loading please reload this page aschackmull approved these changes sep 23 2021 view reviewed changes aschackmull merged commit a031b2a into github main sep 23 2021 atorralba deleted the atorralba cleartext storage query refactor branch september 23 2021 14 46 sign up for free to join this conversation on github already have an account sign in to comment reviewers aschackmull aschackmull approved these changes assignees no one assigned labels documentation java no change note required this pr does not need a change note projects none yet milestone no milestone development successfully merging this pull request may close these issues uh oh there was an error while loading please reload this page 2 participants add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments suggestions cannot be applied while the pull request is queued to merge suggestion cannot be applied right now please check back later footer 2026 github inc footer navigation terms privacy security status community docs contact manage cookies do not share my personal information you can t perform that action at this time