Meta tags:
description=I accidentally -torcontrol=1 today (instead of -listenonion=1) and was confused that it was accepted, as the argument needs to be host:port. Expected outcome would be an error message and exiting. Useful skills: C++ Understanding of bitc...;

Headings (most frequently used words):

commented, nov, 2021, 25, shaavan, 26, bitcoin, init, torcontrol, argument, should, be, validated, 23589, public, comments, laanwj, amovfx, ityodadev, marcofalke, dakshp07, mar, 2022, edited, useful, skills, want, to, work, on, this, issue,

Text of the page (most frequently used words):
this (20), github (17), issue (17), 2021 (17), the (14), nov (14), #bitcoin (11), and (10), sign (9), #commented (8), copy (8), link (8), you (7), that (7), sorry (7), something (7), went (7), wrong (7), pull (6), comment (6), for (6), open (6), argument (6), jump (6), 2022 (5), laanwj (5), message (5), error (5), your (4), with (4), security (4), account (4), deleted (4), mar (4), shaavan (4), would (4), should (4), bitcoind (4), was (4), torcontrol (4), 23589 (4), issues (4), all (4), about (3), contact (3), add (3), function (3), successfully (3), request (3), may (3), requests (3), projects (3), p2p (3), good (3), first (3), labels (3), from (3), 23605 (3), contributor (3), when (3), expected (3), comments (3), init (3), validated (3), code (3), repository (3), signed (2), another (2), tab (2), window (2), refresh (2), session (2), reload (2), can (2), pricing (2), status (2), privacy (2), terms (2), util (2), torcontrolargumentcheck (2), close (2), linked (2), milestone (2), already (2), have (2), free (2), new (2), try (2), closed (2), mentioned (2), dec (2), help (2), member (2), please (2), exit (2), invalid (2), outcome (2), exiting (2), not (2), passed (2), initialization (2), host (2), port (2), contributing (2), opened (2), fixed (2), community (2), project (2), insights (2), education (2), plans (2), explore (2), web (2), out, perform, action, time, blog, training, api, docs, inc, participants, merging, none, yet, one, assigned, assignees, join, conversation, teresahodges764, hey, folks, very, codebase, wanted, hands, around, also, saw, targeting, what, update, still, edited, dakshp07, jan, 23914, abbasshafiei, 23818, uri44derr13, complaintid, wonders11, will, might, git, grep, initerror, marcofalke, gentle, ping, take, look, common, sense, suggest, there, some, other, than, ityodadev, args, manager, flags, supposed, amovfx, just, confirmation, command, initially, run, parameters, expect, occur, later, runtime, src, fact, raising, any, able, check, given, string, valid, pair, cannot, raise, wrongly, initializing, let, tackling, added, text, updated, but, these, errors, were, encountered, guidance, read, before, opening, want, work, understanding, core, sequence, useful, skills, accidentally, today, instead, confused, accepted, needs, listenonion, bottom, clicking, agree, our, occasionally, send, related, emails, statement, service, password, email, address, pick, username, its, maintainers, question, more, 430, 609, star, fork, notifications, public, organization, suggested, results, sales, compare, marketplace, stars, program, forum, events, readme, connect, others, source, guides, learning, lab, trending, collections, topics, learn, contribute, enterprise, team, customer, stories, sponsors, integrations, review, packages, codespaces, actions, mobile, features, product, skip, content, wayback, machine, http, archive, org, 20220321233341, https, com, timestamps, capture, fail, success, 2023, apr, feb, 2025, captures,

Text of the page (random words):
init torcontrol argument should be validated issue 23589 bitcoin bitcoin github 15 captures 26 nov 2021 05 mar 2025 feb mar apr 21 2021 2022 2023 success fail about this capture timestamps the wayback machine http web archive org web 20220321233341 https github com bitcoin bitcoin issues 23589 skip to content sign up product features mobile actions codespaces packages security code review issues integrations github sponsors customer stories team enterprise explore explore github learn and contribute topics collections trending learning lab open source guides connect with others the readme project events community forum github education github stars program marketplace pricing plans compare plans contact sales education in this repository all github jump to no suggested jump to results in this repository all github jump to in this organization all github jump to in this repository all github jump to sign in sign up message bitcoin bitcoin public notifications fork 31 9k star 62 6k code issues 609 pull requests 430 projects 7 security insights more code issues pull requests projects security insights new issue have a question about this project sign up for a free github account to open an issue and contact its maintainers and the community pick a username email address password sign up for github by clicking sign up for github you agree to our terms of service and privacy statement we ll occasionally send you account related emails already on github sign in to your account jump to bottom init torcontrol argument should be validated 23589 open laanwj opened this issue nov 25 2021 7 comments may be fixed by 23605 open init torcontrol argument should be validated 23589 laanwj opened this issue nov 25 2021 7 comments may be fixed by 23605 labels good first issue p2p comments copy link member laanwj commented nov 25 2021 i accidentally torcontrol 1 today instead of listenonion 1 and was confused that it was accepted as the argument needs to be host port expected outcome would be an error message and exiting useful skills c understanding of bitcoin core s initialization sequence want to work on this issue for guidance on contributing please read contributing md before opening your pull request the text was updated successfully but these errors were encountered laanwj added p2p good first issue labels nov 25 2021 copy link contributor shaavan commented nov 25 2021 let me try tackling this sorry something went wrong copy link contributor shaavan commented nov 25 2021 ok so i was able to add a function successfully that can check if the given string is a valid host port pair or not the issue is that i cannot raise an error when the argument is wrongly passed when initializing bitcoind in fact bitcoind is not raising an error for any invalid argument passed at initialization expected outcome would be an error message and exiting just a confirmation when the src bitcoind command is initially run with invalid parameters do we expect an error message and exit or is it expected to occur later in the runtime of bitcoind 2 sorry something went wrong copy link amovfx commented nov 25 2021 is the args manager flags supposed to help with this sorry something went wrong copy link ityodadev commented nov 26 2021 common sense would suggest there should be a message and some exit status other than 0 sorry something went wrong copy link contributor shaavan commented nov 26 2021 a gentle ping laanwj would you please take a look at this comment sorry something went wrong copy link member marcofalke commented nov 26 2021 git grep initerror might help you 3 sorry something went wrong shaavan linked a pull request that will close this issue nov 26 2021 util add torcontrolargumentcheck function 23605 open bitcoin deleted a comment from wonders11 nov 27 2021 bitcoin deleted a comment from complaintid nov 28 2021 uri44derr13 mentioned this issue dec 19 2021 23818 closed abbasshafiei mentioned this issue dec 30 2021 23914 closed bitcoin deleted a comment jan 5 2022 copy link dakshp07 commented mar 4 2022 edited hey folks i m very new to the codebase and wanted to try my hands around this issue also i saw a pr that is targeting this issue so what s the update on that is the issue still open sorry something went wrong bitcoin deleted a comment from teresahodges764 mar 10 2022 sign up for free to join this conversation on github already have an account sign in to comment assignees no one assigned labels good first issue p2p projects none yet milestone no milestone linked pull requests successfully merging a pull request may close this issue util add torcontrolargumentcheck function 6 participants 2022 github inc terms privacy security status docs contact github pricing api training blog about you can t perform that action at this time you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session