Meta tags:
description=Fixes #217;

Headings (most frequently used words):

this, to, the, 2017, comment, has, been, minimized, it, if, is, mar, westonruter, contributor, as, you, customize, sayedtaqui, draft, that, so, posts, when, from, data, trashed, and, post, trash, feb, 27, be, then, will, right, author, collaborator, publish, status, js, should, statuscontrol, wp, notification, restored, not, published, changeset, intended, think, saved, function, items, but, well, in, upon, xwp, show, 347, commented, with, actually, was, change, move, yes, good, want, sure, like, api, bind, panel, removetrashnotifications, featured, for, purge, saved_post_setting_values, component, maybe, other, or, explicit, snapshot, user, have, hit, save, don, unlikely, makes, remove, setting, probably, embedded, here, conversation, learn, contribute, connect, others, may, correct, how, about, changing, untrashed, changes, now, its, selected, back, avoid, trigger, even, updating, via, snapshots, only, run, whole, need, make, changeset_status, adapted, https, github, com, content, demo, blob, 8bf4d6531adb029fbaf1e4bebb967e57989d5edd, l148, l153, humm, code, also, being, used, purging, lines, 1110, 1116, 32c6d1a, update, client, settings, values, server, updatesettingsquietly, purgetrash, location, needs, updated, all, saving, an, publishing, can, ignore, edited, because, saves, any, would, eventually, get, they, know, way, better, experience, pretty, clearly, item, around, anymore, wanting, undo, removing, sections, sense, me, whenever, call, unbind, handler, after, runs, once, point, check, see, exists, re, doing, below, short, circuit, just, curious, why, deferred, needed, notifications, collection, exist, moment, control, initialized, wait, embedding, wasn, required,

Text of the page (most frequently used words):
this (41), the (27), 2017 (23), sign (20), #github (19), westonruter (17), mar (16), #customize (16), has (15), been (15), view (15), posts (15), you (14), comment (13), statuscontrol (11), minimized (11), from (10), changes (10), panel (10), that (9), applied (9), and (9), trash (9), status (8), for (8), sayedtaqui (8), function (8), api (7), contributor (7), notification (7), post (7), feb (7), suggestions (6), suggestion (6), code (6), pull (6), checks (6), collaborator (6), data (6), draft (6), when (6), jump (6), can (5), security (5), cannot (5), issue (5), merged (5), remove (5), author (5), will (5), trashed (5), publish (5), all (5), saved (5), restored (5), about (4), outdated (4), not (4), add (4), issues (4), have (4), account (4), 217 (4), details (4), travis (4), passed (4), deferred (4), right (4), embedded (4), should (4), notifications (4), then (4), bind (4), published (4), xwp (4), show (4), commits (4), 347 (4), your (3), with (3), contact (3), 2021 (3), line (3), change (3), batch (3), commit (3), request (3), none (3), yet (3), projects (3), conversation (3), enhancement (3), into (3), develop (3), loading (3), but (3), control (3), think (3), setting (3), suggested (3), move (3), upon (3), intended (3), items (3), well (3), changeset (3), project (3), actions (3), repository (3), signed (2), another (2), tab (2), window (2), refresh (2), session (2), reload (2), pricing (2), privacy (2), terms (2), deleted (2), lines (2), single (2), only (2), one (2), while (2), because (2), may (2), these (2), milestone (2), already (2), free (2), next (2), minor (2), release (2), build (2), continuous (2), integration (2), unbind (2), after (2), sure (2), here (2), why (2), don (2), trashnotificationcode (2), done (2), post_status (2), section (2), postdata (2), unlikely (2), probably (2), like (2), removetrashnotifications (2), trashpostnotification (2), message (2), yes (2), good (2), user (2), makes (2), added (2), update (2), hit (2), save (2), want (2), explicit (2), was (2), snapshot (2), other (2), maybe (2), purge (2), component (2), saved_post_setting_values (2), 32c6d1a (2), actually (2), https (2), com (2), featured (2), content (2), untrashed (2), now (2), its (2), back (2), avoid (2), 846 (2), php (2), review (2), commented (2), copy (2), link (2), open (2), community (2), insights (2), wiki (2), requests (2), education (2), plans (2), explore (2), web (2), jan (2), out, perform, action, time, blog, training, docs, inc, multi, comments, pending, reviews, marked, resolved, must, existing, order, create, valid, applying, supported, per, viewing, subset, closed, invalid, were, made, participants, successfully, merging, close, linked, labels, assigned, assignees, reviewers, join, modified, milestones, jun, branch, push, 621f875, hide, approved, tification, removed, e8a32cd, condition, wasn, required, just, curious, needed, collection, exist, moment, initialized, wait, embedding, check, see, exists, doing, below, short, circuit, l10n, point, whenever, call, handler, runs, once, 66bdd1a, text, way, better, experience, pretty, clearly, item, around, anymore, wanting, undo, removing, sections, sense, saves, any, would, eventually, get, they, know, edited, saving, publishing, ignore, location, needs, updated, purgetrash, updatesettingsquietly, client, settings, values, server, 1110, 1116, humm, also, being, used, purging, adapted, demo, blob, 8bf4d6531adb029fbaf1e4bebb967e57989d5edd, l148, l153, changeset_status, trigger, even, updating, via, snapshots, run, whole, need, make, setuppanelactions, correct, how, changing, selected, object, selector, public, enqueue_scripts, class, ready, event, happens, c5e2353, fixes, quote, reply, files, changed, bottom, clicking, agree, our, occasionally, send, related, emails, statement, service, password, email, address, pick, username, maintainers, question, new, more, fork, 148, star, watch, organization, results, nonprofit, sales, compare, marketplace, stars, program, forum, events, readme, connect, others, source, guides, learning, lab, trending, collections, topics, learn, contribute, enterprise, team, customer, stories, sponsors, integrations, management, packages, codespaces, mobile, features, skip, wayback, machine, http, archive, org, 20210122193903, timestamps, capture, fail, success, 2022, 2020, dec, oct, 2024, captures,

Text of the page (random words):
show notification when a post a restored from trash by sayedtaqui pull request 347 xwp wp customize posts github 3 captures 22 jan 2021 17 oct 2024 dec jan feb 22 2020 2021 2022 success fail about this capture timestamps the wayback machine http web archive org web 20210122193903 https github com xwp wp customize posts pull 347 skip to content sign up why github features mobile actions codespaces packages security code review project management integrations github sponsors customer stories security team enterprise explore explore github learn contribute topics collections trending learning lab open source guides connect with others the readme project events community forum github education github stars program marketplace pricing plans compare plans contact sales nonprofit education in this repository all github jump to no suggested jump to results in this repository all github jump to in this organization all github jump to in this repository all github jump to sign in sign up message xwp wp customize posts watch 61 star 148 fork 38 code issues 53 pull requests 10 actions projects 0 wiki security insights more code issues pull requests actions projects wiki security insights new issue have a question about this project sign up for a free github account to open an issue and contact its maintainers and the community pick a username email address password sign up for github by clicking sign up for github you agree to our terms of service and privacy statement we ll occasionally send you account related emails already on github sign in to your account jump to bottom show notification when a post a restored from trash 347 merged westonruter merged 4 commits into develop from enhancement issue 217 mar 3 2017 merged show notification when a post a restored from trash 347 westonruter merged 4 commits into develop from enhancement issue 217 mar 3 2017 conversation 12 commits 4 checks 0 files changed conversation copy link quote reply collaborator sayedtaqui commented feb 27 2017 fixes 217 sayedtaqui added 2 commits feb 27 2017 show trash notification if a post is restored from trash c5e2353 remove trash notifications if saved event happens loading status checks 32c6d1a copy link collaborator author sayedtaqui commented feb 27 2017 ready for review westonruter suggested changes feb 27 2017 view changes php class wp customize posts php outdated 846 6 846 7 public function enqueue_scripts __ customize object selector customize posts trashpostnotification __ this has been untrashed if you publish changes now this post will be published move back to trash to avoid this customize posts this comment has been minimized sign in to view westonruter feb 27 2017 contributor it may not actually be published if the post was a draft then it will be restored as a draft right this comment has been minimized sign in to view sayedtaqui mar 2 2017 author collaborator correct how about changing it to this this has been untrashed if you publish changes now its status will change to the selected status move back to trash to avoid this this comment has been minimized sign in to view westonruter mar 2 2017 contributor yes that s good js customize posts panel js 32 6 34 10 panel deferred embedded done function panel setuppanelactions api bind saved function this comment has been minimized sign in to view westonruter feb 27 2017 contributor this will trigger even when updating a changeset draft via customize snapshots is that intended if you want it to only run when the changeset is published as a whole then i think you need to make sure that the changeset status is publish like api bind saved function data if publish data changeset_status panel removetrashnotifications this is adapted from https github com xwp wp customize featured content demo blob 8bf4d6531adb029fbaf1e4bebb967e57989d5edd js featured items panel js l148 l153 humm but actually this code is also being used for purging the trashed items as well wp customize posts js customize posts js lines 1110 to 1116 in 32c6d1a purge trashed posts and update client settings with saved values from server api bind saved function data if data saved_post_setting_values component updatesettingsquietly data saved_post_setting_values component purgetrash so maybe that other location in customize posts needs to be updated as well or maybe this is all intended to purge the trashed items upon saving an explicit draft as well as upon publishing and if so you can ignore this comment this comment has been minimized sign in to view sayedtaqui mar 2 2017 edited author collaborator it was intended because if snapshot saves it as draft or any other status it would eventually get published when they publish the snapshot so the user should know this right this comment has been minimized sign in to view westonruter mar 2 2017 contributor i think the way you have it is a better experience if i hit move to trash and then hit save draft i pretty clearly don t want the trashed item around anymore and i m unlikely to be wanting to undo it so removing the trashed post sections upon explicit save makes sense to me update notification text loading status checks 66bdd1a westonruter added this to the next minor release milestone mar 3 2017 westonruter suggested changes mar 3 2017 view changes js customize posts panel js outdated statuscontrol setting bind function statuscontrol notifications remove panel trashnotificationcode this comment has been minimized sign in to view westonruter mar 3 2017 contributor so this will remove the notification whenever a user makes a change to the setting probably should call statuscontrol setting unbind to remove this function handler after it runs once right this comment has been minimized sign in to view sayedtaqui mar 3 2017 author collaborator yes good point js customize posts panel js message api posts data l10n trashpostnotification statuscontrol api control postdata section id post_status this comment has been minimized sign in to view westonruter mar 3 2017 contributor it s unlikely but this should probably check to see if statuscontrol exists like you re doing in removetrashnotifications below and if not then short circuit 1 js customize posts panel js outdated statuscontrol api control postdata section id post_status statuscontrol deferred embedded done function statuscontrol notifications add panel trashnotificationcode notification this comment has been minimized sign in to view westonruter mar 3 2017 contributor just curious why the statuscontrol deferred embedded is needed here the statuscontrol notifications collection should exist from the moment that a control is initialized so i don t think that you have to wait for embedding this comment has been minimized sign in to view sayedtaqui mar 3 2017 author collaborator i wasn t sure but right embedded is not required here remove deferred add condition for statuscontrol and unbind after no loading status checks e8a32cd tification has been removed westonruter approved these changes mar 3 2017 view changes hide details view details westonruter merged commit 621f875 into develop mar 3 2017 2 checks passed 2 checks passed continuous integration travis ci pr the travis ci build passed details continuous integration travis ci push the travis ci build passed details westonruter deleted the enhancement issue 217 branch mar 3 2017 westonruter modified the milestones next minor release 0 8 6 jun 7 2017 sign up for free to join this conversation on github already have an account sign in to comment reviewers westonruter assignees no one assigned labels none yet projects none yet milestone 0 8 6 linked issues successfully merging this pull request may close these issues none yet 2 participants add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on multi line comments 2021 github inc terms privacy security status docs contact github pricing api training blog about you can t perform that action at this time you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session