Meta tags:
description=The accessibility team has concerns about the implementation of this functionality by default, as we expressed previously in ticket htt????/core.trac.wordpress.org/ticket/12423. Our main concern is that Codemirror is not accessible for s...;

Headings (most frequently used words):

commented, aug, 2017, 16, westonruter, melchoyce, rianrietveld, edited, 17, cedon, 15, 18, add, option, to, enable, disable, codemirror, 29, samikeijonen, wordpress, better, code, editing, public, archive, comments, sergeybiryukov,

Text of the page (most frequently used words):
the (88), aug (36), 2017 (36), something (33), this (29), link (29), commented (27), copy (27), for (26), sorry (26), went (26), wrong (26), westonruter (19), #disable (17), like (17), that (16), member (15), and (15), user (15), screen (15), would (14), text (14), out (13), github (13), code (13), editor (13), opt (13), with (12), syntax (12), you (11), can (11), accessibility (11), settings (11), not (10), profile (10), melchoyce (10), users (9), codemirror (9), rianrietveld (9), your (8), issue (8), css (8), add (8), mode (7), help (7), enable (7), time (6), about (6), also (6), having (6), all (6), could (6), option (6), there (6), highlighting (6), highlighter (6), collaborator (6), issues (6), jump (6), wordpress (6), sign (5), edited (5), then (5), plugin (5), added (5), reader (5), but (5), from (5), security (4), none (4), pull (4), closed (4), customizer (4), define (4), true (4), new (4), use (4), are (4), here (4), cedon (4), will (4), some (4), author (4), too (4), editing (4), customiser (4), being (4), should (4), one (4), them (4), options (4), maybe (4), setting (4), idea (4), better (4), has (4), repository (4), yet (3), requests (3), projects (3), enhancement (3), have (3), please (3), because (3), does (3), disallow_file_edit (3), well (3), adding (3), feature (3), disabled (3), via (3), which (3), off (3), these (3), review (3), mentioned (3), just (3), back (3), case (3), work (3), plain (3), sentence (3), open (3), only (3), people (3), when (3), samikeijonen (3), functionality (3), theme (3), editors (3), first (3), was (3), since (3), know (3), good (3), widgets (3), visual (3), more (3), expect (3), checkbox (3), https (3), org (3), ticket (3), comments (3), actions (3), signed (2), another (2), tab (2), window (2), refresh (2), session (2), reload (2), pricing (2), contact (2), 2022 (2), successfully (2), may (2), milestone (2), labels (2), assignees (2), see (2), custom (2), html (2), widget (2), don (2), really (2), implemented (2), filters (2), think (2), flag (2), fresh (2), install (2), disallow_syntax_highlight (2), config (2), php (2), merged (2), going (2), end (2), fine (2), thought (2), useful (2), under (2), question (2), make (2), page (2), thanks (2), wouldn (2), other (2), agree (2), their (2), discover (2), how (2), resolved (2), though (2), note (2), pointer (2), pointers (2), what (2), rather (2), kind (2), building (2), get (2), suggested (2), announcement (2), exists (2), majority (2), benefit (2), aren (2), default (2), they (2), much (2), group (2), sure (2), using (2), seems (2), find (2), ideas (2), sergeybiryukov (2), live (2), somewhere (2), else (2), entirely (2), personal (2), core (2), trac (2), 12423 (2), essential (2), accessible (2), team (2), opened (2), insights (2), wiki (2), archive (2), education (2), plans (2), explore (2), web (2), perform, action, blog, training, api, docs, status, privacy, terms, inc, participants, merging, request, close, linked, already, account, subscribe, conversation, free, follow, questions, apply, additional, compelling, reason, constant, configure, truly, filter, key, always, return, along, hiding, alternatively, currently, turn, nevertheless, need, revisited, __return_false, customizer_custom_css_codemirror_opts, plugin_editor_codemirror_opts, theme_editor_codemirror_opts, wrap, display, false, syntax_highlighter, get_user_metadata, improve, integration, than, best, both, worlds, allow, might, switch, around, order, reopened, again, still, needs, mark, themes, plugins, location, merge, propose, focus, probably, enough, favour, vital, lot, coders, love, visit, often, few, things, proposed, post, wait, gutenberg, once, definitely, set, show, either, installs, normally, appear, upon, upgrading, announcing, instructs, btw, announcements, called, normal, circumstances, favor, err, side, assistive, technology, path, least, resistance, business, putting, ramp, person, wheelchair, inside, hurdle, why, thing, pops, initial, way, draws, attention, fact, label, vast, who, likely, never, encounter, wager, most, visiting, frequently, tweak, given, checking, informs, preference, decisions, prefer, posted, hidden, readers, allows, fan, ones, through, extra, hoop, makes, disabling, remove, period, match, removing, second, feels, singling, particular, say, point, sense, cool, thinking, self, assigned, notification, letting, folks, each, turns, pages, contain, wants, rid, afercia, next, rian, hard, didn, even, couple, months, ago, put, slack, channel, come, checkboxes, customisation, such, those, removed, future, writing, yeah, although, solve, alternately, where, panel, design, updated, errors, were, encountered, installed, coder, very, points, view, comment, 133, example, posts, part, parts, regular, non, coding, fall, current, fully, our, main, concern, concerns, implementation, expressed, previously, star, fork, notifications, public, been, archived, owner, now, read, message, organization, results, sales, compare, marketplace, stars, program, community, forum, events, readme, project, connect, others, source, guides, learning, lab, trending, collections, topics, learn, contribute, enterprise, customer, stories, sponsors, integrations, packages, codespaces, mobile, features, product, skip, content, wayback, machine, http, 20220320103541, com, timestamps, capture, fail, success, 2023, 2021, apr, mar, feb, nov, 2020, oct, 2024, captures,

Text of the page (random words):
add option to enable disable codemirror issue 29 wordpress better code editing github 4 captures 18 nov 2020 14 oct 2024 feb mar apr 20 2021 2022 2023 success fail about this capture timestamps the wayback machine http web archive org web 20220320103541 https github com wordpress better code editing issues 29 skip to content sign up product features mobile actions codespaces packages security code review issues integrations github sponsors customer stories team enterprise explore explore github learn and contribute topics collections trending learning lab open source guides connect with others the readme project events community forum github education github stars program marketplace pricing plans compare plans contact sales education in this repository all github jump to no suggested jump to results in this repository all github jump to in this organization all github jump to in this repository all github jump to sign in sign up message this repository has been archived by the owner it is now read only wordpress better code editing public archive notifications fork 16 star 35 code issues 5 pull requests 0 actions projects 1 wiki security insights more code issues pull requests actions projects wiki security insights add option to enable disable codemirror 29 closed rianrietveld opened this issue aug 15 2017 26 comments closed add option to enable disable codemirror 29 rianrietveld opened this issue aug 15 2017 26 comments assignees labels enhancement comments copy link member rianrietveld commented aug 15 2017 the accessibility team has concerns about the implementation of this functionality by default as we expressed previously in ticket https core trac wordpress org ticket 12423 our main concern is that codemirror is not accessible for screen reader users there should be an option to enable disable codemirror by the user to fall back to the current fully accessible plain text mode in the case of the theme and plugin editor and the css editor for the customiser it can be an opt out because these aren t essential parts of using wordpress for a regular non coding user if codemirror is going to be implemented in for example the text editor for posts or the html widget it has to be an opt in the text editor there is an essential part of wp s functionality on a personal note i ve installed the plugin and it s really good work as a coder i like it very much my personal points of view are at https core trac wordpress org ticket 12423 comment 133 the text was updated successfully but these errors were encountered copy link collaborator melchoyce commented aug 15 2017 thanks rianrietveld i ll add some opt out design ideas in here where in the customizer css panel and the code editors would you expect to find this checkbox sorry something went wrong copy link collaborator melchoyce commented aug 15 2017 alternately would you expect this checkbox to live somewhere else entirely like user settings sorry something went wrong copy link member sergeybiryukov commented aug 16 2017 would you expect this checkbox to live somewhere else entirely like user settings maybe an enable accessibility mode link in screen options like on widgets screen sorry something went wrong copy link member author rianrietveld commented aug 16 2017 edited sergeybiryukov yeah that s an idea for the theme plugin editor not sure about the enable accessibility mode maybe just disable syntax highlighter although this would not solve the issue for the customizer what about adding it to the the user settings your profile as it has more checkboxes for customisation like disable the visual editor when writing and such or will those settings all be removed in the future in the customiser css help text we then could add something like the syntax highlighter can be disabled with the settings in your profile i ve put this question in the accessibility slack channel maybe more people can come up with ideas sorry something went wrong copy link samikeijonen commented aug 16 2017 screen options is kind of hard to find i didn t even know there was accessibility mode for widgets couple months ago user profile seems better idea next to disable visual editor like rian mentioned in the customiser css help text we then could add something like the syntax highlighter can be disabled with the settings in your profile good idea sorry something went wrong copy link member westonruter commented aug 16 2017 i know that afercia wants to get rid of the accessibility mode screen option for widgets i like the setting being on the user profile screen like the opt out setting exists for the visual editor sorry something went wrong copy link collaborator melchoyce commented aug 16 2017 i thought about screen options at first too but it turns out none of the pages that contain code editors have them user setting notification letting folks know they can disable on each editor screen seems like a good idea sorry something went wrong copy link member westonruter commented aug 16 2017 i ll open a pr with this sorry something went wrong westonruter self assigned this aug 16 2017 copy link collaborator melchoyce commented aug 16 2017 cool i m thinking in user settings does that make sense sorry something went wrong copy link samikeijonen commented aug 16 2017 i m not sure does it have to say if you re using a screen reader i rather not point out some group of people sorry something went wrong copy link collaborator melchoyce commented aug 16 2017 i m fine with removing the second sentence if it feels too much like singling out a particular group we should also remove the period from the end to match the other settings 3 sorry something went wrong westonruter mentioned this issue aug 16 2017 add user setting for disabling syntax highlighting 31 merged copy link member westonruter commented aug 16 2017 please review 31 sorry something went wrong copy link cedon commented aug 16 2017 i m not a fan of having screen reader users be the ones to jump through an extra hoop though having opt out makes them do just that i would prefer it be an opt in on the screen melchoyce posted maybe add a one time announcement to the editor too hidden from screen readers that allows them to enable it from there when they use it for the first time sorry something went wrong copy link member westonruter commented aug 16 2017 if it is opt in then the vast majority of users who would benefit from the new feature would likely never encounter it since i ll wager most users aren t visiting their profile frequently to discover new settings to tweak also given decisions not options since the majority of users would benefit from having syntax highlighting checking i think it should be opt in by default with screen reader text that informs of the user preference to disable the syntax highlighting sorry something went wrong melchoyce added the enhancement label aug 16 2017 westonruter closed this in 31 aug 16 2017 copy link cedon commented aug 16 2017 westonruter that s why i also suggested the one time announcement thing that pops up on initial use that way it draws attention to the fact this feature exists under normal circumstances i would be in favor of it being opt out but since it s an accessibility issue i would rather err on the side of assistive technology users having the path of least resistance it s kind of like a business putting a ramp at the back of the building a person in a wheelchair can get inside the building but it s an added hurdle for them sorry something went wrong copy link member westonruter commented aug 16 2017 edited btw the one time announcements are called pointers in wp what if there was a one time pointer announcing syntax highlighting which then instructs how to opt out note that the pointer wouldn t help in either case for new installs as pointers normally only appear upon upgrading sorry something went wrong copy link cedon commented aug 16 2017 edited can it be set to show on first use of the editor as well once the accessibility issues are resolved it should definitely go to opt out though sorry something went wrong copy link member westonruter commented aug 16 2017 codemirror is not being proposed here for the post editor yet for that we wait for gutenberg and codemirror accessibility issues being resolved 1 sorry something went wrong copy link member author rianrietveld commented aug 17 2017 edited a few things i m in favour of an opt out here it s not vital wp functionality a lot of coders will love it and i agree with westonruter that users don t visit their profile often to discover it but a sentence in on the css customiser page and some text on the theme plugin editors on how to disable it will be useful i wouldn t focus on screen reader users only probably also other people would like to disable it too i agree with samikeijonen the text disable syntax highlighting when editing code is enough sorry something went wrong copy link member author rianrietveld commented aug 17 2017 thanks westonruter for the pr and the merge propose for the help text something like in the settings of your user profile you can disable the code syntax highlighter and work in plain text mode and make disable the code syntax highlighter a link to the settings page location in the help text of themes and plugins in the help under the question mark with the css customizer 1 sorry something went wrong copy link member author rianrietveld commented aug 17 2017 westonruter is it useful to open this again because still some help text needs to be added sorry something went wrong melchoyce reopened this aug 17 2017 copy link collaborator melchoyce commented aug 17 2017 i might switch around the order of your sentence you can disable the code syntax highlighter in your user profile this will allow you to work in plain text mode 2 sorry something went wrong copy link cedon commented aug 17 2017 if it s just going to be the code editor on the back end than an opt out would be fine in that case here s a best of both worlds thought could something be added to wp config php to flag it as off on a fresh install something like define disallow_syntax_highlight true also would having define disallow_file_edit true disable it as well sorry something went wrong westonruter mentioned this issue aug 18 2017 improve accessibility of custom css integration 34 merged copy link member westonruter commented aug 18 2017 rianrietveld melchoyce please review 34 sorry something went wrong copy link member westonruter commented aug 18 2017 could something be added to wp config php to flag it as off on a fresh install something like define disallow_syntax_highlight true i don t really see a compelling reason for adding a new constant to configure this if the feature truly is to be disabled for all users then this could be implemented via a plugin which could filter get_user_metadata for the syntax_highlighter key and always return false along with hiding the option in the user profile screen via user syntax highlighting wrap display none or alternatively there are currently filters for theme_editor_codemirror_opts plugin_editor_codemirror_opts and customizer_custom_css_codemirror_opts which you can use to turn off codemirror via adding __return_false nevertheless i think these filters may need to be revisited also would having define disallow_file_edit true disable it as well no because disallow_file_edit does not apply to custom html widget or additional css in the customizer 1 sorry something went wrong westonruter closed this in 34 aug 18 2017 copy link member westonruter commented aug 18 2017 edited please see 37 for follow up questions on accessibility sorry something went wrong sign up for free to subscribe to this conversation on github already have an account sign in assignees westonruter labels enhancement projects none yet milestone no milestone linked pull requests successfully merging a pull request may close this issue none yet 6 participants 2022 github inc terms privacy security status docs contact github pricing api training blog about you can t perform that action at this time you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session