Meta tags:
description=What version of protobuf and what language are you using? libprotoc 3.3.0 / Grpc.Tools 2.28.1 What operating system (Linux, Windows, ...) and version? Windows 10 Build 1803 What did you do? Create test.rsp containing non-ascii: --plugin=...;

Headings (most frequently used words):

commented, falco20019, jun, 2022, argument, file, needs, support, for, multi, char, and, bom, 7474, footer, may, 2020, jtattermusch, 2021, comments, edited, jd, cstx, apr, 20, 27, tonydnewell, jul, navigation,

Text of the page (most frequently used words):
the (33), this (29), protobuf (27), grpc (22), and (22), github (19), 2022 (15), std (15), for (14), issue (14), all (14), #protoc (13), 7474 (13), tools (12), utf (12), #tonydnewell (11), you (10), that (10), fix (10), com (10), not (10), sign (9), pull (8), from (8), protocolbuffers (8), authored (8), reactions (8), bom (8), link (8), 17995 (7), google (7), file (7), string (7), code (7), commented (7), copy (7), 2021 (7), falco20019 (7), with (6), fowles (6), merge (6), paths (6), jul (6), sorry (6), something (6), went (6), wrong (6), wstring (6), argument (6), contributor (6), 2020 (6), what (6), jump (6), about (5), request (5), version (5), 10200 (5), oct (5), mentioned (5), jtattermusch (5), non (5), ascii (5), command_line_interface (5), characters (5), nuget (5), support (5), open (5), may (5), packages (5), your (4), security (4), account (4), added (4), commit (4), referenced (4), bugfix (4), handle (4), argumentfile (4), default (4), team (4), bot (4), users (4), closed (4), correctly (4), instead (4), line (4), needs (4), compiler (4), jun (4), but (4), would (4), gen (4), issues (4), terms (3), requests (3), projects (3), have (3), are (3), errors (3), upgrade (3), deannagarcia (3), into (3), cstx (3), when (3), doesn (3), conversion (3), just (3), using (3), solution (3), expandargumentfile (3), need (3), src (3), see (3), windows (3), project (3), exe (3), grpc_out (3), did (3), test (3), comments (3), multi (3), char (3), actions (3), repository (3), nov (3), signed (2), out (2), another (2), tab (2), window (2), refresh (2), session (2), reload (2), blog (2), pricing (2), contact (2), privacy (2), footer (2), navigation (2), milestone (2), labels (2), assignees (2), already (2), free (2), force (2), uninstall (2), change (2), avoid (2), longer (2), kokoro (2), xcode (2), googleberg (2), work (2), update (2), noreply (2), matt (2), gmail (2), brad (2), merged (2), use (2), createprocessw (2), reacted (2), thumbs (2), emoji (2), seems (2), uses (2), subprocess (2), each (2), used (2), commandlineinterface (2), isn (2), supporting (2), files (2), without (2), ifstream (2), valid (2), was (2), http (2), org (2), author (2), which (2), logic (2), know (2), wide (2), wifstream (2), related (2), our (2), username (2), containing (2), https (2), die (2), system (2), rsp (2), opened (2), community (2), insights (2), wiki (2), source (2), plan (2), manage (2), web (2), can, perform, action, time, training, api, docs, status, inc, participants, branches, development, none, yet, comment, join, conversation, python, macos, builds, seeing, failures, brew, due, package, install, error, spelling, kotlin, define, no_threadlocal, openbsd, osx, 480629524, mark, instance, immutable, first, race, during, static, initialization, instances, auto, capitalize, enums, name, ruby, edit, toolchain, absl, dep, bump, upb, latest, after, fixes, applied, 202210180838, updating, json, repo, numbers, changelog, generated, protos, 69992229, kulukundis, deanna, garcia, smith, comstyle, jerry, berg, 107155935, tison, wander4096, 10785, 10783, 1965, closes, 10763, 10454, 10770, 10732, 10717, c302d90, 10788, main, mkruskal, 10721, pushed, obuf, c44d623, prot, completed, 464959a, assigned, handled, a34d060, reaction, tested, own, locally, problem, calling, plugins, createprocessa, start, handles, utf8, as_windows_path, io_win32, reading, encoded, sequence, bytes, done, looking, changing, fact, think, correct, wistream, writes, c_str, file_stream, 1429, 512f42c, original, location, referring, year, complete, anachronism, really, must, fixed, best, keep, make, unicode, capable, utf8everywhere, apr, accented, path, breaks, tool, label, sep, elharo, bit, sad, still, many, situations, here, too, deep, afaik, mean, whole, chain, long, way, bool, 1425, 3f5fc4d, sure, making, function, feasible, functions, returns, then, processed, entire, written, edited, handling, filename, 6715, generatecommandlinecommands, generateresponsefilecommands, 22916, implementer, method, acozzette, because, anandolee, genteure, tboby, text, updated, successfully, these, were, encountered, minimal, example, stumbled, over, distribute, through, some, includes, leads, being, parsable, userprofile, dotnet, locals, global, therefore, does, allow, blame, master, l1326, anything, else, should, environment, seem, passed, empty, one, arguments, dejhbk0l, windows_x64, actually, sort, hard, congrats, unfortunately, input, program, going, now, das, kann, angegebene, datei, nicht, finden, running, creating, expect, run, plugin, ágrpc_csharp_plugin, proto, create, build, 1803, operating, linux, libprotoc, language, bottom, clicking, agree, occasionally, send, emails, statement, service, password, email, address, pick, its, maintainers, question, new, more, 596, 57k, star, fork, notifications, public, message, organization, suggested, results, collections, trending, topics, repositories, articles, readme, fund, developers, sponsors, resources, customer, stories, case, studies, devsecops, devops, automation, compare, teams, enterprise, solutions, skills, documentation, features, explore, collaborate, outside, discussions, track, changes, review, write, better, copilot, instant, dev, environments, codespaces, find, vulnerabilities, host, automate, any, workflow, product, toggle, skip, content, wayback, machine, archive, 20221109053256, timestamps, capture, fail, success, 2023, dec, captures,

Text of the page (random words):
argument file needs support for multi char and bom issue 7474 protocolbuffers protobuf github 3 captures 21 nov 2020 09 nov 2022 oct nov dec 09 2021 2022 2023 success fail about this capture timestamps the wayback machine http web archive org web 20221109053256 https github com protocolbuffers protobuf issues 7474 skip to content toggle navigation sign up product actions automate any workflow packages host and manage packages security find and fix vulnerabilities codespaces instant dev environments copilot write better code with ai code review manage code changes issues plan and track work discussions collaborate outside of code explore all features documentation github skills blog solutions by plan enterprise teams compare all by solution ci cd automation devops devsecops case studies customer stories resources open source github sponsors fund open source developers the readme project github community articles repositories topics trending collections pricing in this repository all github jump to no suggested jump to results in this repository all github jump to in this organization all github jump to in this repository all github jump to sign in sign up message protocolbuffers protobuf public notifications fork 14 5k star 57k code issues 596 pull requests 59 actions projects 0 wiki security insights more code issues pull requests actions projects wiki security insights new issue have a question about this project sign up for a free github account to open an issue and contact its maintainers and the community pick a username email address password sign up for github by clicking sign up for github you agree to our terms of service and privacy statement we ll occasionally send you account related emails already on github sign in to your account jump to bottom argument file needs support for multi char and bom 7474 closed falco20019 opened this issue may 7 2020 6 comments closed argument file needs support for multi char and bom 7474 falco20019 opened this issue may 7 2020 6 comments assignees labels protoc comments copy link contributor falco20019 commented may 7 2020 what version of protobuf and what language are you using libprotoc 3 3 0 grpc tools 2 28 1 what operating system linux windows and version windows 10 build 1803 what did you do create test rsp containing non ascii plugin protoc gen grpc ágrpc_csharp_plugin exe grpc_out grpc_out test proto run protoc exe test rsp what did you expect to see protoc running and creating the files what did you see instead utf 8 without bom grpc_out protoc gen grpc das system kann die angegebene datei nicht finden utf 8 with bom you seem to have passed an empty string as one of the arguments to c users dejhbk0l nuget packages grpc tools 2 28 1 tools windows_x64 protoc exe this is actually sort of hard to do congrats unfortunately it is not valid input so the program is going to die now anything else we should know about your project environment https github com protocolbuffers protobuf blame master src google protobuf compiler command_line_interface cc l1326 uses std ifstream instead of std wifstream and therefore does not allow bom or wide characters this is a minimal example we stumbled over this in grpc grpc 17995 as we distribute protoc and the protoc gen grpc through nuget and the default for dotnet nuget locals global packages is userprofile nuget packages for some of our users the username includes non ascii characters which leads to protoc gen grpc containing non ascii characters and the argument file not being parsable the text was updated successfully but these errors were encountered 3 genteure tboby and jd cstx reacted with thumbs up emoji all reactions 3 reactions copy link contributor author falco20019 commented may 7 2020 cc anandolee because it s protoc acozzette as implementer of the method jtattermusch as related to grpc tools all reactions sorry something went wrong falco20019 mentioned this issue may 11 2020 grpc tools use generatecommandlinecommands instead of generateresponsefilecommands grpc grpc 22916 open jtattermusch mentioned this issue jun 7 2021 protoc is not handling non ascii paths correctly on windows when filename argument file is used 6715 open copy link contributor jtattermusch commented jun 7 2021 edited i m not sure if making the expandargumentfile function support std wifstream is feasible the functions returns a std string which is then processed by the command_line_interface cc logic and the entire logic is written in terms of std string and it doesn t know about wide characters at all protobuf src google protobuf compiler command_line_interface cc line 1425 in 3f5fc4d bool commandlineinterface expandargumentfile all reactions sorry something went wrong copy link contributor author falco20019 commented jun 7 2021 not too deep into c but afaik this would mean that the whole chain would need to support std wstring so this change would need to go a long way it s a bit sad to see that utf 8 is still not the default in 2021 in so many situations not just here all reactions sorry something went wrong elharo added the protoc label sep 2 2021 falco20019 mentioned this issue oct 4 2021 grpc tools accented characters in nuget path breaks c grpc tool compiler grpc grpc 17995 closed copy link jd cstx commented apr 20 2022 not supporting utf 8 in the year 2022 is a complete anachronism this really must be fixed but std wstring isn t the solution http utf8everywhere org best would be to just keep using std string but make it unicode capable all reactions sorry something went wrong copy link contributor jtattermusch commented jun 27 2022 the original link to command_line_interface cc is no longer valid this seems to be the location it was referring to protobuf src google protobuf compiler command_line_interface cc line 1429 in 512f42c std ifstream file_stream file c_str all reactions sorry something went wrong copy link contributor tonydnewell commented jul 1 2022 bom doesn t need supporting grpc tools writes out the argument files as utf 8 without bom looking at the protobuf code the fix isn t changing from std string to std wstring and using std wistream in commandlineinterface expandargumentfile in fact i think that is not the correct solution reading each line of the utf 8 encoded file into a std string is correctly each line is just a sequence of bytes it is when the string is used that conversion from utf 8 to std wstring needs to be done io_win32 cc handles conversion from utf8 to std wstring correctly in as_windows_path the problem seems to be when calling the plugins in subprocess cc subprocess start uses createprocessa instead of createprocessw and doesn t do the utf 8 to wstring conversion i ve tested my own fix locally 1 jd cstx reacted with thumbs up emoji all reactions 1 reaction sorry something went wrong tonydnewell added a commit to tonydnewell protobuf that referenced this issue jul 1 2022 fix for grpc tools 17995 protobuf protocolbuffers 7474 a34d060 use createprocessw so that non ascii paths are handled correctly tonydnewell mentioned this issue jul 1 2022 fix for grpc tools 17995 protobuf 7474 handle utf 8 paths in argumentfile 10200 merged jtattermusch assigned fowles jul 5 2022 fowles added a commit that referenced this issue jul 6 2022 merge pull request 10200 from tonydnewell bugfix protobuf 7474 464959a fix for grpc tools 17995 protobuf 7474 handle utf 8 paths in argumentfile fowles closed this as completed jul 16 2022 tonydnewell pushed a commit to tonydnewell protobuf that referenced this issue oct 5 2022 merge pull request protocolbuffers 10200 from tonydnewell bugfix prot c44d623 obuf 7474 fix for grpc tools 17995 protobuf protocolbuffers 7474 handle utf 8 paths in argumentfile tonydnewell mentioned this issue oct 5 2022 merge pull request 10200 from tonydnewell bugfix protobuf 7474 10721 merged mkruskal google added a commit that referenced this issue oct 19 2022 merge 21 8 into main 10788 c302d90 force uninstall protobuf in python macos builds we are seeing failures in brew uninstall protobuf due to no package change this to a force install to avoid the error fix spelling errors 10717 merge pull request 10200 from tonydnewell bugfix protobuf 7474 fix for grpc tools 17995 protobuf 7474 handle utf 8 paths in argumentfile upgrade to kotlin 1 6 21 x no longer define no_threadlocal on openbsd upgrade kokoro to xcode 14 10732 upgrade kokoro to xcode 14 fix osx errors merge pull request 10770 from protocolbuffers googleberg cl 480629524 mark default instance as immutable first to avoid race during static initialization of default instances auto capitalize enums name in ruby 10454 10763 this closes 1965 edit toolchain to work with absl dep bump upb to latest version after fixes applied 10783 21 x 202210180838 10785 updating version json and repo version numbers to 21 8 update changelog co authored by protobuf team bot protobuf team bot google com update generated protos co authored by deannagarcia 69992229 deannagarcia users noreply github com co authored by matt fowles kulukundis matt fowles gmail com co authored by deanna garcia deannagarcia google com co authored by brad smith brad comstyle com co authored by jerry berg 107155935 googleberg users noreply github com co authored by tison wander4096 gmail com co authored by protobuf team bot protobuf team bot google com sign up for free to join this conversation on github already have an account sign in to comment assignees fowles labels protoc projects none yet milestone no milestone development no branches or pull requests 6 participants footer 2022 github inc footer navigation terms privacy security status docs contact github pricing api training blog about you can t perform that action at this time you signed in with another tab or window reload to refresh your session you signed out in another tab or window reload to refresh your session