Meta tags:
description=This closes #1965.;

Headings (most frequently used words):

commented, 2022, tisonkun, sep, edited, jasonlunn, aug, 27, 28, auto, capitalize, enums, name, in, ruby, 10454, footer, 15, conversation, 24, 25, 26, left, comment, 21, 22, 29, navigation,

Text of the page (most frequently used words):
the (63), 2022 (55), this (36), sep (36), #tisonkun (33), all (32), ruby (30), for (30), jasonlunn (27), something (22), sorry (21), went (21), wrong (21), reactions (21), contributor (21), copy (21), link (21), protobuf (20), and (20), com (20), commented (20), you (19), github (18), pull (18), request (17), can (16), author (16), name (15), that (14), changes (14), kokoro (14), enums (13), auto (13), capitalize (13), google (13), jruby (13), signed (12), gmail (12), tests (12), with (11), applied (11), added (11), tison (11), wander4096 (11), 10454 (11), protocolbuffers (10), label (10), off (10), test (10), aug (10), from (9), code (9), sign (9), deannagarcia (9), patch (9), run (9), authored (8), merged (8), but (8), enum (8), use (8), case (8), suggestions (7), suggestion (7), resolved (7), commit (7), 1965 (7), oct (7), review (7), edited (7), cruby (7), your (6), cannot (6), merge (6), have (6), may (6), these (6), thanks (6), commits (6), value (6), jump (6), while (5), not (5), add (5), only (5), release (5), comment (5), closes (5), into (5), main (5), mkruskal (5), removed (5), lower (5), more (5), cases (5), new (5), haberman (5), about (4), security (4), change (4), make (4), issues (4), already (4), account (4), referenced (4), fix (4), define (4), first (4), work (4), team (4), bot (4), mentioned (4), when (4), passed (4), view (4), hide (4), think (4), pass (4), help (4), unit (4), compiler (4), show (4), anandolee (4), open (4), time (3), line (3), comments (3), reviews (3), batch (3), because (3), lowercase (3), projects (3), conversation (3), free (3), upgrade (3), default (3), version (3), json (3), update (3), fowles (3), 10763 (3), here (3), now (3), please (3), rbenv (3), global (3), java (3), action_env (3), path (3), bundle (3), rake (3), locally (3), original (3), constant (3), let (3), issue (3), letter (3), real (3), doesn (3), decode_json (3), what (3), wrongly (3), changed (3), fails (3), file (3), failure (3), hidden (3), part (3), testenum (3), some (3), find (3), requested (3), message (3), characters (3), unicode (3), actions (3), repository (3), out (2), another (2), tab (2), window (2), refresh (2), session (2), reload (2), blog (2), pricing (2), contact (2), privacy (2), terms (2), footer (2), navigation (2), deleted (2), single (2), one (2), closed (2), invalid (2), made (2), possible (2), milestone (2), include (2), description (2), next (2), notes (2), yes (2), reviewers (2), force (2), uninstall (2), install (2), avoid (2), errors (2), 7474 (2), xcode (2), googleberg (2), mark (2), during (2), users (2), noreply (2), matt (2), brad (2), pick (2), 10708 (2), should (2), branch (2), checks (2), details (2), take (2), bazel (2), conformance_test (2), exec (2), revert (2), unrelated (2), wait (2), following (2), try (2), even (2), accepts (2), means (2), nothing (2), output (2), clarify (2), specific (2), mean (2), wrote (2), why (2), needs (2), expectation (2), conformance (2), two (2), any (2), solution (2), text (2), different (2), will (2), well (2), usage (2), ignore (2), don (2), just (2), addressed (2), seems (2), related (2), push (2), nameerror (2), appears (2), workspace (2), lib (2), descriptor_dsl (2), fail (2), string (2), assigned (2), ext (2), protobuf_c (2), address (2), could (2), bidirectional (2), community (2), project (2), insights (2), wiki (2), requests (2), source (2), plan (2), manage (2), packages (2), web (2), nov (2), perform, action, training, api, docs, status, inc, queued, multi, pending, has, been, marked, outdated, must, existing, order, create, valid, applying, lines, supported, per, viewing, subset, were, participants, successfully, merging, close, development, none, yet, labels, assignees, join, python, macos, builds, are, seeing, failures, brew, due, package, error, spelling, tonydnewell, bugfix, grpc, tools, 17995, handle, utf, paths, argumentfile, kotlin, longer, no_threadlocal, openbsd, osx, 480629524, instance, immutable, race, static, initialization, instances, edit, toolchain, absl, dep, bump, upb, latest, after, fixes, 202210180838, updating, repo, numbers, changelog, generated, protos, 69992229, kulukundis, deanna, garcia, smith, comstyle, jerry, berg, 107155935, 10785, 10783, 10770, 10732, 10200, 10717, c302d90, 10788, pushed, fa5a9e1, 1291e4a, 6c40b13, though, long, determinate, estimate, days, weeks, bit, hurry, like, know, whether, come, gem, wants, contribution, 2d08621, approved, reaction, reacted, thumbs, emoji, changeset, minimal, look, 9d7fbf0, improve, method, conformance_test_jruby, ruby_platform, gem_path, gem_home, verbose_failures, updated, tidy, c02698a, 4bc1091, 114185c, minute, purpose, rule, narrow, scope, waiting, emmm, mistake, started, resolve, debugging, deeper, expressive, say, reflect, world, read, full, under, control, depends, implementation, follow, ups, understand, things, further, anyway, currently, thoroughgoing, codec, format, constants, represent, allowed, encode, works, self, interop, between, languages, starting, using, without, changing, proto, keep, binary, compatible, d93fa0b, last, described, above, remove, autotools, 10132, load, items, 8f604a7, cpp, style, hmm, hope, build, protoc, built, still, failed, updates, used, same, unsure, b5da5e7, need, effort, consider, finish, end, proto2, add_enum, found, calls, spend, would, lot, tell, which, logic, writes, enummodule, how, instructions, also, missing, common_tests, reviewed, interpreters, limited, assertion, separately, call, rangeerror, unknown, symbol, field, uninitialized, basictest, assert, proto_module, exception, targets, including, gc_test, add_serialized_file, rubydescriptorpool, 125, internal_add_file, add_file, passing, failing, stack, trace, bad, 860, d30f0bb, 3ac6b87, tolerate, 1314fb9, unassigned, submitting, highlighted, couple, concerns, they, straightforward, left, tasks, give, triggering, workflows, there, investigate, 44895f1, dup, modification, ef80643, contains, interpreted, compiled, differently, than, below, editor, reveals, learn, files, bottom, clicking, agree, our, occasionally, send, emails, statement, service, password, email, username, its, maintainers, question, 596, 57k, star, fork, notifications, public, organization, suggested, results, collections, trending, topics, repositories, articles, readme, fund, developers, sponsors, resources, customer, stories, studies, devsecops, devops, automation, compare, teams, enterprise, solutions, skills, documentation, features, explore, collaborate, outside, discussions, track, write, better, copilot, instant, dev, environments, codespaces, vulnerabilities, host, automate, workflow, product, toggle, skip, content, wayback, machine, http, archive, org, 20221109053254, https, timestamps, capture, success, 2023, 2021, dec, captures,

Text of the page (random words):
tamps the wayback machine http web archive org web 20221109053254 https github com protocolbuffers protobuf pull 10454 skip to content toggle navigation sign up product actions automate any workflow packages host and manage packages security find and fix vulnerabilities codespaces instant dev environments copilot write better code with ai code review manage code changes issues plan and track work discussions collaborate outside of code explore all features documentation github skills blog solutions by plan enterprise teams compare all by solution ci cd automation devops devsecops case studies customer stories resources open source github sponsors fund open source developers the readme project github community articles repositories topics trending collections pricing in this repository all github jump to no suggested jump to results in this repository all github jump to in this organization all github jump to in this repository all github jump to sign in sign up message protocolbuffers protobuf public notifications fork 14 5k star 57k code issues 596 pull requests 59 actions projects 0 wiki security insights more code issues pull requests actions projects wiki security insights new issue have a question about this project sign up for a free github account to open an issue and contact its maintainers and the community pick a username email address password sign up for github by clicking sign up for github you agree to our terms of service and privacy statement we ll occasionally send you account related emails already on github sign in to your account jump to bottom auto capitalize enums name in ruby 10454 merged jasonlunn merged 21 commits into protocolbuffers main from tisonkun patch 1 sep 28 2022 merged auto capitalize enums name in ruby 10454 jasonlunn merged 21 commits into protocolbuffers main from tisonkun patch 1 sep 28 2022 conversation 40 commits 21 checks 5 files changed conversation this file contains bidirectional unicode text that may be interpreted or compiled differently than what appears below to review open the file in an editor that reveals hidden unicode characters learn more about bidirectional unicode characters show hidden characters copy link contributor tisonkun commented aug 24 2022 this closes 1965 sorry something went wrong all reactions auto capitalize enums name in ruby ef80643 this closes protocolbuffers 1965 tisonkun mentioned this pull request aug 24 2022 make it possible to have lowercase enums in ruby 1965 closed dup string for modification 44895f1 signed off by tison wander4096 gmail com anandolee requested a review from haberman aug 24 2022 anandolee assigned haberman aug 24 2022 anandolee added the ruby label aug 24 2022 copy link contributor author tisonkun commented aug 25 2022 anandolee could you help with triggering the ci workflows if there re some failure i can investigate during wait for reviews all reactions sorry something went wrong fowles added the kokoro run label aug 25 2022 protobuf kokoro removed the kokoro run label aug 25 2022 copy link contributor author tisonkun commented aug 26 2022 it seems all tasks passed haberman could you give this patch a review all reactions sorry something went wrong jasonlunn requested changes sep 1 2022 view changes copy link contributor jasonlunn left a comment thanks for submitting the patch i ve highlighted a couple of concerns but i think they re straightforward to address sorry something went wrong all reactions ruby ext google protobuf_c message c show resolved hide resolved ruby ext google protobuf_c message c show resolved hide resolved jasonlunn assigned jasonlunn and unassigned haberman sep 1 2022 jasonlunn added the release notes yes include this pr description in the next release label sep 1 2022 tisonkun added 3 commits sep 4 2022 free name string 1314fb9 signed off by tison wander4096 gmail com tolerate lowercase first letter for jruby 3ac6b87 signed off by tison wander4096 gmail com add test cases d30f0bb signed off by tison wander4096 gmail com tisonkun requested review from jasonlunn and removed request for haberman sep 4 2022 copy link contributor author tisonkun commented sep 4 2022 jasonlunn thanks for your reviews comments addressed all reactions sorry something went wrong jasonlunn added the kokoro run label sep 6 2022 protobuf kokoro removed the kokoro run label sep 6 2022 copy link contributor jasonlunn commented sep 6 2022 thanks tisonkun is the new test passing for you locally it is failing in ci the jruby changes fail with nameerror bad constant name 860 with stack trace add_serialized_file at com google protobuf jruby rubydescriptorpool java 125 internal_add_file at workspace ruby lib google protobuf descriptor_dsl rb 65 add_file at workspace ruby lib google protobuf descriptor_dsl rb 43 this exception appears in all the tests targets including gc_test and the conformance_test not just the unit tests in the cruby interpreters the failure is limited to the unit tests the new assertion assert proto_module testenum v0 4 fails with nameerror uninitialized constant basictest testenum v0 and separately the new call to push l push v0 fails with rangeerror unknown symbol value for enum field all reactions sorry something went wrong jasonlunn reviewed sep 6 2022 view changes ruby tests common_tests rb show resolved hide resolved copy link contributor author tisonkun commented sep 9 2022 edited jasonlunn how can i run tests locally i don t find some instructions also the test output is missing let me try out rake test all reactions sorry something went wrong copy link contributor author tisonkun commented sep 9 2022 ok i found that i only changed for enummodule calls but not for the compiler i will spend some time to find the related code and made the change but it would help a lot if you can tell when which logic writes add_enum a b proto2 testenum do value default 0 value a 1 value b 2 value c 3 value v0 4 end all reactions sorry something went wrong copy link contributor author tisonkun commented sep 9 2022 for jruby it may need more effort and i may consider we finish the cruby part first and following up for the jruby part i work on this part time and my use case is cruby only all reactions sorry something went wrong update the compiler b5da5e7 signed off by tison wander4096 gmail com copy link contributor author tisonkun commented sep 9 2022 edited addressed the ruby unit test can be still failed because updates to the compiler seems not be used by the unit test in the same patch i m unsure if we should make the compiler changes in first hmm i hope the ci can build the protoc and use the new one just built all reactions sorry something went wrong use cpp style 8f604a7 signed off by tison wander4096 gmail com 31 hidden items load more tisonkun mentioned this pull request sep 15 2022 remove all autotools usage 10132 merged copy link contributor author tisonkun commented sep 15 2022 edited well the last two commits don t help on decode_json auto capitalize for jruby as described above all reactions sorry something went wrong add failure ignore d93fa0b signed off by tison wander4096 gmail com copy link contributor author tisonkun commented sep 15 2022 edited jasonlunn deannagarcia i think ignore these cases for jruby is ok if you define an enum starting with lower case it s already invalid for ruby we auto capitalize for using the enum without changing the proto file while keep pb binary compatible now if we encode to json v0 will be v0 and it works well for ruby self usage but fails if interop between different languages a thoroughgoing solution can be 1 add a mark of the original name for codec in text json format 2 use something different from ruby s constants to represent enum so that lower letter is allowed anyway currently these cases pass wrongly even decode_json accepts enum name in lower case it means nothing for a real ruby use case all reactions sorry something went wrong deannagarcia added the kokoro run label sep 15 2022 protobuf kokoro removed the kokoro run label sep 15 2022 copy link contributor author tisonkun commented sep 21 2022 jasonlunn deannagarcia mkruskal google any further comments here all reactions sorry something went wrong copy link contributor jasonlunn commented sep 22 2022 tisonkun can you help me understand two things why is it that only jruby needs expectation changes to the conformance tests but cruby doesn t can you clarify what specific tests you mean when you wrote these cases pass wrongly all reactions sorry something went wrong copy link contributor author tisonkun commented sep 27 2022 edited jasonlunn thanks for your follow ups why is it that only jruby needs expectation changes to the conformance tests but cruby doesn t please read 10454 comment the cruby path is full under control and can be changed while the jruby path depends on java protobuf implementation can you clarify what specific tests you mean when you wrote these cases pass wrongly even decode_json accepts enum name in lower case it means nothing for a real ruby use case i m debugging deeper in a more expressive output or i d say the tests pass but it doesn t reflect a real world use case all reactions sorry something went wrong copy link contributor author tisonkun commented sep 27 2022 edited emmm i may make a mistake here that we can already use resolve to work with lower letter started enums let me comment on the original issue 1965 comment waiting for reviewers suggestion all reactions sorry something went wrong copy link contributor author tisonkun commented sep 27 2022 wait a minute i think the original purpose is to define the constant following ruby s rule let me try to narrow the change scope all reactions sorry something went wrong tisonkun added 3 commits sep 28 2022 merge branch main into patch 1 114185c revert cruby enum unrelated changes 4bc1091 signed off by tison wander4096 gmail com revert jruby enum unrelated changes c02698a signed off by tison wander4096 gmail com copy link contributor author tisonkun commented sep 28 2022 updated i think this patch is tidy now all tests passed locally rbenv global 3 1 2 bazel test ruby conformance_test rbenv global jruby 9 3 7 0 bazel test ruby conformance_test_jruby define ruby_platform java action_env path action_env gem_path action_env gem_home verbose_failures cd ruby bundle install bundle exec rake test rbenv global 3 1 2 bundle exec rake test cc jasonlunn deannagarcia please take a review all reactions sorry something went wrong improve jruby method 9d7fbf0 signed off by tison wander4096 gmail com jasonlunn added the kokoro run label sep 28 2022 protobuf kokoro removed the kokoro run label sep 28 2022 copy link contributor author tisonkun commented sep 28 2022 jasonlunn deannagarcia mkruskal google all tests passed now and the changeset is minimal please take a look 1 jasonlunn reacted with thumbs up emoji all reactions 1 reaction sorry something went wrong jasonlunn approved these changes sep 28 2022 view changes hide details view details jasonlunn merged commit 2d08621 into protocolbuffers main sep 28 2022 59 checks passed copy link contributor jasonlunn commented sep 28 2022 thanks for you contribution tisonkun all reactions sorry something went wrong tisonkun deleted the patch 1 branch sep 29 2022 copy link contributor author tisonkun commented sep 29 2022 edited jasonlunn thanks for your review i may be a bit in a hurry but i d like to know whether when we can have a release for this patch i come here because my gem wants it it s not a request though and as long as we have a determinate estimate days or weeks should be ok all reactions sorry something went wrong tisonkun added a commit to tisonkun protobuf that referenced this pull request oct 4 2022 auto capitalize enums name in ruby protocolbuffers 10454 6c40b13 this closes protocolbuffers 1965 tisonkun mentioned this pull request oct 4 2022 auto capitalize enums name in ruby 10454 10708 merged deannagarcia added a commit that referenced this pull request oct 6 2022 merge pull request 10708 from tisonkun pick ruby auto capitalize 1291e4a auto capitalize enums name in ruby 10454 mkruskal google mentioned this pull request oct 12 2022 auto capitalize enums name in ruby 10454 10763 merged mkruskal google pushed a commit that referenced this pull request oct 13 2022 auto capitalize enums name in ruby 10454 10763 fa5a9e1 this closes 1965 mkruskal google added a commit that referenced this pull request oct 19 2022 merge 21 8 into main 10788 c302d90 force uninstall protobuf in python macos builds we are seeing failures in brew uninstall protobuf due to no package change this to a force install to avoid the error fix spelling errors 10717 merge pull request 10200 from tonydnewell bugfix protobuf 7474 fix for grpc tools 17995 protobuf 7474 handle utf 8 paths in argumentfile upgrade to kotlin 1 6 21 x no longer define no_threadlocal on openbsd upgrade kokoro to xcode 14 10732 upgrade kokoro to xcode 14 fix osx errors merge pull request 10770 from protocolbuffers googleberg cl 480629524 mark default instance as immutable first to avoid race during static initialization of default instances auto capitalize enums name in ruby 10454 10763 this closes 1965 edit toolchain to work with absl dep bump upb to latest version after fixes applied 10783 21 x 202210180838 10785 updating version json and repo version numbers to 21 8 update changelog co authored by protobuf team bot protobuf team bot google com update generated protos co authored by deannagarcia 69992229 deannagarcia users noreply github com co authored by matt fowles kulukundis matt fowles gmail com co authored by deanna garcia deannagarcia google com co authored by brad smith brad comstyle com co authored by jerry berg 107155935 googleberg users noreply github com co authored by tison wander4096 gmail com co authored by protobuf team bot protobuf team bot google com sign up for free to join this conversation on github already have an account sign in to comment reviewers jasonlunn assignees jasonlunn labels release notes yes include this pr description in the next release ruby projects none yet milestone no milestone development successfully merging this pull request may close these issues make it possible to have lowercase enums in ruby 7 participants add this suggestion to a batch that can be applied as a single commit this suggestion is invalid because no changes were made to the code suggestions cannot be applied while the pull request is closed suggestions cannot be applied while viewing a subset of changes only one suggestion per line can be applied in a batch add this suggestion to a batch that can be applied as a single commit applying suggestions on deleted lines is not supported you must change the existing code in this line in order to create a valid suggestion outdated suggestions cannot be applied this suggestion has been applied or marked resolved suggestions cannot be applied from pending reviews suggestions cannot be applied on mul...